From: "Laszlo Ersek" <lersek@redhat.com>
To: Satoshi Tanda <tanda.sat@gmail.com>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain
Date: Tue, 25 May 2021 18:24:59 +0200 [thread overview]
Message-ID: <fa5c1a9b-ef4e-5f9c-efe9-0dd0486cd64b@redhat.com> (raw)
In-Reply-To: <31414.1621952894822244633@groups.io>
On 05/25/21 16:28, Satoshi Tanda wrote:
> On Tue, May 25, 2021 at 05:16 AM, Laszlo Ersek wrote:
>
>>
>> (1) The BZ URL is incorrect;
>
>>
>> (2) Similarly, I think the subject should be clarified, upon merge
>
> Let me know if anyone needs the updates of the patch on those (vs updating them inline at PR). I will do it if required.
I'll leave that decision to the MdePkg owners.
>
>>
>> Should this go into edk2-stable202105?
>
> No, to me. I do not find a reason to rush it neither.
>
>>
>> CC'ing the MdePkg maintainers (see "Maintainers.txt" and "$EDK_TOOLS_PATH/Scripts/GetMaintainer.py").
>>
>
> This document should probably be updated to mention them later. Those are not explained.
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
It is spelled out in the "unkempt git guide", in this section:
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-18
but indeed it's not part of the official (normative) article.
The problem with writing more documentation is that then you have to
keep more documentation up-to-date :/
Thanks,
Laszlo
>
> Thanks for the reviewing this and guiding me on the process.
>
> Satoshi
>
next prev parent reply other threads:[~2021-05-25 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 4:50 [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain Satoshi Tanda
2021-05-25 12:16 ` [edk2-devel] " Laszlo Ersek
2021-05-25 14:28 ` Satoshi Tanda
2021-05-25 16:24 ` Laszlo Ersek [this message]
2021-06-04 0:24 ` Satoshi Tanda
2021-06-04 3:03 ` 回复: " gaoliming
2021-06-04 3:28 ` [edk2-devel] " Satoshi Tanda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa5c1a9b-ef4e-5f9c-efe9-0dd0486cd64b@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox