From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.165.1621959905572174843
 for <devel@edk2.groups.io>;
 Tue, 25 May 2021 09:25:05 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YvoQwJo8;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1621959904;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UCt8/iZDjJHNC18dcg9j80L9UpCjLGVDO+D/OBJ5rfc=;
	b=YvoQwJo8IId3vY3VuaBpYd1nLRs/AMVnyJRkx57Mj69Q6gzbSKObhKF5v5A9f3GFPkmBAC
	9lDTNCHenDxtIp7CdQeFDtNJASJKs+iR7Oz7TZO9onT4bhj+ngkYbGXsU4RCs/egaC7lMv
	T5Re3FtRjBUFmv1PDGGTXyD6bbMYFZw=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-518-H4K81ITpNyu4ggixBPw6bw-1; Tue, 25 May 2021 12:25:02 -0400
X-MC-Unique: H4K81ITpNyu4ggixBPw6bw-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33B96180FD62;
	Tue, 25 May 2021 16:25:01 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-195.ams2.redhat.com [10.36.112.195])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B7322ED65;
	Tue, 25 May 2021 16:25:00 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain
To: Satoshi Tanda <tanda.sat@gmail.com>, devel@edk2.groups.io
References: <6b450e1c-2d29-7fb3-1fc7-6fb55f170b06@redhat.com>
 <31414.1621952894822244633@groups.io>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <fa5c1a9b-ef4e-5f9c-efe9-0dd0486cd64b@redhat.com>
Date: Tue, 25 May 2021 18:24:59 +0200
MIME-Version: 1.0
In-Reply-To: <31414.1621952894822244633@groups.io>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 05/25/21 16:28, Satoshi Tanda wrote:
> On Tue, May 25, 2021 at 05:16 AM, Laszlo Ersek wrote:
> 
>>
>> (1) The BZ URL is incorrect;
> 
>>
>> (2) Similarly, I think the subject should be clarified, upon merge
> 
> Let me know if anyone needs the updates of the patch on those (vs updating them inline at PR). I will do it if required.

I'll leave that decision to the MdePkg owners.

> 
>>
>> Should this go into edk2-stable202105?
> 
> No, to me. I do not find a reason to rush it neither.
> 
>>
>> CC'ing the MdePkg maintainers (see "Maintainers.txt" and "$EDK_TOOLS_PATH/Scripts/GetMaintainer.py").
>>
> 
> This document should probably be updated to mention them later. Those are not explained.
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

It is spelled out in the "unkempt git guide", in this section:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-18

but indeed it's not part of the official (normative) article.

The problem with writing more documentation is that then you have to
keep more documentation up-to-date :/

Thanks,
Laszlo

> 
> Thanks for the reviewing this and guiding me on the process.
> 
> Satoshi
>