From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6646.1639750528486097354 for ; Fri, 17 Dec 2021 06:15:28 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B575C12FC; Fri, 17 Dec 2021 06:15:20 -0800 (PST) Received: from [10.34.125.45] (e126645.nice.arm.com [10.34.125.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DB1273F5A1; Fri, 17 Dec 2021 06:15:19 -0800 (PST) Subject: Re: [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec To: Sami Mujawar , devel@edk2.groups.io, nd References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-4-Pierre.Gondois@arm.com> <1d258442-24c4-c155-36f9-f8f42edbefa0@arm.com> From: "PierreGondois" Message-ID: Date: Fri, 17 Dec 2021 15:15:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <1d258442-24c4-c155-36f9-f8f42edbefa0@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Sami, You are correct, as stated in Silicon/Hisilicon/Library/ArmPlatformLibHis= ilicon/ArmPlatformLibSec.inf: "Based on the files under ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpre= ssLibRTSM/" Thanks for updating the commit, Regards, Pierre On 12/17/21 2:59 PM, Sami Mujawar wrote: > Hi Pierre, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > > On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: >> From: Pierre Gondois >> >> The two following modules have the same GUID: >> - Platform/ARM/VExpressPkg/Library/ >> =C2=A0=C2=A0 ArmVExpressLibRTSM/ArmVExpressLibSec.inf >> - Silicon/Hisilicon/Library/ >> =C2=A0=C2=A0 ArmPlatformLibHisilicon/ArmPlatformLibSec.inf >> >> The inf file in the Platform/ARM/ folder is based >> on the one in Silicon/Hisilicon/. Modify the one > [SAMI] I believe you want to say the inf file in Silicon/Hisilicon/is b= ased on the one in Platform/ARM and therefore you are modifying the inf f= ile in Silicon/Hisilicon. > Please let me know if this is correct, and I will update this in the co= mmit message before merging the change. > [/SAMI] >> in the Silicon/Hisilicon/. >> >> Signed-off-by: Pierre Gondois >> --- >> =C2=A0 .../Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +- >> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlat= formLibSec.inf b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPla= tformLibSec.inf >> index ac587deedfd8..7fd7b5183e5b 100644 >> --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib= Sec.inf >> +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib= Sec.inf >> @@ -12,7 +12,7 @@ >> =C2=A0 [Defines] >> =C2=A0=C2=A0=C2=A0 INF_VERSION=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = =3D 0x00010005 >> =C2=A0=C2=A0=C2=A0 BASE_NAME=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 =3D ArmPlatformLibSec >> -=C2=A0 FILE_GUID=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = =3D a79eed97-4b98-4974-9690-37b32d6a5b56 >> +=C2=A0 FILE_GUID=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = =3D ABF3B82B-892F-438F-901F-F148C2DF89E6 >> =C2=A0=C2=A0=C2=A0 MODULE_TYPE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = =3D BASE >> =C2=A0=C2=A0=C2=A0 VERSION_STRING=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 1.0 >> =C2=A0=C2=A0=C2=A0 LIBRARY_CLASS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D ArmPl= atformLib >> --=20 >> 2.25.1 >