From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mx.groups.io with SMTP id smtpd.web10.55470.1597704726010691635 for ; Mon, 17 Aug 2020 15:52:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=RdYyupWc; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.167.44, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-lf1-f44.google.com with SMTP id c15so9209299lfi.3 for ; Mon, 17 Aug 2020 15:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=2++4vCU5sr5VVq+4fAQWt5TraPe3sRSF248XVRWscEA=; b=RdYyupWcW6sAuAWxtDK+adM0NQUozKGdyq0P3J1bhnq6DKZ9ATIzC6oYze2yXnjFx5 Thj+nwi4Qdgtv8nJGwQOqINGdg7l3NG7G5E4hWYDkqoTphB+WTcKCTfoc/UsHb/uS8m4 LfmtoJoLU/G8GwSNiN7mXuRPJI3R9LAL1c59M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=2++4vCU5sr5VVq+4fAQWt5TraPe3sRSF248XVRWscEA=; b=D5qZsdT8+pfuCva3JUm2Cx9WB5nwXzHzDmA30XeGQgXWxiFLW/a6fWENzCpnpxBEox /4UI6ZD4q79KExtbOe8Ajx7qC/ATN9ApOwYYWIvLrxpvDQ8O8C4+iXMXFZtX+tkf0dAO 7GuUPQ/3knbsTTkxyJrfScL8NGoN80uxj80TLDTqTkYXw51UURAG9A7/ICwf65ZMpM3F g/f8B4/2be3Ntnz4M33ljGofikTaw3jHL/OOIZHEhD0m5NKicv0Ly4JacW/ccH55vlRE MmmM2SRdhSFqxWT1X0QkSwzaBbZoDplJaLABF5ijD58H9elZcH9iPscQrT9WpYeCYm5B 5T/g== X-Gm-Message-State: AOAM531w6k0y3gWMl5MxHHflYqUypC9zwwProga7MyRXx5idVpcRFxLJ Wkga4s0ltutFumSUrHi3x6e2x2xO1dBzcVUj1Ap0KQ== X-Google-Smtp-Source: ABdhPJwtYn5Am81DXY9eC4PD91zbqEgKS4AI0Q6Wgz6N1vkRW2RnwlprzZYxv0d2CZELqpCSdwi4gVYISn+CkMik24g= X-Received: by 2002:a05:6512:36cf:: with SMTP id e15mr8483643lfs.149.1597704723788; Mon, 17 Aug 2020 15:52:03 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200727164830.25829-1-vladimir.olovyannikov@broadcom.com> <20200727164830.25829-2-vladimir.olovyannikov@broadcom.com> <25b5ce9498095e68650b8817e4523714@mail.gmail.com> <2a710789-bfdd-dd80-386a-04fbd46d4835@redhat.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQILIYHslp9C8beoIeXBb+C1khe8nAJZRV/xAGCCW/QCSmia/gFipDoLAhIip3QCjNqSBgK2ARQXqGWwQRA= Date: Mon, 17 Aug 2020 15:52:01 -0700 Message-ID: Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Laszlo Ersek , "Rabeda, Maciej" , "Gao, Zhichao" , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , "Wu, Jiaxin" , "Fu, Siyuan" , "Ni, Ray" , "Gao, Liming" , Nd Content-Type: text/plain; charset="UTF-8" > -----Original Message----- > From: Laszlo Ersek > Sent: Monday, August 17, 2020 1:44 PM > To: Vladimir Olovyannikov ; > Rabeda, Maciej ; Gao, Zhichao > ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ; Nd > > Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 08/17/20 20:29, Vladimir Olovyannikov wrote: > >> -----Original Message----- > >> From: Laszlo Ersek > >> Sent: Monday, August 17, 2020 11:01 AM > >> To: Rabeda, Maciej ; Vladimir > >> Olovyannikov ; Gao, Zhichao > >> ; devel@edk2.groups.io > >> Cc: Samer El-Haj-Mahmoud ; Wu, > Jiaxin > >> ; Fu, Siyuan ; Ni, Ray > >> ; Gao, Liming ; Nd > >> > >> Subject: Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add > >> HttpDynamicCommand > >> > >> On 08/17/20 19:15, Rabeda, Maciej wrote: > >>> Hi Vladimir, > >>> > >>> I cannot apply the patch via 'git am'. > >>> Is your git configured in a manner described here? > >>> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkem > >>> pt -git-guide-for-edk2-contributors-and-maintainers > > Hi Rabeda, > > Yes, I followed the page. I did not run the SetupGit.py though. > >>> > >>> > >>> Laszlo, > >>> > >>> Were you able to apply this patch from .eml file? > >> > >> Yes, but I had to use some tricks (implemented by my colleague Paolo > >> in a python script) to undo the damage caused by the "quoted-printable" > >> content-transfer-encoding on the posting. > >> > >> Our recommended Content-Transfer-Encoding (that is, > >> "sendemail.transferEncoding") is "8bit", or even "base64". > >> quoted-printable is practically impossible to get functional, with > >> the hard CRLF line endings in edk2. > >> > >> "BaseTools/Scripts/SetupGit.py" does set "8bit". > > Thank you for notice Laszlo, > > So, should I run this script and re-send the patch as v6? > > I think that would be useful, yes -- and if you have made no changes since > v5, > you can also post it as "v5 RESEND". If you've implemented some changes > meanwhile, then please post it as v6 indeed. Thanks Laszlo, I will post v6. Vladimir > > Thanks > Laszlo