From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC1511A1E06 for ; Fri, 2 Sep 2016 07:48:50 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A8DE15568; Fri, 2 Sep 2016 14:48:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-76.phx2.redhat.com [10.3.116.76]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u82Emms3014419; Fri, 2 Sep 2016 10:48:48 -0400 To: Leif Lindholm , edk2-devel@ml01.01.org References: <20160902142912.17297-1-leif.lindholm@linaro.org> Cc: Michael D Kinney , Liming Gao , Ard Biesheuvel From: Laszlo Ersek Message-ID: Date: Fri, 2 Sep 2016 16:48:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160902142912.17297-1-leif.lindholm@linaro.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 02 Sep 2016 14:48:50 +0000 (UTC) Subject: Re: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 14:48:51 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/02/16 16:29, Leif Lindholm wrote: > The recent addition, and use, of new functions IsZeroGuid/IsZeroBuffer > caused all ARM/AARCH64 platforms to stop building. The oversight was > helped by the ARM implementation residing in ArmPkg rather than in > MdePkg with all of the others. > > Move BaseMemoryLibStm across to MdePkg to reduce risk of similar > accidents in future, and add the new functions. > > This set resolves the build issue without affecting any non-ARM > platforms, in the interest of getting back to a working master > branch. It would be very nice if it could be approved quickly. > > Ard Biesheuvel (2): > MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function > MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function > > Leif Lindholm (1): > MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg > > ArmPkg/ArmPkg.dsc | 1 - > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- > .../Library/BaseMemoryLibStm/AArch64/CopyMem.c | 0 > .../Library/BaseMemoryLibStm/AArch64/SetMem.c | 0 > .../Library/BaseMemoryLibStm/Arm/CopyMem.S | 0 > .../Library/BaseMemoryLibStm/Arm/CopyMem.asm | 0 > .../Library/BaseMemoryLibStm/Arm/SetMem.S | 0 > .../Library/BaseMemoryLibStm/Arm/SetMem.asm | 0 > .../Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 1 + > .../Library/BaseMemoryLibStm/CompareMemWrapper.c | 0 > .../Library/BaseMemoryLibStm/CopyMem.c | 0 > .../Library/BaseMemoryLibStm/CopyMemWrapper.c | 0 > .../Library/BaseMemoryLibStm/IsZeroBufferWrapper.c | 54 ++++++++++++++++++++++ > .../Library/BaseMemoryLibStm/MemLibGeneric.c | 29 ++++++++++++ > .../Library/BaseMemoryLibStm/MemLibGuid.c | 29 ++++++++++++ > .../Library/BaseMemoryLibStm/MemLibInternals.h | 17 +++++++ > .../Library/BaseMemoryLibStm/ScanMem16Wrapper.c | 0 > .../Library/BaseMemoryLibStm/ScanMem32Wrapper.c | 0 > .../Library/BaseMemoryLibStm/ScanMem64Wrapper.c | 0 > .../Library/BaseMemoryLibStm/ScanMem8Wrapper.c | 0 > .../Library/BaseMemoryLibStm/SetMem.c | 0 > .../Library/BaseMemoryLibStm/SetMem16Wrapper.c | 0 > .../Library/BaseMemoryLibStm/SetMem32Wrapper.c | 0 > .../Library/BaseMemoryLibStm/SetMem64Wrapper.c | 0 > .../Library/BaseMemoryLibStm/SetMemWrapper.c | 0 > .../Library/BaseMemoryLibStm/ZeroMemWrapper.c | 0 > MdePkg/MdePkg.dsc | 1 + > 28 files changed, 133 insertions(+), 3 deletions(-) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf (94%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMem.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c (100%) > create mode 100644 MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c (88%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c (81%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h (90%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c (100%) > rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c (100%) > I believe the series needs a few more (small) patches to update the library resolutions (and other references) in DSC files that become invalid due to the move: $ git grep ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf ArmPkg/ArmPkg.dsc: ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf ArmVirtPkg/ArmVirt.dsc.inc: BaseMemoryLib|ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf BeagleBoardPkg/BeagleBoardPkg.dsc: BaseMemoryLib|ArmPkg/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf Thanks Laszlo