From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from blyat.fensystems.co.uk (blyat.fensystems.co.uk [54.246.183.96])
 by mx.groups.io with SMTP id smtpd.web08.47007.1643715107158918635
 for <devel@edk2.groups.io>;
 Tue, 01 Feb 2022 03:31:47 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: ipxe.org, ip: 54.246.183.96, mailfrom: mcb30@ipxe.org)
Received: from pudding.home (unknown [188.94.42.109])
	by blyat.fensystems.co.uk (Postfix) with ESMTPSA id 8C10744291;
	Tue,  1 Feb 2022 11:31:42 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Frontpage: Get SMBIOS Data from table directly
To: devel@edk2.groups.io, sean@starlabs.systems
Cc: Matt DeVillier <matt.devillier@gmail.com>
References: <dfcff45f586747827e9a87020acb48cfad52b0e3.1643708039.git.sean@starlabs.systems>
From: "Michael Brown" <mcb30@ipxe.org>
Message-ID: <fa9f8e84-5a5b-53a3-a8f5-9a63b2ce3fbb@ipxe.org>
Date: Tue, 1 Feb 2022 11:31:41 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <dfcff45f586747827e9a87020acb48cfad52b0e3.1643708039.git.sean@starlabs.systems>
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
	autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	blyat.fensystems.co.uk
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/02/2022 09:34, Sean Rhodes wrote:
> Gather information from SMBIOS table rather than getting it
> from the EFI SMBIOS protocol for coreboot builds.

Could you not avoid code duplication by exposing the SMBIOS table via 
EFI_SMBIOS_PROTOCOL?  This would provide a much more general solution 
that would not be specific to UiApp/Frontpage.c.

Michael