Re: [PATCH v2 1/4] ArmVirtPkg/FdtClientDxe: supplement missing EFIAPI calling conv specifiers

[Laszlo Ersek <lersek@redhat.com>]

On 03/09/17 18:21, Ard Biesheuvel wrote:
> From: Laszlo Ersek <lersek@redhat.com>
> 
> Add missing EFIAPI calling convention specifiers to STATIC function
> that are exposed via the FdtClientProtocol interface.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> index 7cc0c44ca12a..547a29fce62c 100644
> --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> @@ -29,6 +29,7 @@ STATIC VOID  *mDeviceTreeBase;
>  
>  STATIC
>  EFI_STATUS
> +EFIAPI
>  GetNodeProperty (
>    IN  FDT_CLIENT_PROTOCOL     *This,
>    IN  INT32                   Node,
> @@ -55,6 +56,7 @@ GetNodeProperty (
>  
>  STATIC
>  EFI_STATUS
> +EFIAPI
>  SetNodeProperty (
>    IN  FDT_CLIENT_PROTOCOL     *This,
>    IN  INT32                   Node,
> @@ -267,6 +269,7 @@ FindMemoryNodeReg (
>  
>  STATIC
>  EFI_STATUS
> +EFIAPI
>  GetOrInsertChosenNode (
>    IN  FDT_CLIENT_PROTOCOL     *This,
>    OUT INT32                   *Node
> 

Well, I can't exactly "review" or "ACK" my own patch (or patches mostly
derived from my patches). Leif, can you pls R-b this?

Thanks
Laszlo