From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C6F0B80373 for ; Thu, 9 Mar 2017 09:29:49 -0800 (PST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4FFD4C05AA54; Thu, 9 Mar 2017 17:29:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-228.phx2.redhat.com [10.3.116.228]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v29HTmqT013358; Thu, 9 Mar 2017 12:29:49 -0500 To: Ard Biesheuvel , edk2-devel@ml01.01.org References: <1489080073-13328-1-git-send-email-ard.biesheuvel@linaro.org> <1489080073-13328-2-git-send-email-ard.biesheuvel@linaro.org> Cc: drjones@redhat.com, leif.lindholm@linaro.org From: Laszlo Ersek Message-ID: Date: Thu, 9 Mar 2017 18:29:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1489080073-13328-2-git-send-email-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 09 Mar 2017 17:29:50 +0000 (UTC) Subject: Re: [PATCH v2 1/4] ArmVirtPkg/FdtClientDxe: supplement missing EFIAPI calling conv specifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 17:29:49 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/09/17 18:21, Ard Biesheuvel wrote: > From: Laszlo Ersek > > Add missing EFIAPI calling convention specifiers to STATIC function > that are exposed via the FdtClientProtocol interface. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > index 7cc0c44ca12a..547a29fce62c 100644 > --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c > @@ -29,6 +29,7 @@ STATIC VOID *mDeviceTreeBase; > > STATIC > EFI_STATUS > +EFIAPI > GetNodeProperty ( > IN FDT_CLIENT_PROTOCOL *This, > IN INT32 Node, > @@ -55,6 +56,7 @@ GetNodeProperty ( > > STATIC > EFI_STATUS > +EFIAPI > SetNodeProperty ( > IN FDT_CLIENT_PROTOCOL *This, > IN INT32 Node, > @@ -267,6 +269,7 @@ FindMemoryNodeReg ( > > STATIC > EFI_STATUS > +EFIAPI > GetOrInsertChosenNode ( > IN FDT_CLIENT_PROTOCOL *This, > OUT INT32 *Node > Well, I can't exactly "review" or "ACK" my own patch (or patches mostly derived from my patches). Leif, can you pls R-b this? Thanks Laszlo