From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.1806.1616437840145523978 for ; Mon, 22 Mar 2021 11:30:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WJx0Zx23; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616437839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+nMWvboBbThv1H1AQYyCI0DfwkYFsDBZpk7mEio34Gk=; b=WJx0Zx23Zto31yodG9RqvU7TW2bCsd2HpkkWTRmdZv8/hEjgYIfGxx7oyyhQOeKpJo1Ken 7NQhFUFXlJkgnNOyKbP7DNd+Cx3G9LgWKkaTpVYl8mMwQqbdnbo5/EkOKef/bI0Njn/cxN gZCjRffEoJX3L7ZVKsPalqd39bD1eFQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-A4hV8DODNr6_HyEtfnW1Ig-1; Mon, 22 Mar 2021 14:30:35 -0400 X-MC-Unique: A4hV8DODNr6_HyEtfnW1Ig-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55A53180FCAC; Mon, 22 Mar 2021 18:30:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-223.ams2.redhat.com [10.36.115.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C9489CA0; Mon, 22 Mar 2021 18:30:33 +0000 (UTC) Subject: Re: [patch V2 05/29] ArmVirtPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib To: Dandan Bi , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm References: <20210322080941.6780-1-dandan.bi@intel.com> <20210322080941.6780-6-dandan.bi@intel.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 22 Mar 2021 19:30:32 +0100 MIME-Version: 1.0 In-Reply-To: <20210322080941.6780-6-dandan.bi@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/22/21 09:09, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > MdeLibs.dsc.inc was added for some basic/default library > instances provided by MdePkg and RegisterFilterLibNull Library > was also added into it as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for > RegisterFilterLibNull which will be consumed by IoLib and BaseLib. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Dandan Bi > --- > ArmVirtPkg/ArmVirt.dsc.inc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index d9abadbe70..18b57b61a1 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -1,9 +1,9 @@ > # > # Copyright (c) 2011-2015, ARM Limited. All rights reserved. > # Copyright (c) 2014, Linaro Limited. All rights reserved. > -# Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved. > # Copyright (c) Microsoft Corporation. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > # > @@ -33,10 +33,12 @@ [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > GCC:*_*_ARM_DLINK_FLAGS = -z common-page-size=0x1000 > GCC:*_*_AARCH64_DLINK_FLAGS = -z common-page-size=0x10000 > RVCT:*_*_ARM_DLINK_FLAGS = --scatter $(EDK_TOOLS_PATH)/Scripts/Rvct-Align4K.sct > > [LibraryClasses.common] > + !include MdePkg/MdeLibs.dsc.inc > + For consistency with the existent line: !include NetworkPkg/NetworkLibs.dsc.inc please un-indent this new line as well, by two spaces. With that: Reviewed-by: Laszlo Ersek Thanks Laszlo > !if $(TARGET) == RELEASE > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > !else > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > !endif >