Re: [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully

["Ni, Ruiyu" <ruiyu.ni@Intel.com>]

On 3/24/2018 11:52 AM, Ard Biesheuvel wrote:
> On 23 March 2018 at 21:57, Laszlo Ersek <lersek@redhat.com> wrote:
>> According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is supposed
>> to catch an invalid BltOperation, and report it with
>> EFI_INVALID_PARAMETER.
>>
>> Remove the assertion from QemuVideoGraphicsOutputBlt() that prevents this
>> from working in NOOPT and DEBUG builds.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Rocky <xingrong.ni@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>> Reported-by: Rocky <xingrong.ni@intel.com>
>> Analyzed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=897
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
>> ---
>>
>> Notes:
>>      Repo:   https://github.com/lersek/edk2.git
>>      Branch: qemuvideo_invalid_bltop
>>
>>   OvmfPkg/QemuVideoDxe/Gop.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c
>> index b479d24a8763..d51efc2a83d5 100644
>> --- a/OvmfPkg/QemuVideoDxe/Gop.c
>> +++ b/OvmfPkg/QemuVideoDxe/Gop.c
>> @@ -366,7 +366,7 @@ Returns:
>>
>>     default:
>>       Status = EFI_INVALID_PARAMETER;
>> -    ASSERT (FALSE);
>> +    break;
>>     }
>>
>>     gBS->RestoreTPL (OriginalTPL);
>> --
>> 2.14.1.3.gb7cf6e02401b
>>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray