From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0FDF7224CCC14 for ; Sun, 25 Mar 2018 18:20:10 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2018 18:26:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,362,1517904000"; d="scan'208";a="214774921" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.4]) ([10.239.9.4]) by fmsmga005.fm.intel.com with ESMTP; 25 Mar 2018 18:26:44 -0700 To: Ard Biesheuvel , Laszlo Ersek Cc: edk2-devel-01 , Rocky References: <20180323215714.27542-1-lersek@redhat.com> From: "Ni, Ruiyu" Message-ID: Date: Mon, 26 Mar 2018 09:26:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 01:20:11 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/24/2018 11:52 AM, Ard Biesheuvel wrote: > On 23 March 2018 at 21:57, Laszlo Ersek wrote: >> According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is supposed >> to catch an invalid BltOperation, and report it with >> EFI_INVALID_PARAMETER. >> >> Remove the assertion from QemuVideoGraphicsOutputBlt() that prevents this >> from working in NOOPT and DEBUG builds. >> >> Cc: Ard Biesheuvel >> Cc: Rocky >> Cc: Ruiyu Ni >> Reported-by: Rocky >> Analyzed-by: Ruiyu Ni >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=897 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek > > Reviewed-by: Ard Biesheuvel > >> --- >> >> Notes: >> Repo: https://github.com/lersek/edk2.git >> Branch: qemuvideo_invalid_bltop >> >> OvmfPkg/QemuVideoDxe/Gop.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c >> index b479d24a8763..d51efc2a83d5 100644 >> --- a/OvmfPkg/QemuVideoDxe/Gop.c >> +++ b/OvmfPkg/QemuVideoDxe/Gop.c >> @@ -366,7 +366,7 @@ Returns: >> >> default: >> Status = EFI_INVALID_PARAMETER; >> - ASSERT (FALSE); >> + break; >> } >> >> gBS->RestoreTPL (OriginalTPL); >> -- >> 2.14.1.3.gb7cf6e02401b >> Reviewed-by: Ruiyu Ni -- Thanks, Ray