Re: [edk2-devel] [PATCH edk2-platforms v3 3/3] Platform/SbsaQemu: handle systems without GIC ITS

["Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>]

W dniu 19.07.2023 o 14:08, Marcin Juszkiewicz via groups.io pisze:
> If firmware is used with QEMU 8.0 or older then there will be no GIC ITS
> support.
> 
> In such case we would not add information about it into MCFG and there
> will be no IORT table.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
>   .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf   |   1 -
>   .../SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf       |   1 +
>   .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 218 +++++++++++++++++-
>   Silicon/Qemu/SbsaQemu/AcpiTables/Iort.aslc    | 135 -----------
>   4 files changed, 208 insertions(+), 147 deletions(-)
>   delete mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Iort.aslc

> diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c


> +  // Initialize IORT ACPI Header
> +  EFI_ACPI_6_0_IO_REMAPPING_TABLE Header = {
> +    SBSAQEMU_ACPI_HEADER(EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
> +                         SBSA_IO_REMAPPING_STRUCTURE,
> +                         EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00),
> +    1,

This should be 3 (ITS, SMMU, RC). I had code which bumped it to 3 and 
then removed it without checking.

Will send v4.

> +    sizeof(EFI_ACPI_6_0_IO_REMAPPING_TABLE),        // NodeOffset
> +    0 };



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107828): https://edk2.groups.io/g/devel/message/107828
Mute This Topic: https://groups.io/mt/100798349/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-