From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A3614AC0D3C for ; Thu, 17 Aug 2023 11:27:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FfWO2+4zRFAh878nmBoKcqIgsDMH4R1jwWigzED5r/w=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692271655; v=1; b=un9WwO9gY8ZVK54vvx8BHSaUIKdYS9IR8A7p8jxYKIfQ2LeFhVjCLya/3kLqvozXZkBOBk1D To4nYZbuazgXUaTUsGblCgBfeAdp1rgS4cCdBM0mmToNNWjo8bLbTHahiUZQsQaIC0nVbVhK5Tq Fiw6fRw+aXvI5j2wucfFwZj4= X-Received: by 127.0.0.2 with SMTP id BkcCYY7687511xoIgKnaaS0F; Thu, 17 Aug 2023 04:27:35 -0700 X-Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mx.groups.io with SMTP id smtpd.web10.184965.1692271654190048745 for ; Thu, 17 Aug 2023 04:27:34 -0700 X-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4fe1b00fce2so11502655e87.3 for ; Thu, 17 Aug 2023 04:27:33 -0700 (PDT) X-Gm-Message-State: qQNxu5V0VzkyBbUGG7YifBDvx7686176AA= X-Google-Smtp-Source: AGHT+IHyF4lOuyqDtwwLMPAQBGg0M5MtAJGp7hZ/9P8SSe3a7rWjfBydn6AVe1kNPkfscwkt5yHfxg== X-Received: by 2002:a05:6512:3137:b0:4ff:8863:be01 with SMTP id p23-20020a056512313700b004ff8863be01mr3807109lfd.8.1692271651975; Thu, 17 Aug 2023 04:27:31 -0700 (PDT) X-Received: from [192.168.200.206] (83.11.3.31.ipv4.supernova.orange.pl. [83.11.3.31]) by smtp.gmail.com with ESMTPSA id l3-20020ac24a83000000b004ff8e79bc75sm833016lfp.285.2023.08.17.04.27.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Aug 2023 04:27:31 -0700 (PDT) Message-ID: Date: Thu, 17 Aug 2023 13:27:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 3/3] Platform/SbsaQemu: handle systems without GIC ITS To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Graeme Gregory References: <20230719120842.1120001-1-marcin.juszkiewicz@linaro.org> <17734388FD0352A4.32574@groups.io> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: <17734388FD0352A4.32574@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=un9WwO9g; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 19.07.2023 o 14:08, Marcin Juszkiewicz via groups.io pisze: > If firmware is used with QEMU 8.0 or older then there will be no GIC ITS > support. > > In such case we would not add information about it into MCFG and there > will be no IORT table. > > Signed-off-by: Marcin Juszkiewicz > --- > .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 - > .../SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 1 + > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 218 +++++++++++++++++- > Silicon/Qemu/SbsaQemu/AcpiTables/Iort.aslc | 135 ----------- > 4 files changed, 208 insertions(+), 147 deletions(-) > delete mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Iort.aslc > diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > + // Initialize IORT ACPI Header > + EFI_ACPI_6_0_IO_REMAPPING_TABLE Header = { > + SBSAQEMU_ACPI_HEADER(EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE, > + SBSA_IO_REMAPPING_STRUCTURE, > + EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00), > + 1, This should be 3 (ITS, SMMU, RC). I had code which bumped it to 3 and then removed it without checking. Will send v4. > + sizeof(EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset > + 0 }; -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107828): https://edk2.groups.io/g/devel/message/107828 Mute This Topic: https://groups.io/mt/100798349/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-