From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E462FAC190E for ; Tue, 3 Oct 2023 15:53:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fmEzEzaR0oMSA/LsIoB+xF9Sr+QDD5XkDBYDflpLxeU=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696348421; v=1; b=hPkF1DdNmB6DsbMDpByTYjWyL/yjuMgn5m/6QCuQ87ipNHNEG2J08mSXxQ1QvHO2dJfaNdX8 RY9a5t7JSAAHUjs0V8hxr85be17ELXkDQOqwzxo/NcnW3gmbjT81eDNyvlbOzMFV8GCpAtiA6kN n7lrAXByDyPLWLDx+oPn4elM= X-Received: by 127.0.0.2 with SMTP id CqYNYY7687511xopyCVNW2CP; Tue, 03 Oct 2023 08:53:41 -0700 X-Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.groups.io with SMTP id smtpd.web10.89378.1696269501381674344 for ; Mon, 02 Oct 2023 10:58:21 -0700 X-Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4054f790190so407515e9.2 for ; Mon, 02 Oct 2023 10:58:21 -0700 (PDT) X-Gm-Message-State: 0dvk2Pz8JhqdKdaCB0pFJ0Ezx7686176AA= X-Google-Smtp-Source: AGHT+IEkGbdYwc5m9f/XWDPcu5o3jPeVkds9QF4pt1UBKCvC1UPj4X5uq9ImT0CefpROUbz4eQqfNw== X-Received: by 2002:adf:f546:0:b0:317:634c:46e9 with SMTP id j6-20020adff546000000b00317634c46e9mr10816953wrp.43.1696269499661; Mon, 02 Oct 2023 10:58:19 -0700 (PDT) X-Received: from [192.168.69.115] (176-131-222-246.abo.bbox.fr. [176.131.222.246]) by smtp.gmail.com with ESMTPSA id a6-20020a05600c224600b00403b63e87f2sm7772326wmm.32.2023.10.02.10.58.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 10:58:19 -0700 (PDT) Message-ID: Date: Mon, 2 Oct 2023 19:58:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v2 5/5] MdePkg/BaseLib: ensure ARM LongJump never returns 0 To: Leif Lindholm , devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar References: <20230926171523.368706-1-quic_llindhol@quicinc.com> <20230926171523.368706-6-quic_llindhol@quicinc.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230926171523.368706-6-quic_llindhol@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hPkF1DdN; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 26/9/23 19:15, Leif Lindholm wrote: > The ARM implementation of of InternalLongJump always returned the value > Value - but it is not supposed to ever return 0. Add the test to prevent > that, and return 1 if Value is 0 - as is already present in AArch64. > > Signed-off-by: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > --- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 ++ > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 ++ Reviewed-by: Philippe Mathieu-Daudé -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109289): https://edk2.groups.io/g/devel/message/109289 Mute This Topic: https://groups.io/mt/101600811/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-