From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, vladimir.olovyannikov@broadcom.com
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Zhichao Gao <zhichao.gao@intel.com>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
Ray Ni <ray.ni@intel.com>, Liming Gao <liming.gao@intel.com>,
Nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
Date: Wed, 15 Jul 2020 14:58:48 +0200 [thread overview]
Message-ID: <fae81c05-4e0f-915a-90aa-15631ecb150d@redhat.com> (raw)
In-Reply-To: <17bab469-76af-0ffc-b99c-962f4eb20010@redhat.com>
On 07/15/20 14:55, Laszlo Ersek wrote:
> On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote:
>> Introduce an http client utilizing EDK2 HTTP protocol, to
>> allow fast image downloading from http/https servers.
>> HTTP download speed is usually faster than tftp.
>> The client is based on the same approach as tftp dynamic command, and
>> uses the same UEFI Shell command line parameters. This makes it easy
>> integrating http into existing UEFI Shell scripts.
>> Note that to enable HTTP download, feature Pcd
>> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must
>> be set to TRUE.
>>
>> Signed-off-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>
>> Tested-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>> Cc: Zhichao Gao <zhichao.gao@intel.com>
>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Nd <nd@arm.com>
>> ---
>> .../DynamicCommand/HttpDynamicCommand/Http.c | 1700 +++++++++++++++++
>> .../DynamicCommand/HttpDynamicCommand/Http.h | 84 +
>> .../HttpDynamicCommand/Http.uni | 113 ++
>> .../HttpDynamicCommand/HttpApp.c | 53 +
>> .../HttpDynamicCommand/HttpApp.inf | 58 +
>> .../HttpDynamicCommand/HttpDynamicCommand.c | 134 ++
>> .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 +
>> ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 +
>> ShellPkg/ShellPkg.dec | 1 +
>> ShellPkg/ShellPkg.dsc | 5 +
>> 10 files changed, 2216 insertions(+)
>> create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c
>> create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h
>> create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni
>> create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c
>> create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf
>> create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.c
>> create mode 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
>
> This feature sounds very attractive for virtualization too.
>
> I suggest filing a BZ for collecting the various versions of the patch
> (or patch series) in a common spot. (Based on the size of the patch, I
> assume there could be multiple versions.)
Sorry, I didn't look carefully enough at the subject -- I see we're already at v3. In that case, the BZ should please reference all three versions of the patch (thus far):
* version 1:
[edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
https://edk2.groups.io/g/devel/message/53483
http://mid.mail-archive.com/20200125005718.8931-1-vladimir.olovyannikov@broadcom.com
* version 2:
[edk2-devel] [PATCH v2 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
https://edk2.groups.io/g/devel/message/59160
http://mid.mail-archive.com/20200511180310.30964-1-vladimir.olovyannikov@broadcom.com
* version 3 (this version):
[edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
https://edk2.groups.io/g/devel/message/62452
http://mid.mail-archive.com/20200713183137.9825-1-vladimir.olovyannikov@broadcom.com
Thanks!
Laszlo
next prev parent reply other threads:[~2020-07-15 12:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 18:31 [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand Vladimir Olovyannikov
2020-07-15 12:55 ` [edk2-devel] " Laszlo Ersek
2020-07-15 12:58 ` Laszlo Ersek [this message]
2020-07-15 17:09 ` Vladimir Olovyannikov
2020-07-16 12:19 ` Laszlo Ersek
2020-07-16 15:26 ` Samer El-Haj-Mahmoud
2020-07-16 17:14 ` Vladimir Olovyannikov
2020-07-16 17:07 ` Vladimir Olovyannikov
2020-07-22 19:37 ` Laszlo Ersek
2020-07-22 19:40 ` Laszlo Ersek
2020-07-23 13:30 ` Laszlo Ersek
2020-07-23 17:20 ` Vladimir Olovyannikov
2020-07-23 14:54 ` Laszlo Ersek
2020-07-23 15:02 ` Laszlo Ersek
2020-07-23 17:18 ` Vladimir Olovyannikov
2020-07-24 15:09 ` Laszlo Ersek
2020-07-24 17:50 ` Vladimir Olovyannikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae81c05-4e0f-915a-90aa-15631ecb150d@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox