Re: [edk2-devel] [PATCH v2 0/4] RPi: SD/Wifi Acpi updates

["Jeremy Linton" <jeremy.linton@arm.com>]

Hi,

On 2/11/21 2:07 AM, Ard Biesheuvel via groups.io wrote:
> On Mon, 1 Feb 2021 at 23:53, Jeremy Linton <jeremy.linton@arm.com> wrote:
>>
>> The existing RPi3 acpi entries for the Arasan
>> and sdhci controllers needs updating to work
>> with the RPi4. This is done by adding a caps
>> override for the legacy Arasan controller and
>> then adding an entirely new entry for the newer
>> eMMC2 controller.
>>
>> Then we flip the default routing to make the eMMC2
>> the default for the SD card, so that the wifi can
>> start working on the Arasan.
>>
>> Additional we add a menu item to enable the SDMA/ADMA2
>> modes on the controller.
>>
>> v1->v2: Add option for user to enable/disable eMMC DMA
>>          Only enable the emmc2 table on rpi4 &
>>              !Arasan routing
>>          Move emmc2 into its own SSDT and drop
>>              second _DMA entry
>>
>> Jeremy Linton (4):
>>    Platform/RaspberryPi: Add Negative table check
>>    Platform/RaspberryPi/Acpitables: Add eMMC2 device and tweak Arasan
>>    Platform/RaspberryPi: User control of eMMC2 DMA
>>    Platform/RaspberryPi: Invert default Arasan, Emmc2 routing
>>
> 
> Hi Jeremy,
> 
> I don't see v2 2/4 in my mailbox or in the ML archive. Can you resend please?

Sorry about the delay here. I noticed this as I was doing a final pass 
on the review comments before reposing.

I'm guessing you didn't see it because because I messed up the patch 
numbering?

> 
> Also, what is the status of this work on the Linux side?

It should all be merged(ing), there was a patch in 5.11 to handle the 
sdhci-caps[-mask] fields, and the ACPI ID's patch should be getting 
merged to 5.12. The linux-firmware patch was merged a month or so ago 
too, which enables wifi. This is the last piece of the puzzle.


> 
> 
>>   Platform/RaspberryPi/AcpiTables/AcpiTables.inf     |   1 +
>>   Platform/RaspberryPi/AcpiTables/Emmc.asl           | 130 +++++++++++++++++++++
>>   Platform/RaspberryPi/AcpiTables/Sdhc.asl           |  18 ++-
>>   Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |  26 +++++
>>   .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf    |   1 +
>>   .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni |   5 +
>>   .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr |  17 +++
>>   Platform/RaspberryPi/Include/ConfigVars.h          |   8 ++
>>   Platform/RaspberryPi/RPi3/RPi3.dsc                 |   1 +
>>   Platform/RaspberryPi/RPi4/RPi4.dsc                 |   3 +-
>>   Platform/RaspberryPi/RPi4/Readme.md                |   2 +-
>>   Platform/RaspberryPi/RaspberryPi.dec               |   1 +
>>   12 files changed, 208 insertions(+), 5 deletions(-)
>>   create mode 100644 Platform/RaspberryPi/AcpiTables/Emmc.asl
>>
>> --
>> 2.13.7
>>
> 
> 
> 
> 
>