From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.104.1613517818081381863 for ; Tue, 16 Feb 2021 15:23:38 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C06F731B; Tue, 16 Feb 2021 15:23:36 -0800 (PST) Received: from [192.168.122.166] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 766263F73B; Tue, 16 Feb 2021 15:23:36 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v2 0/4] RPi: SD/Wifi Acpi updates To: devel@edk2.groups.io, ardb@kernel.org Cc: Peter Batard , Andrei Warkentin , Samer El-Haj-Mahmoud , Leif Lindholm , Ard Biesheuvel References: <20210201225343.2001835-1-jeremy.linton@arm.com> From: "Jeremy Linton" Message-ID: Date: Tue, 16 Feb 2021 17:23:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 2/11/21 2:07 AM, Ard Biesheuvel via groups.io wrote: > On Mon, 1 Feb 2021 at 23:53, Jeremy Linton wrote: >> >> The existing RPi3 acpi entries for the Arasan >> and sdhci controllers needs updating to work >> with the RPi4. This is done by adding a caps >> override for the legacy Arasan controller and >> then adding an entirely new entry for the newer >> eMMC2 controller. >> >> Then we flip the default routing to make the eMMC2 >> the default for the SD card, so that the wifi can >> start working on the Arasan. >> >> Additional we add a menu item to enable the SDMA/ADMA2 >> modes on the controller. >> >> v1->v2: Add option for user to enable/disable eMMC DMA >> Only enable the emmc2 table on rpi4 & >> !Arasan routing >> Move emmc2 into its own SSDT and drop >> second _DMA entry >> >> Jeremy Linton (4): >> Platform/RaspberryPi: Add Negative table check >> Platform/RaspberryPi/Acpitables: Add eMMC2 device and tweak Arasan >> Platform/RaspberryPi: User control of eMMC2 DMA >> Platform/RaspberryPi: Invert default Arasan, Emmc2 routing >> > > Hi Jeremy, > > I don't see v2 2/4 in my mailbox or in the ML archive. Can you resend please? Sorry about the delay here. I noticed this as I was doing a final pass on the review comments before reposing. I'm guessing you didn't see it because because I messed up the patch numbering? > > Also, what is the status of this work on the Linux side? It should all be merged(ing), there was a patch in 5.11 to handle the sdhci-caps[-mask] fields, and the ACPI ID's patch should be getting merged to 5.12. The linux-firmware patch was merged a month or so ago too, which enables wifi. This is the last piece of the puzzle. > > >> Platform/RaspberryPi/AcpiTables/AcpiTables.inf | 1 + >> Platform/RaspberryPi/AcpiTables/Emmc.asl | 130 +++++++++++++++++++++ >> Platform/RaspberryPi/AcpiTables/Sdhc.asl | 18 ++- >> Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 26 +++++ >> .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 1 + >> .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 5 + >> .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 17 +++ >> Platform/RaspberryPi/Include/ConfigVars.h | 8 ++ >> Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + >> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +- >> Platform/RaspberryPi/RPi4/Readme.md | 2 +- >> Platform/RaspberryPi/RaspberryPi.dec | 1 + >> 12 files changed, 208 insertions(+), 5 deletions(-) >> create mode 100644 Platform/RaspberryPi/AcpiTables/Emmc.asl >> >> -- >> 2.13.7 >> > > > > >