From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.73]) by mx.groups.io with SMTP id smtpd.web10.10090.1634139961316792724 for ; Wed, 13 Oct 2021 08:46:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=bWOy0mIp; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.73, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DI2mrRSzoF4oF/UNb8GbcwC0ttw3BZlKbiGZ3IVq8JMzfZFGPjTpl1cpOs9Faelf4ymthkfOP0FiULKZrh+u/N4djZAouOHU4hLQTUxe1/8dd1Q0fDTqAS+ubcV8K/vjxImF2Zjnq56aR3VhvaiVt6vYY8CinMVLq9NU5+QBJcUSLTAB4sdoLwrQa3WxheNggMh0gxUC+FpH7A1nJD8ZdIrgciMtyGipQTPuywfLVB9ktsYmsFjN6re+0H79tUGuUnAvkXL8Srpj00Vg9J7y16vdnGsfgq5W6gG3QgQq+58qAjjsjG5DAhJTlwaXX6HzCZoiy87GaeagRGbBDSaEww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BF7+oUNNbl3k/dCr9+1gEvgUxwz2rd/7jZIMueU2C4Y=; b=SxxAngGm9znqLWJOmRDMsgrXyweCkCgfcyaR/kXLtzbykKnu44LjVUelJumHKuFw2E4KrbcyUMqcbstup9WOcjZpd//LxoluvNvmylY7T2n86t5ZVrnq0VK+NI1dbfCHgd4JRz/aaK72KsMQ5QGg40xAm36FlRP5q1x3XDLgOOoOmGcr0b/mKu1nwNH9pXUQ99fUZNY8JqgO5H+7oQv41RzmZ0ltMVIs8jz4dWhz8JI9hiWsvBn4T+rlbPPL45E706CisrhmmyaES64UKmPTfdt9yjCGKgKugyx456i/3cW5FaLirPvdEAO3MEMCRY2E7FBd0SRp4TODKK6DgLQmQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BF7+oUNNbl3k/dCr9+1gEvgUxwz2rd/7jZIMueU2C4Y=; b=bWOy0mIpm01OcdQ5LEUQ7CK/H3J8OqlCGQ8rJvIYZyYQHBYRveSrsDRSgkMYdrTWymO7dLc0Ubz3bCuEI3+6Er3t8c8fpGa6wMj+mR/prj6Ne0DzFmds9D8KyTphuFeiYr2qhep+DDfKAuRRD8AyyOw+lMmqa+m8XaWaBWHyMzo= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4429.namprd12.prod.outlook.com (2603:10b6:806:73::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 15:45:59 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021 15:45:59 +0000 Cc: brijesh.singh@amd.com, Ard Biesheuvel , "Justen, Jordan L" , Gerd Hoffmann , Erdem Aktas , James Bottomley , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH V9 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm To: "Xu, Min M" , "devel@edk2.groups.io" , "thomas.lendacky@amd.com" References: <8f9762e7-bcc2-16b1-8cb3-159cd5d78979@amd.com> From: "Brijesh Singh" Message-ID: Date: Wed, 13 Oct 2021 10:45:55 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: X-ClientProxiedBy: SA9PR13CA0039.namprd13.prod.outlook.com (2603:10b6:806:22::14) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (165.204.77.11) by SA9PR13CA0039.namprd13.prod.outlook.com (2603:10b6:806:22::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend Transport; Wed, 13 Oct 2021 15:45:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8752c4f-c03b-414f-9f6a-08d98e608d98 X-MS-TrafficTypeDiagnostic: SA0PR12MB4429: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fk93BQWKxv33XA9jXWH4qj3JLJl1OnIeytvLeiJNBOUhnDKW70U1uSYcWCEV+fl4tOD8vQBSgf7qQyV9ptszyicn1TeI2LdwKDQaoMywhrSsjtvJ90HlApBAnCE4xN43V8etupcGGTqBJ4P8p6ZdvalAVG0ketLWQita09kgH0Y0ajG++AIJyv39gO36hMtsmeXBZHCLdGKVyrj/KMZVvDaF0Rw2lnHLrFcJKflhMBFjolM75hVyn0ycsdqPsbWUxS/OowDaG2bW2zDdmXK6Nl3pRyZDQ6Zn2y/wi0I4mau+/WuR6LtRid3oc33tCY+6yMF1GkGfcEVM3Kfy4Qzpqt68/LO9GlMeD0GRbRShmvB2UzUBAEV80HmEbsS8Z1gE/0x6Yd0N/cFG5Lo31ymLE5prIsD+sXbSAH6gu2+Mj+OoUmxAJUX1KTRGQxswbl+tYbrke/brgCM0eUZjjua1LgnjfzPUnRVADG7sjGCQvvgn9bEKwPkSsBhWqvVy0giU0s8+0WZSiMpJ5xl0Xx3wyPUqgcycsqjtf2WQpPsDYYAo9viw08aH2O0exhS4zSyfpJEmnRRY2MNxdKBubd3k+SkdqFXfQN/B6HEgT0xJVmf1/jkKaklfiUUUK8iovz+mBAyRbsCmdN9PRpXy4CuLYxMUxT0bj3pIgxvnR1bEauVdoFpjl7vBvHTv15TjrqS1izucXrieaSnRjeFwvZcgJ27+rIk9KfDZAIjhYMcj+EkARi3kMwi92/HpIJOw5Vd1dkmiRsg0n1kcnm9uZRhFQFnHfW1f41FqZ6RJEF1lXH5i4ewkUXje5re9MlqKlXo/728FmuTljAy/vp+PDF2rGSjppCb1Zv/08hONNICUYHVbkLST9u+tW2pzwcM+jytU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6666004)(966005)(6486002)(31696002)(186003)(36756003)(8676002)(45080400002)(508600001)(38100700002)(31686004)(44832011)(53546011)(6506007)(110136005)(26005)(4326008)(8936002)(66476007)(66946007)(6512007)(316002)(66556008)(2906002)(54906003)(956004)(2616005)(5660300002)(86362001)(6636002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHpIMUM1SXNxeFRtTlJlQWJ5MUNvTFIxU3psMlVpOUk2Q3d2cWNBWEFvalJP?= =?utf-8?B?UGlWaGY1ZThNeXFpb3ZUcTdtRE5jS0tzVFpIQ0RjWkNLUzhRM1lwT3dBSEZn?= =?utf-8?B?N0dKNmVkaXlBMUZ5bU0zUC9DUGRzNXAvVW9QM0hhUnY0NHFNb0ErSUR0cFJx?= =?utf-8?B?NHBUb2pWVjY1QmkvL3hhZHROOGl2UVdnK1dOK1ExVytmQXFPRWhGNTlPR3BX?= =?utf-8?B?ZkpzOXhQM3A1U2M3WDVPYmpvclVQQ0Q4U3lyYzBkbUJJeGhSVlNreWs3WnJh?= =?utf-8?B?TzUwZmx6ZS9MNThXTGVSM1lZVGpyTUFsN3NHSURYV1NES0wvYSt4MlNTbUh1?= =?utf-8?B?aDZ2OWpHWWE4M3ZENEZuR1Y1T0p4eHJmOFFFdCttQVNGZnhSTTU3L0tEc1hJ?= =?utf-8?B?SXJiNytZakwxempVSUtwdi8vRjVkbmNPMVpPQW92L0NBWFl0cTdkOEw3RHVQ?= =?utf-8?B?RnlJV1E3SUxLaEZsaE5KazdMVWxPdTJBYU05bi9CZ1BqQXN0QlNtQXZvbXV6?= =?utf-8?B?czNHSFVtTDhtdmZSZzlzVUdrai9OcUowZFh1bkdNd3FkYitsSmZZV294bkcr?= =?utf-8?B?Mnc4VzhjTUx1VDJBOVlhdFhraXo1eXN3a3RmaFlRM1RDdWZCdFRpbzAvRUdZ?= =?utf-8?B?S2RqZmNxcGpxOEo2eUthZVRRUVM0RlMvbCtLdTZLUnpGY0VkYUVMWWVpd25L?= =?utf-8?B?cjFDMm5NaTA2SHA2em0xS2syVW5vZ3NNMmFGOW5hR2tJdFZUN1dxRkZCdGdv?= =?utf-8?B?K1QrbnJ0bXBrZjBVUmd6dDM5aWw1enNVaTlzek41VXAwN2JibTUvNmRMSVgr?= =?utf-8?B?VGY1aEZHOG1URHZoeEJESW5jbXVxTmpuSWE3ejQveVRISURuNkowZ0liZEli?= =?utf-8?B?aXJ4Q2pQellGUTFqWDN1SkdmMGl0UnpGM0NDY1RkSWlrVkRLQnZpMk1IaDE1?= =?utf-8?B?ZCtuYWUwQ2d3RTJLc2ZBaUJ5eTZjaDVPd0NqYXgyd25pRmU3anBWUkZYQkdZ?= =?utf-8?B?ejJPUWMrd29UOGhSMng0bURKc3VDcWFIc3k4VHZnbjhYQm1PWlVzQnE4R2hB?= =?utf-8?B?TkFndXJlZG5wQUlhK2RaN1lFRVpyd2Z1cldBemZpMTB0czBDTE5razR3cWFU?= =?utf-8?B?L3dkRUxidW96ZTVpcGVzNWUwZTFZazhQdXVKRzd2VTdNY0Fpa0hwRXRNcEJy?= =?utf-8?B?UUM5U3VXNFd5TkcwVTNZZjE2aThKY2R4ZVA2OCtlMVJzeVF4a2VqM1dQbHhH?= =?utf-8?B?VUJqM08rNkF4V1VxRThsSFlEVEFDLzRzRXYxS05QSWdtR3hOcGRFOWN1V1BH?= =?utf-8?B?UUdpaUJyaVBaeXlub1dDeEF3SmRIRE5TcmVON3IzRnNFYkZKLzRBVGJ4Ulo4?= =?utf-8?B?eU54M0FreVhoa0VKdW9sME9MMVFUQzI1YmwvYllVMFJyd2l4QXVOVmpFQk9Q?= =?utf-8?B?Z0twQnF2WVlVNHVLSW1LQkRrZTN2V0gvd3k3cUptOS9vQVIvb1NGWEZMd3FT?= =?utf-8?B?VlRYdDVLT0I2dHliQW9OSjJyZDZ2ZTZKTjFIa2NQMTZrT2syWWNERHJFd2hn?= =?utf-8?B?YWgwUzRlRnFTSlc3YzRCMjhZVlB1aDJCRHpIWVpGRzFQMlZDaWFOUm1WS1Ns?= =?utf-8?B?dlpyUTlRWjR3UGlvdFkwVE55bXZLcTF6aUFGVWhUYlNralBXWVRKRHZ2bjhQ?= =?utf-8?B?MmtJNUo0TlF0bTFVL0FIOStCTUxKQW5wdFhwMHNIaFlPTHRDTXJxWDI4cCts?= =?utf-8?Q?oKKJkCsOQXls6RCDutUM030VDTjpwjM7LXKdgKs?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8752c4f-c03b-414f-9f6a-08d98e608d98 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 15:45:59.4989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DtrVCIMpObXJ00nqeuDQEJs1mIq7SR7kjKFa8z0MdVm3TXBEVd64TExcMf9fZEOQ/Tv/+XgmJlrqdsXwgBvnhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4429 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 10/12/21 5:58 PM, Xu, Min M wrote: > On October 12, 2021 9:23 PM, Lendacky Thomas wrote: >> On 10/11/21 9:37 PM, Min Xu wrote: >>> diff --git a/OvmfPkg/ResetVector/Main.asm >>> b/OvmfPkg/ResetVector/Main.asm index ae90a148fce7..a501fbe880f2 >> 100644 >>> --- a/OvmfPkg/ResetVector/Main.asm >>> +++ b/OvmfPkg/ResetVector/Main.asm >>> @@ -36,6 +36,14 @@ Main16: >>> >>> BITS 32 >>> >>> +%ifdef ARCH_X64 >> A regular SEV guest can be built in the hybrid IA32 and X64 configuratio= n, so this >> will break existing SEV firmwares built in that manner. Only SEV-ES and = SEV-SNP >> require the full X64 confguration. >> > WORK_AREA_GUEST_TYPE is defined in https://nam11.safelinks.protection.out= look.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster= %2FOvmfPkg%2FResetVector%2FResetVector.nasmb%23L75&data=3D04%7C01%7Cbri= jesh.singh%40amd.com%7C10fd025cc9324fe76a0808d98de49924%7C3dd8961fe4884e608= e11a82d994e183d%7C0%7C0%7C637696835234415070%7CUnknown%7CTWFpbGZsb3d8eyJWIj= oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sda= ta=3Dy7cujCXYfhvORki5aNbLF9Eq3BBrcfHykvlWFcYAciI%3D&reserved=3D0 and pr= eviously it was cleared in https://nam11.safelinks.protection.outlook.com/?= url=3Dhttps%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FOvmfPkg= %2FResetVector%2FIa32%2FPageTables64.asm%23L47&data=3D04%7C01%7Cbrijesh= .singh%40amd.com%7C10fd025cc9324fe76a0808d98de49924%7C3dd8961fe4884e608e11a= 82d994e183d%7C0%7C0%7C637696835234425063%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC= 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata= =3DAQLw4AJ%2FFxoGjfT6arKFSTvkCshRMz1v5RLZOnA8p4A%3D&reserved=3D0. These= 2 lines are both surrounded by ARCH_X64. > So in this commit, the clearance of WORK_AREA_GUEST_TYPE in Main.asm is s= urrounded by ARCH_X64 too. > Brijesh, what's your comments on this change? Good point Tom. The WORK_AREA_GUEST_TYPE define should be moved outside the ARCH_X86. I missed it mainly because we renamed the ESWorkArea to Generic workarea but EsWorkArea was defined in ARCH_X86 only. Min, I can send a patch to move define outside the ARCH_X64 and then you can align the TDX code accordingly. > Thanks! > Min