Re: [PATCH v2 5/6] ArmVirtPkg/QemuFwCfgLib: rebase lib instance to updated lib class header

[Laszlo Ersek <lersek@redhat.com>]

On 12/05/16 11:30, Leif Lindholm wrote:
> On Fri, Dec 02, 2016 at 09:20:58PM +0100, Laszlo Ersek wrote:
>> Put the FW_CFG_F_DMA constant, introduced in the last patch, to use.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Thanks Leif!
Laszlo

>> ---
>>
>> Notes:
>>     v2:
>>     - no need to include another header [Leif]
>>     - scope is smaller now (only FW_CFG_F_DMA)
>>
>>  ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c b/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
>> index 6033a2a14c42..1b19893709fc 100644
>> --- a/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
>> +++ b/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
>> @@ -163,7 +163,7 @@ QemuFwCfgInitialize (
>>  
>>          QemuFwCfgSelectItem (QemuFwCfgItemInterfaceVersion);
>>          Features = QemuFwCfgRead32 ();
>> -        if ((Features & BIT1) != 0) {
>> +        if ((Features & FW_CFG_F_DMA) != 0) {
>>            mFwCfgDmaAddress = FwCfgDmaAddress;
>>            InternalQemuFwCfgReadBytes = DmaReadBytes;
>>          }
>> -- 
>> 2.9.2
>>
>>