From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 6C45581FE8
 for <edk2-devel@ml01.01.org>; Mon,  5 Dec 2016 02:51:18 -0800 (PST)
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
 (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id DADF631B322;
 Mon,  5 Dec 2016 10:51:17 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-85.phx2.redhat.com
 [10.3.116.85])
 by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 uB5ApGVj011152; Mon, 5 Dec 2016 05:51:16 -0500
To: Leif Lindholm <leif.lindholm@linaro.org>
References: <20161202202059.5061-1-lersek@redhat.com>
 <20161202202059.5061-6-lersek@redhat.com>
 <20161205103046.GH27069@bivouac.eciton.net>
Cc: edk2-devel-01 <edk2-devel@ml01.01.org>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <fb1f4ecf-7d2d-4c8b-8532-fbcb6c5faacb@redhat.com>
Date: Mon, 5 Dec 2016 11:51:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20161205103046.GH27069@bivouac.eciton.net>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.29]); Mon, 05 Dec 2016 10:51:17 +0000 (UTC)
Subject: Re: [PATCH v2 5/6] ArmVirtPkg/QemuFwCfgLib: rebase lib instance to updated lib class header
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Dec 2016 10:51:18 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 12/05/16 11:30, Leif Lindholm wrote:
> On Fri, Dec 02, 2016 at 09:20:58PM +0100, Laszlo Ersek wrote:
>> Put the FW_CFG_F_DMA constant, introduced in the last patch, to use.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Thanks Leif!
Laszlo

>> ---
>>
>> Notes:
>>     v2:
>>     - no need to include another header [Leif]
>>     - scope is smaller now (only FW_CFG_F_DMA)
>>
>>  ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c b/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
>> index 6033a2a14c42..1b19893709fc 100644
>> --- a/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
>> +++ b/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c
>> @@ -163,7 +163,7 @@ QemuFwCfgInitialize (
>>  
>>          QemuFwCfgSelectItem (QemuFwCfgItemInterfaceVersion);
>>          Features = QemuFwCfgRead32 ();
>> -        if ((Features & BIT1) != 0) {
>> +        if ((Features & FW_CFG_F_DMA) != 0) {
>>            mFwCfgDmaAddress = FwCfgDmaAddress;
>>            InternalQemuFwCfgReadBytes = DmaReadBytes;
>>          }
>> -- 
>> 2.9.2
>>
>>