Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PlatformCI: stick with "ubuntu-18.04" for now

["Laszlo Ersek" <lersek@redhat.com>]

On 12/21/20 04:19, Bob Feng wrote:
> "vm_image: 'ubuntu-latest'" now refers to Ubuntu Focal (20.04LTS), not
> Ubuntu Bionic (18.04LTS), according to
> <https://github.com/actions/virtual-environments/issues/1816>.
> 
> In Focal, the "qemu" package is a dummy package with no dependencies, and
> so the actual emulators are not pulled in. Compare:
> 
>   https://packages.ubuntu.com/bionic/qemu
>   https://packages.ubuntu.com/focal/qemu
> 
> This causes CI runs to fail.
> 
> It would be best to switch to the "qemu-system" package name, which
> continues to depend on the emulators:
> 
>   https://packages.ubuntu.com/bionic/qemu-system
>   https://packages.ubuntu.com/focal/qemu-system
> 
> However, while that package does make the emulators available, the
> emulators crash. So for now, stick with the previous Ubuntu environment,
> which continues to be supported, per
> <https://github.com/actions/virtual-environments/issues/1816>.
> 
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 0e5f4d9961e3..17d62bb69ec5 100644
> --- a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -15,11 +15,11 @@ pr:
>    - master
>  jobs:
>    - job: Platform_CI
>      variables:
>        package: 'EmulatorPkg'
> -      vm_image: 'ubuntu-latest'
> +      vm_image: 'ubuntu-18.04'
>        should_run: false
>        run_flags: "MAKE_STARTUP_NSH=TRUE"
>  
>      #Use matrix to speed up the build process
>      strategy:
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

I'm going to merge this at once, because it's blocking other pull
requests.

I can see that this patch reuses the commit message from my commits
90683caedf1e ("ArmVirtPkg/PlatformCI: stick with "ubuntu-18.04" for
now", 2020-12-18) and c487970ac89d ("OvmfPkg/PlatformCI: stick with
"ubuntu-18.04" for now", 2020-12-18).

When I wrote those patches, I obviously did *not* miss EmulatorPkg.
However, EmulatorPkg does not use QEMU in CI -- that's the reason my
series did not cover EmulatorPkg. I did not foresee any reason for
EmulatorPkg's CI tasks to fail with Ubuntu 20.04LTS.

And now that I'm actually checking such an (unexpected) failure, it's
not QEMU-related. Instead, it's a GCC issue:

https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=17230&view=logs&j=7cda4867-6a98-5508-f20e-3046bf80e19c&t=9a255493-65b4-5c45-e228-bf6eb3567b30&l=1150

> INFO - "gcc" -o /home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/Host -m32 -L/usr/X11R6/lib -Wl,--start-group,@/home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/EmulatorPkg/Unix/Host/Host/OUTPUT/static_library_files.lst,--end-group -lpthread -ldl -lXext -lX11
> INFO - /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/9/libgcc.a when searching for -lgcc
> INFO - /usr/bin/ld: cannot find -lgcc
> INFO - /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/9/libgcc.a when searching for -lgcc
> INFO - /usr/bin/ld: cannot find -lgcc
> INFO - collect2: error: ld returned 1 exit status
> INFO - make: *** [GNUmakefile:421: /home/vsts/work/1/s/Build/EmulatorIA32/DEBUG_GCC5/IA32/EmulatorPkg/Unix/Host/Host/DEBUG/Host] Error 1

Therefore, when I merge this patch, I will update the commit message to
refer to a GCC linking issue rather than to QEMU.

Thanks
Laszlo