From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.1392.1664822798187400437 for ; Mon, 03 Oct 2022 11:46:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=Jh4p+O8r; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id 2F8FA20E6F17; Mon, 3 Oct 2022 11:46:37 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2F8FA20E6F17 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1664822797; bh=hiRt66EwK99HFDj3dmLGoAlXNx6JDLtivl11EO5vAZk=; h=Date:Subject:From:To:Reply-To:References:In-Reply-To:From; b=Jh4p+O8rBOn6zQz6cwaT5aFbmD8jGHQ+PmllKlwZbcX7d52Cf0KH16H2Xw7sARhzu 3BmxxuPDe/b3j9kgJBxbysVojJPp7grsd4qk78KEvcqrmyIih5mRQAPI0CIoUto+vr LKmnXChotMfk/utP9Mwu69M+Lz/yIvIUhZYsrc2w= Message-ID: Date: Mon, 3 Oct 2022 14:46:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file From: "Michael Kubacki" To: devel@edk2.groups.io, Chasel Chiu , Nate DeSimone , Star Zeng Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <20220915185508.997-1-mikuback@linux.microsoft.com> <17151D8FB6D820D9.18791@groups.io> <5e42cc3d-c618-5ba9-ca36-6d09ec11d27f@linux.microsoft.com> <09bd843a-0517-db76-c01f-6c700150ca26@linux.microsoft.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable +Other IntelFsp2Pkg & IntelFsp2WrapperPkg maintainers to To line Please review the remaining patches in this patch series: https://edk2.groups.io/g/devel/message/93859 Thanks, Michael On 10/3/2022 10:44 AM, Michael Kubacki wrote: > Another reminder. >=20 > On 9/22/2022 9:07 PM, Michael Kubacki wrote: >> Review reminder >> >> On 9/15/2022 3:41 PM, Michael Kubacki wrote: >>> Hi Chasel, >>> >>> Your CI YAML file feedback in v1 is addressed now in v2. >>> >>> Can you please provide your review on this patch and [PATCH v2 5/6]? >>> >>> Note that I updated the commit message for this patch to remove the=20 >>> info about the build being broken since that was recently fixed. That= =20 >>> update is in the branch: >>> >>> https://github.com/makubacki/edk2/commit/c37e6dfa482ed075cd4ab6712e6d= 17b3cf17786a=20 >>> >>> >>> With these reviews, the series will be covered. >>> >>> Thanks, >>> Michael >>> >>> On 9/15/2022 2:55 PM, Michael Kubacki wrote: >>>> From: Michael Kubacki >>>> >>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048 >>>> >>>> Adds IntelFsp2Pkg to the list of supported build packages for edk2 >>>> CI and defines an initial set of CI configuration options. >>>> >>>> The compiler plugin is disabled as the package currently does not >>>> build due to some changes in the FSP 2.4 interface addition. >>>> >>>> Specifically, in commit df25a54 "Fsp24SecCore.inf" files were >>>> added to IntelFspPkg.dsc but the actual files were not added. >>>> >>>> Simply removing these files from the DSC exposes a linker failure. >>>> >>>> Recommendation: >>>> >>>> 1. Enable package CI (accept this change) >>>> 2. Add IntelFsp2Pkg.dsc to the "CompilerPlugin" "DscPath" in >>>> =C2=A0=C2=A0=C2=A0 IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml to enable compi= lation >>>> 3. Verify compilation and all currently enabled package CI checks >>>> =C2=A0=C2=A0=C2=A0 pass >>>> 4. Check-in fixes in (3) with change in (2) >>>> >>>> Cc: Chasel Chiu >>>> Cc: Nate DeSimone >>>> Cc: Star Zeng >>>> Signed-off-by: Michael Kubacki >>>> --- >>>> =C2=A0 .pytool/CISettings.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 + >>>> =C2=A0 IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml | 90 ++++++++++++++++++++ >>>> =C2=A0 2 files changed, 91 insertions(+) >>>> >>>> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py >>>> index cf9e0d77b19b..0205c26a58f8 100644 >>>> --- a/.pytool/CISettings.py >>>> +++ b/.pytool/CISettings.py >>>> @@ -54,6 +54,7 @@ class Settings(CiBuildSettingsManager,=20 >>>> UpdateSettingsManager, SetupSettingsManag >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ArmVirtPkg", >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DynamicTablesPkg", >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "EmulatorPkg", >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 "IntelFsp2Pkg", >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "MdePkg", >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "MdeModulePkg", >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "NetworkPkg", >>>> diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml=20 >>>> b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml >>>> new file mode 100644 >>>> index 000000000000..9ce401b20164 >>>> --- /dev/null >>>> +++ b/IntelFsp2Pkg/IntelFsp2Pkg.ci.yaml >>>> @@ -0,0 +1,90 @@ >>>> +## @file >>>> +# Core CI configuration for IntelFsp2Pkg >>>> +# >>>> +# Copyright (c) Microsoft Corporation >>>> +# >>>> +# SPDX-License-Identifier: BSD-2-Clause-Patent >>>> +## >>>> +{ >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/LicenseCheck >>>> +=C2=A0=C2=A0=C2=A0 "LicenseCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFiles": [] >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 "EccCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ## Exception sample look= s like below: >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ## "ExceptionList": [ >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ##=C2=A0=C2=A0=C2=A0=C2=A0= "", "" >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ## ] >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ExceptionList": [ >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ## Both file path and di= rectory path are accepted. >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFiles": [] >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/CompilerPlugin >>>> +=C2=A0=C2=A0=C2=A0 "CompilerPlugin": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DscPath": "IntelFsp2Pkg= .dsc" >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/HostUnitTestCo= mpilerPlugin >>>> +=C2=A0=C2=A0=C2=A0 "HostUnitTestCompilerPlugin": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DscPath": "" # Don't su= pport this test >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/CharEncodingCh= eck >>>> +=C2=A0=C2=A0=C2=A0 "CharEncodingCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFiles": [] >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/DependencyChec= k >>>> +=C2=A0=C2=A0=C2=A0 "DependencyCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDependencies"= : [ >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IntelFsp2Pk= g/IntelFsp2Pkg.dec", >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "MdeModulePk= g/MdeModulePkg.dec", >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "MdePkg/MdeP= kg.dec", >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "UefiCpuPkg/= UefiCpuPkg.dec" >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # For host based unit te= sts >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDependencies-= HOST_APPLICATION":[ >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "UnitTestFra= meworkPkg/UnitTestFrameworkPkg.dec" >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # For UEFI shell based a= pps >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDependencies-= UEFI_APPLICATION":[], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreInf": [] >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/DscCompleteChe= ck >>>> +=C2=A0=C2=A0=C2=A0 "DscCompleteCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreInf": [""], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DscPath": "IntelFsp2Pkg= .dsc" >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/HostUnitTestDs= cCompleteCheck >>>> +=C2=A0=C2=A0=C2=A0 "HostUnitTestDscCompleteCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreInf": [""], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DscPath": "" # Don't su= pport this test >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/GuidCheck >>>> +=C2=A0=C2=A0=C2=A0 "GuidCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreGuidName": [], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreGuidValue": [], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFoldersAndFiles":= [], >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreDuplicates": [], >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/LibraryClassCh= eck >>>> +=C2=A0=C2=A0=C2=A0 "LibraryClassCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreHeaderFile": [] >>>> +=C2=A0=C2=A0=C2=A0 }, >>>> + >>>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/SpellCheck >>>> +=C2=A0=C2=A0=C2=A0 "SpellCheck": { >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AuditOnly": True,=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # Fails right now = with over=20 >>>> 270 errors >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFiles": [],=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # use gitignore sy= ntax to=20 >>>> ignore errors in matching files >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ExtendWords": [],=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # words to extend = to the=20 >>>> dictionary for this package >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreStandardPaths": [= ],=C2=A0=C2=A0 # Standard Plugin defined=20 >>>> paths that should be ignore >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AdditionalIncludePaths"= : [] # Additional paths to spell=20 >>>> check (wildcards supported) >>>> +=C2=A0=C2=A0=C2=A0 } >>>> +}