From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.80]) by mx.groups.io with SMTP id smtpd.web11.8759.1633351619083774653 for ; Mon, 04 Oct 2021 05:47:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=no0bhc0+; spf=pass (domain: arm.com, ip: 40.107.22.80, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oDYKNc1c6+8ZHEqXSIm1ve9PZNAHTm38FYByZ7tA6Uo=; b=no0bhc0+Bm9VL9BapSiHGsXNFoOhLDFrI0zJERXyvUDLlYrYPdfuS0DmDiHEJcDg63mYALDx5TIBll1IVXHRTQtJWOaXFWgwSdYN/jH9rTDvDHPQVrolrVyGr77tm1niuit08XLIIqYavQssx6Kb4d4yiaDBp2o+cJNTq2FGMjw= Received: from DB9PR02CA0020.eurprd02.prod.outlook.com (2603:10a6:10:1d9::25) by AM6PR08MB3254.eurprd08.prod.outlook.com (2603:10a6:209:4d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Mon, 4 Oct 2021 12:46:51 +0000 Received: from DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::70) by DB9PR02CA0020.outlook.office365.com (2603:10a6:10:1d9::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend Transport; Mon, 4 Oct 2021 12:46:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.33.187.114) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.33.187.114 as permitted sender) receiver=protection.outlook.com; client-ip=63.33.187.114; helo=64aa7808-outbound-2.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-2.mta.getcheckrecipient.com (63.33.187.114) by DB5EUR03FT026.mail.protection.outlook.com (10.152.20.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Mon, 4 Oct 2021 12:46:49 +0000 Received: ("Tessian outbound ac52c8afb262:v103"); Mon, 04 Oct 2021 12:46:49 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 10ed2bbe617fa6d4 X-CR-MTA-TID: 64aa7808 Received: from af90cc35f6b8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FCD314A9-85D6-4450-B15C-A57CB9C6E92C.1; Mon, 04 Oct 2021 12:46:13 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id af90cc35f6b8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Oct 2021 12:46:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JEon0+f4MtT8cWp47qmSvbZoDHoDB4tHdvkO1wbuvdqi4ETQv2Y2wWuG5E9rU7Jg0+i+8Q5XKzfYZfoORMGzrMzrFZGLf2bo8lCrhPnTzUKi7cQSrOcJbb2Ry9/c8b6TSTQMGZ0n32VHvBDuC04fv/uaydRm4EfTddeBOzv7lHJiuU6/zOPkf3JUGJhvjAyZEbNdYlJDS08KheMRakMLLr0aSZ3ZYUP2QFca0Zjoda0OTeK9CB0ODypxd3iYRnKwfZweG95ny+yUe1tIVCvu135l/wOMZqVevzwU1rtGQJP46AQM+vGZkMSAl0E5noamw8nQyfFGUGWiob+r3H5y2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oDYKNc1c6+8ZHEqXSIm1ve9PZNAHTm38FYByZ7tA6Uo=; b=HgiOsRv9xMPST82d5VgGdNY2KIBNyNvSYs520LmSxyuSbaRI7WGRVfe87P9GhARBpP46kiVHiUFrTljCDCSmqTuYbuyTjg6q7fLd1wcUNQbipACz3bfoEobmYrQWcLsAkSUiA6/OfEa5I7pdlT0CYb7pYwQgVnS3pizdLxBzaJGvH/cx+W1qsyk0R1BtjNhc4s0W4juceJrefvFAcyFOm6UF4siDq6Y/rHQH6+PCrKzZgoJgeCCWqcIDcLCr072rPaORRWyW3ukYS3FPDwdX5EdyCnDLwN50X2byHDM7CR5tz1FsjVv2Q0u9DuFiKdzYl/hmEyPjEbOEE1yloENwZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oDYKNc1c6+8ZHEqXSIm1ve9PZNAHTm38FYByZ7tA6Uo=; b=no0bhc0+Bm9VL9BapSiHGsXNFoOhLDFrI0zJERXyvUDLlYrYPdfuS0DmDiHEJcDg63mYALDx5TIBll1IVXHRTQtJWOaXFWgwSdYN/jH9rTDvDHPQVrolrVyGr77tm1niuit08XLIIqYavQssx6Kb4d4yiaDBp2o+cJNTq2FGMjw= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4689.eurprd08.prod.outlook.com (2603:10a6:20b:c3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Mon, 4 Oct 2021 12:46:12 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 12:46:12 +0000 Subject: Re: [edk2-platforms][PATCH v3 4/5] Platform/Sgi: Define values for ACPI table header To: Omkar Anand Kulkarni , devel@edk2.groups.io Cc: Ard Biesheuvel , nd References: <20210824060027.27246-1-omkar.kulkarni@arm.com> <20210824060027.27246-5-omkar.kulkarni@arm.com> From: "Sami Mujawar" Message-ID: Date: Mon, 4 Oct 2021 13:46:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210824060027.27246-5-omkar.kulkarni@arm.com> X-ClientProxiedBy: LO2P265CA0202.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::22) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0202.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend Transport; Mon, 4 Oct 2021 12:46:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fac89460-58ca-4d2a-ba24-08d987350892 X-MS-TrafficTypeDiagnostic: AM6PR08MB4689:|AM6PR08MB3254: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:5236;OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MV9Slbw3rRWdIrYeI7b8/c3yh2wwG9au12ffFO7PzjeBhUfYPi87LP3QRZWqk3EAAPVZjUxWYF5mOgDh24xUnDZigqvsMA7xzHTuC9caRSv4nj1P2QSUFTH3+AkpGjkzbt7femMhul9hzPofMATpXI6FoQMzzhVZ4eb6tUQCuUCs2rGk+ThGXDTezTxaCxYmkwCk6gVOP4ja4wT4c1VNqOtYtWM18g2ee+j2PwEnUdGwGcxXhbKSoXbgkxTWOMt46OHncM9fQjIpZP6eP06D//W1mJyCCRAnaP+n4qlV5cLyERMFb6faWIS010vHxj1wrQetwuxCQuF2XmOuIf/Xph52bP9Pf6E6sbAdH5QLmt36wWOWwMnG5GFR4u5Au2Dplyri0+1P5oKnDPAtvIws+oRIb42lLrifFzAm1RukhbbUqaM1KxN0X6u6Wp1p2++TDi/fjxp4KCRFcU/YokfnKOXSpbgaKsElUiDFT91fk0taexjipyzGWhzRhiNvKvW+GOE/Vn3LntDv5pGQjNNuyXovoO8PBl6+6Zu40g3dsOOwPsCQpTqEtD8vmXVfCZdrEom+hN99XlMdXwSHbKnZ5zG9VrJHoHzMLlNu6PH1nxw1hMTvWU+z6WBI1bq64o98r3xF9EGh8AGmvRvktvkRkYcuNfWeHRAA3Oo81969DxwwNvKYcQZt0lD7cDTbQXySu8Y0E9PGOkqr+mGDU13ipSAN9TZV2L3bLWHp/ADLFbrsCMzhAxQFDnxAnI4vIJIw X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38350700002)(38100700002)(508600001)(16576012)(8936002)(54906003)(31686004)(86362001)(5660300002)(31696002)(6486002)(8676002)(2906002)(316002)(44832011)(186003)(52116002)(26005)(66946007)(66556008)(66476007)(36756003)(4326008)(956004)(53546011)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4689 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: aac4f343-ca8c-4414-f071-08d98734f204 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8LDpD3/8WiYQuXvGL7VqaWW4J1i6R0dD5i65ZyZrZCd37lA7nNCpM8mi0BaWURumk0U3jd0JAohplqJJYncexzhTncAjHbnD852/ozC9rE63Va0/ROfi4SpabBrSpAE/KTWPbO6Rqaexzau3/Nic7BsxDdZy2NM+ArNjCC118Gk9b1nwx20WhTITnxQi8iSyVExURiiQmQIgZe/qrxMITVDPEcdQtc6XqQAjy6bAgScX0DlKEKagmNDcvX6M4+mBzBCqnfQdElTIeRKUczDs4LE7iF6ru9jZjMVkLazNAdDDhKjxWsBFRgZtdZ3VMgdNewOuXXFVlqv07yMalOhSvSHSC9UgDlQtrNNNWB60mkJKOeiGiJazSWxS6eMs5u1rMJjq92jsBVFW1QSH7eUjrSQNTrrhHk5eOt0Vk+PEAZYPKeg8tOJa97w0qtStAQMV063OqMLddoKZGQr8oQOfJTZTBRiTsktSevSYTWIkIylEHzh56dpbmbECKP1F9MjMOyHm2Nd9aJOPXbQogyzSBbhEWzECdVoAhb/jb1w+hpk6/74D0eT3/pGjaVhcXXXKCuk+iwv/Lq4JceaZ8HmaVZAB43RbyC1kYnDnvoWrw2pf+VYP26VyElZp3UvPMmmpcpBctCnzROzkbwAZEVU6p0eyO1loqzWI7DfG6p36D5AcadyQoKfLNI068D3e2z+gboTs6OlemVBx2aHaoidagIsl3ARW1SklfDu6zSs2cfI= X-Forefront-Antispam-Report: CIP:63.33.187.114;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-2.mta.getcheckrecipient.com;PTR:ec2-63-33-187-114.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(508600001)(54906003)(47076005)(4326008)(70206006)(316002)(26005)(336012)(81166007)(186003)(356005)(16576012)(2906002)(2616005)(956004)(53546011)(70586007)(5660300002)(8676002)(31696002)(82310400003)(8936002)(6486002)(36756003)(36860700001)(31686004)(44832011)(86362001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 12:46:49.6425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fac89460-58ca-4d2a-ba24-08d987350892 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.33.187.114];Helo=[64aa7808-outbound-2.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3254 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Omkar, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/08/2021 07:00 AM, Omkar Anand Kulkarni wrote: > For ACPI tables that are generated dynamically, define the ACPI table > header values that have to be used to build the table header. > > Co-authored-by: Thomas Abraham > Signed-off-by: Omkar Anand Kulkarni > --- > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > index 5307280ef9a3..102d7926bde1 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > @@ -221,6 +221,13 @@ > gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferSize|0x20000 > !endif > > + # ACPI Table Header IDs > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId|"ARMLTD" > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId|0x4152464e49464552 # REFINFRA > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision|0x20200831 > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId|0x204d5241 # ARM > + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision|1 > + > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform