Re: [edk2-devel] [PATCH] OvmfPkg/QemuKernelLoaderFsDxe: drop tentative const object definition

["Bob Feng" <bob.c.feng@intel.com>]

Laszlo,

I found this is the last one issue.  I created a patch https://edk2.groups.io/g/devel/message/55708. Please review.

Thanks,
Bob

-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Sunday, March 8, 2020 5:00 PM
To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io; ard.biesheuvel@linaro.org
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/QemuKernelLoaderFsDxe: drop tentative const object definition

Hi Bob,

On 03/08/20 02:22, Feng, Bob C wrote:
> Hi Ard,
> 
> With this patch, Ovmf still build failed on windows with VS2017. The error message like below:
> 
> Building ... 
> d:\edk2maintain\edk2\MdeModulePkg\Universal\Metronome\Metronome.inf 
> [IA32]
> d:\edk2maintain\edk2\OvmfPkg\LinuxInitrdDynamicShellCommand\LinuxInitr
> dDynamicShellCommand.c(199): error C2220: warning treated as error - 
> no 'object' file generated
> d:\edk2maintain\edk2\OvmfPkg\LinuxInitrdDynamicShellCommand\LinuxInitrdDynamicShellCommand.c(199): warning C4244: '=': conversion from 'UINT64' to 'UINTN', possible loss of data
>         "C:\Program Files (x86)\Microsoft Visual 
> Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx86\x86\cl.ex
> e" 
> /Fod:\edk2maintain\edk2\Build\OvmfIa32\DEBUG_VS2017\IA32\MdeModulePkg\
> Bus\Pci\UhciDxe\UhciDxe\OUTPUT\.\ /showIncludes /nologo /arch:IA32 /c 
> /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /GL /FIAutoGen.h /EHs-c- /GR- 
> /GF /Gy /Z7 /Gw /D DISABLE_NEW_DEPRECATED_INTERFACES 
> /Id:\edk2maintain\edk2\MdeModulePkg\Bus\Pci\UhciDxe  
> /Id:\edk2maintain\edk2\Build\OvmfIa32\DEBUG_VS2017\IA32\MdeModulePkg\B
> us\Pci\UhciDxe\UhciDxe\DEBUG  /Id:\edk2maintain\edk2\MdePkg  
> /Id:\edk2maintain\edk2\MdePkg\Include  
> /Id:\edk2maintain\edk2\MdePkg\Include\Ia32  
> /Id:\edk2maintain\edk2\MdeModulePkg  
> /Id:\edk2maintain\edk2\MdeModulePkg\Include 
> d:\edk2maintain\edk2\MdeModulePkg\Bus\Pci\UhciDxe\ComponentName.c 
> d:\edk2maintain\edk2\Build\OvmfIa32\DEBUG_VS2017\IA32\MdeModulePkg\Bus
> \Pci\UhciDxe\UhciDxe\DEBUG\AutoGen.c 
> d:\edk2maintain\edk2\MdeModulePkg\Bus\Pci\UhciDxe\UhciReg.c 
> d:\edk2maintain\edk2\MdeModulePkg\Bus\Pci\UhciDxe\UhciQueue.c 
> d:\edk2maintain\edk2\MdeModulePkg\Bus\Pci\UhciDxe\Uhci.c 
> d:\edk2maintain\edk2\MdeModulePkg\Bus\Pci\UhciDxe\UhciDebug.c 
> d:\edk2maintain\edk2\MdeModulePkg\Bus\Pci\UhciDxe\UsbHcMem.c 
> d:\edk2maintain\edk2\MdeModulePkg\Bus\Pci\UhciDxe\UhciSched.c
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx86\x86\cl.exe"' : return code '0x2'
> Stop.
> 
> 
> build.py...
>  : error 7000: Failed to execute command
>         C:\Program Files (x86)\Microsoft Visual 
> Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx86\x86\nmake
> .exe /nologo tbuild 
> [d:\edk2maintain\edk2\Build\OvmfIa32\DEBUG_VS2017\IA32\OvmfPkg\LinuxIn
> itrdDynamicShellCommand\LinuxInitrdDynamicShellCommand]
> 
> 
> build.py...
>  : error F002: Failed to build module
>         
> d:\edk2maintain\edk2\OvmfPkg\LinuxInitrdDynamicShellCommand\LinuxInitr
> dDynamicShellCommand.inf [IA32, VS2017, DEBUG]
> 
> - Failed -

Can you please hack up a patch for OvmfPkg to suppress all of these problems, post it as an RFC, and then we can clean it up as necessary?

We don't have access to VS2017. (I'm not sure if it's available free of charge for download, but even if it is, last time I set up a VS environment in a Windows guest, it took me a day or so.) Without access to VS2017, it's very slow to solve such problems from our end, but you could at least collect all the issues, because you can re-run the build immediately after dealing with the most recently seen build error.

Hopefully this will get better once
<https://bugzilla.tianocore.org/show_bug.cgi?id=2570> is solved (i.e.
when OVMF is included in CI builds).

Thanks
Laszlo