public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [edk2-devel] [Patch 0/2] Move RUNTIME_FUNCTION redefintion fix to EmulatorPkg
Date: Sun, 23 Jul 2023 19:11:59 -0600	[thread overview]
Message-ID: <fc223993-89e7-dec6-8c95-4df2690dd33a@bsdio.com> (raw)
In-Reply-To: <20230722010622.1708-1-michael.d.kinney@intel.com>

For the series:


Reviewed-by: Rebecca Cran <rebecca@bsdio.com>


On 7/21/23 19:06, Michael D Kinney wrote:
> Remove RUNTIME_FUNCTION redefinition error workaround from
> the following commit to the MdePkg that only impacts EmulatorPkg
> builds that uses windows include files:
>
> https://github.com/tianocore/edk2/commit/ff52068d9261b9391d75b83a2a4e40e040f3b6eb
>
> The correct location for this fix is in the EmulatorPkg
> in the WinInclude.h file that addresses all the name
> collisions between edk2 types and windows types.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael D Kinney michael.d.kinney@intel.com
>
> Michael D Kinney (2):
>    EmulatorPkg/Win/Host: Fix RUNTIME_FUNCTION redefinition error
>    MdePkg/Include/IndustryStandard: Remove VS20xx workaround
>
>   EmulatorPkg/Win/Host/WinInclude.h         | 10 ++++++----
>   MdePkg/Include/IndustryStandard/PeImage.h |  5 -----
>   2 files changed, 6 insertions(+), 9 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107148): https://edk2.groups.io/g/devel/message/107148
Mute This Topic: https://groups.io/mt/100288520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2023-07-24  1:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-22  1:06 [edk2-devel] [Patch 0/2] Move RUNTIME_FUNCTION redefintion fix to EmulatorPkg Michael D Kinney
2023-07-22  1:06 ` [edk2-devel] [Patch 1/2] EmulatorPkg/Win/Host: Fix RUNTIME_FUNCTION redefinition error Michael D Kinney
2023-07-24  1:56   ` Ni, Ray
2023-07-22  1:06 ` [edk2-devel] [Patch 2/2] MdePkg/Include/IndustryStandard: Remove VS20xx workaround Michael D Kinney
2023-07-24  1:09 ` [edk2-devel] 回复: [Patch 0/2] Move RUNTIME_FUNCTION redefintion fix to EmulatorPkg gaoliming via groups.io
2023-07-24  1:11 ` Rebecca Cran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc223993-89e7-dec6-8c95-4df2690dd33a@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox