From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 38CCAD80056 for ; Mon, 24 Jul 2023 01:12:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5k0DPkNDF0c9tB4wisAGDBlLbZFJxH+yl13j5HL9IRc=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:X-Received:X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:X-Received:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690161130; v=1; b=hJDWNAt4dvdn3KphpFAwadlyuT+Mj+J43D0P+4H/XJXMfKtS7ODw5zP/Vti9dRJIrw/Iq2Qc osoVyDQbKXzKfv+fzHP49xfg4ityob5P2zUokppCXYP1sveiPJdKG4zvn5z2EGpII7CjiyZYS9Q raJEEFDTLMPMFgQKkDf4p0YQ= X-Received: by 127.0.0.2 with SMTP id 1u4JYY7687511xWLvVXrbiJ0; Sun, 23 Jul 2023 18:12:10 -0700 X-Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mx.groups.io with SMTP id smtpd.web10.38206.1690161129853243590 for ; Sun, 23 Jul 2023 18:12:10 -0700 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 733BA3200124; Sun, 23 Jul 2023 21:12:08 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 23 Jul 2023 21:12:09 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrheejgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepueegffduhedtffeileegledvheduhefgkeeuvedvuedulefftdehheeigeej ieelnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Jul 2023 21:12:06 -0400 (EDT) Message-ID: Date: Sun, 23 Jul 2023 19:11:59 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [edk2-devel] [Patch 0/2] Move RUNTIME_FUNCTION redefintion fix to EmulatorPkg To: Michael D Kinney , devel@edk2.groups.io Cc: Gerd Hoffmann , Liming Gao , Zhiguang Liu , Andrew Fish , Ray Ni References: <20230722010622.1708-1-michael.d.kinney@intel.com> From: "Rebecca Cran" In-Reply-To: <20230722010622.1708-1-michael.d.kinney@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: L2fOAHgAxKyzsHaGTGncc63cx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hJDWNAt4; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none For the series: Reviewed-by: Rebecca Cran On 7/21/23 19:06, Michael D Kinney wrote: > Remove RUNTIME_FUNCTION redefinition error workaround from > the following commit to the MdePkg that only impacts EmulatorPkg > builds that uses windows include files: > > https://github.com/tianocore/edk2/commit/ff52068d9261b9391d75b83a2a4e40e0= 40f3b6eb > > The correct location for this fix is in the EmulatorPkg > in the WinInclude.h file that addresses all the name > collisions between edk2 types and windows types. > > Cc: Gerd Hoffmann > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Michael D Kinney michael.d.kinney@intel.com > > Michael D Kinney (2): > EmulatorPkg/Win/Host: Fix RUNTIME_FUNCTION redefinition error > MdePkg/Include/IndustryStandard: Remove VS20xx workaround > > EmulatorPkg/Win/Host/WinInclude.h | 10 ++++++---- > MdePkg/Include/IndustryStandard/PeImage.h | 5 ----- > 2 files changed, 6 insertions(+), 9 deletions(-) > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107148): https://edk2.groups.io/g/devel/message/107148 Mute This Topic: https://groups.io/mt/100288520/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-