Re: [edk2-platforms] [patch V2 19/35] Platform/RaspberryPi: Consume MdeLibs.dsc.inc for RegisterFilterLib

["Pete Batard" <pete@akeo.ie>]

On 2021.03.22 08:53, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
> 
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
> 
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc | 4 +++-
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 4 +++-
>   2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 107cbda297..969d723af1 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -1,10 +1,10 @@
>   # @file
>   #
>   #  Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> -#  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +#  Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
>   #  Copyright (c) 2017 - 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
>   ##
> @@ -53,10 +53,12 @@ [Defines]
>   #
>   # Library Class section - list of all Library Classes needed by this Platform.
>   #
>   ################################################################################
>   [LibraryClasses.common]
> +  !include MdePkg/MdeLibs.dsc.inc
> +
>   !if $(TARGET) == RELEASE
>     DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
>   !else
>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>   !endif
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index e0fad6f744..ef1224b1f7 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -1,10 +1,10 @@
>   # @file
>   #
>   #  Copyright (c) 2011 - 2020, ARM Limited. All rights reserved.
>   #  Copyright (c) 2017 - 2018, Andrei Warkentin <andrey.warkentin@gmail.com>
> -#  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
> +#  Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
>   ##
> @@ -51,10 +51,12 @@ [Defines]
>   #
>   # Library Class section - list of all Library Classes needed by this Platform.
>   #
>   ################################################################################
>   [LibraryClasses.common]
> +  !include MdePkg/MdeLibs.dsc.inc
> +
>   !if $(TARGET) == RELEASE
>     DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
>   !else
>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>   !endif
> 

Reviewed-by: Pete Batard <pete@akeo.ie>