From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web11.12122.1616417782336618907 for ; Mon, 22 Mar 2021 05:56:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=fZzs5DNm; spf=pass (domain: akeo.ie, ip: 209.85.128.44, mailfrom: pete@akeo.ie) Received: by mail-wm1-f44.google.com with SMTP id f22-20020a7bc8d60000b029010c024a1407so11377240wml.2 for ; Mon, 22 Mar 2021 05:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=70le8QSxTTGfSrxZSEbfXlk8h1gNIKfYGD+QMEV0pnQ=; b=fZzs5DNmZlgFghG5EXhT7PHWdpXgzmU3tj9gmlMbx1lXMYcfwc2qBoW1rIId1ItlgS lY8Vt/Bl0ljtINoXsPKiI28H5pCNeP9UxmfUtOsUKU/nwH3bCXx6jJXffsLYZ09R0OoA oRnQ0+45JlxVsSxDuDujQjXUa7UxvdANC+qeADF1/oSGF8GhMyQk9twWstTmlLnd2E/4 rCSGAG7sFUpY370afkrPgWkd6Gs6Mr3VOkx2wcTh5JZEW/7yhNVGiYRcxfF74BkWLuHL /Cfv7MHCsLoD5SH0T9UH2/C8N6y2MwQX6WBOu49sluHniMLR0iyN01Jj3XGdASeaZMCD TtHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=70le8QSxTTGfSrxZSEbfXlk8h1gNIKfYGD+QMEV0pnQ=; b=uaCB56GDRBm3B6w/9/shur+mYG7wlVTDgI50uGWtx/zKSglAeLq9QT5KMqdGKrlLyb /5S2Vz00fokbSuh2u+Wf3GmUhk6fuVM7OiMQONb/1JSMyxc6VftmBlPuQkCXocA1r1eF WEHIBsjFAPuwyhwWcJ6hK48WL+hGCiZ2EYedlqj8kfiu7gWMArnmrYZ8PhVH8GAlCZmS XRXHPaEtEvdshEPevregPr24IhghiYo9ilgyP4JME65sg48qIP0kH8nmhs6laC7EwlMi En8Nqzd6yF3jL1XV8vAUHBeCSjdD5YVIkjxBzB7tR7OzuvsjwTkeDXRsN6z/QuoOPeKv G8IQ== X-Gm-Message-State: AOAM532ugYd6rVgW1jd7caZ5Ha6qAPxirzuG07Yu4ZVQ0LP4SZ/uA730 IadIZG5SCEAEYjA3Ya2S/AmuKQ== X-Google-Smtp-Source: ABdhPJztgyvIPglQCL9hqCvfYlbQSrg9nGgiIbIBoATlc2EpVzAID7BM7102MYtXzEL49pjdFDgYjA== X-Received: by 2002:a05:600c:409:: with SMTP id q9mr16230782wmb.105.1616417780894; Mon, 22 Mar 2021 05:56:20 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.59.151]) by smtp.googlemail.com with ESMTPSA id m11sm18468683wrz.40.2021.03.22.05.56.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 05:56:20 -0700 (PDT) Subject: Re: [edk2-platforms] [patch V2 19/35] Platform/RaspberryPi: Consume MdeLibs.dsc.inc for RegisterFilterLib To: Dandan Bi , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm References: <20210322085401.19012-1-dandan.bi@intel.com> <20210322085401.19012-10-dandan.bi@intel.com> From: "Pete Batard" Message-ID: Date: Mon, 22 Mar 2021 12:56:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322085401.19012-10-dandan.bi@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2021.03.22 08:53, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > MdeLibs.dsc.inc was added for some basic/default library > instances provided by MdePkg and RegisterFilterLibNull Library > was also added into it as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for > RegisterFilterLibNull which will be consumed by IoLib and BaseLib. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Pete Batard > Signed-off-by: Dandan Bi > --- > Platform/RaspberryPi/RPi3/RPi3.dsc | 4 +++- > Platform/RaspberryPi/RPi4/RPi4.dsc | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > index 107cbda297..969d723af1 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -1,10 +1,10 @@ > # @file > # > # Copyright (c) 2011 - 2020, ARM Limited. All rights reserved. > # Copyright (c) 2014, Linaro Limited. All rights reserved. > -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. > +# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved. > # Copyright (c) 2017 - 2018, Andrei Warkentin > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -53,10 +53,12 @@ [Defines] > # > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > [LibraryClasses.common] > + !include MdePkg/MdeLibs.dsc.inc > + > !if $(TARGET) == RELEASE > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > !else > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > !endif > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index e0fad6f744..ef1224b1f7 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -1,10 +1,10 @@ > # @file > # > # Copyright (c) 2011 - 2020, ARM Limited. All rights reserved. > # Copyright (c) 2017 - 2018, Andrei Warkentin > -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. > +# Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved. > # Copyright (c) 2014, Linaro Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -51,10 +51,12 @@ [Defines] > # > # Library Class section - list of all Library Classes needed by this Platform. > # > ################################################################################ > [LibraryClasses.common] > + !include MdePkg/MdeLibs.dsc.inc > + > !if $(TARGET) == RELEASE > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > !else > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > !endif > Reviewed-by: Pete Batard