From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.2236.1573727826683298499 for ; Thu, 14 Nov 2019 02:37:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ngyk76z4; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573727825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=40EomafTKw67oPVGugPmkKm6A975B4weZ2/a/tvkJuM=; b=Ngyk76z4CTZ+zfBsvYKw32zWT8ok7htjUroOPc7ZA3MKTUMXdnAgqL5CxEidr5fTDbkDUJ IRKD4pOtSdvLbJmQYTD3RUNDTBOtfRsOxZnWWK/OgGg48cb6hSwuRnegQn9HeOvtalCc37 kV2Y85OcWmRkeE2+vBZxyGsXR7gSoSs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-2r3lr3EfMae-g7ggoxbAHw-1; Thu, 14 Nov 2019 05:37:01 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89EC718B6382; Thu, 14 Nov 2019 10:37:00 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-80.ams2.redhat.com [10.36.117.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 763965F76E; Thu, 14 Nov 2019 10:36:59 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files To: devel@edk2.groups.io, jian.j.wang@intel.com Cc: Leif Lindholm , Ard Biesheuvel References: <20191114021743.3876-1-jian.j.wang@intel.com> <20191114021743.3876-10-jian.j.wang@intel.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 14 Nov 2019 11:36:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191114021743.3876-10-jian.j.wang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 2r3lr3EfMae-g7ggoxbAHw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable On 11/14/19 03:17, Wang, Jian J wrote: > Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib. Update > ArmVirt.dsc.inc file to accommodate the coming changes. It's supposed > that only TlsDxe needs random number. The RngDxeLib is added for it. For > all other drivers, RngLibNull is used by default. >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1871 > Cc: Leif Lindholm > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Jian J Wang > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 10037c938e..10e0890699 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -156,8 +156,10 @@ > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > !if $(NETWORK_TLS_ENABLE) =3D=3D TRUE > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > + RngLib|SecurityPkg/RandomNumberGenerator/DxeRngLibRngProtocol/DxeRngLi= bRngProtocol.inf > !else > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > + RngLib|MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf > !endif > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > =20 >=20 (1) This is not right: the non-Null lib instance should be linked into TlsDxe only, like in the OvmfPkg patch. Please locate TlsAuthConfigDxe in both "ArmVirtQemu.dsc" and "ArmVirtQemuKernel.dsc", and implement the same approach as in OvmfPkg near "TlsAuthConfigDxe". (2) See other comments in my OvmfPkg patch review. Thanks Laszlo