From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8BE182098EA8A for ; Wed, 25 Jul 2018 08:18:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D7D52401DEA9; Wed, 25 Jul 2018 15:18:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-122-38.rdu2.redhat.com [10.10.122.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F7242026D68; Wed, 25 Jul 2018 15:18:58 +0000 (UTC) From: Laszlo Ersek To: Eric Dong , edk2-devel@lists.01.org References: <20180725075020.240-1-eric.dong@intel.com> Message-ID: Date: Wed, 25 Jul 2018 17:18:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 25 Jul 2018 15:18:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 25 Jul 2018 15:18:58 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch V3 0/3] StartAllAPs should not use disabled APs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 15:18:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/25/18 14:12, Laszlo Ersek wrote: > On 07/25/18 09:50, Eric Dong wrote: >> This patch series include changes: >> 1. StartAllAPs should not use disabled APs, this is required by UEFI spec. >> 2. Refine the code to remove the redundant definitions. >> >> V2 changes: >> Use CpuStateReady to distinguish the AP state from CpuStateIdle. >> >> V3 Changes: >> Only change 3/3 patch. Only not use disabled APs when WakeUpAP called >> by StartAllAps function. In other cases, also include disabled APs. >> >> Eric Dong (3): >> UefiCpuPkg/MpInitLib: Remove redundant CpuStateFinished State. >> UefiCpuPkg/MpInitLib: Remove StartCount and volatile definition. >> UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs. >> >> UefiCpuPkg/Library/MpInitLib/MpLib.c | 33 +++++++++++++++------------------ >> UefiCpuPkg/Library/MpInitLib/MpLib.h | 4 +--- >> 2 files changed, 16 insertions(+), 21 deletions(-) >> > > I requested commit message updates for all three patches. With those > implemented, please add: > > Reviewed-by: Laszlo Ersek > > (No need to repost.) > > Please give me some more time to regression-test this series as well. This series works nicely on my end. I performed my usual Linux guest tests, in all my usual guest environments, plus 10 cold boots in each environment. Everything worked fine. For patches #1 and #2: Tested-by: Laszlo Ersek For patch #3: Regression-tested-by: Laszlo Ersek (I'm giving R-t-b and not T-b for patch #3 because OVMF doesn't exercise the MP PPI/Protocol member functions that disable APs.) >>From my side, please update the commit messages as agreed, and go ahead with the pushing. Thanks! Laszlo