From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B5BFB2194D387 for ; Tue, 21 Aug 2018 08:44:42 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B223402315A; Tue, 21 Aug 2018 15:44:41 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-71.rdu2.redhat.com [10.10.121.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81CC210D14FC; Tue, 21 Aug 2018 15:44:40 +0000 (UTC) To: Jian J Wang , edk2-devel@lists.01.org Cc: Ruiyu Ni , Eric Dong References: <20180821030515.10156-1-jian.j.wang@intel.com> <20180821030515.10156-5-jian.j.wang@intel.com> From: Laszlo Ersek Message-ID: Date: Tue, 21 Aug 2018 17:44:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180821030515.10156-5-jian.j.wang@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 21 Aug 2018 15:44:41 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 21 Aug 2018 15:44:41 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2 4/4] UefiCpuPkg/PiSmmCpuDxeSmm: implement non-stop mode for SMM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 15:44:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/21/18 05:05, Jian J Wang wrote: >> v2 changes: >> fix GCC build error caused by an unused variable in GuardPagePFHandler() > > Since SMM profile feature has already implemented non-stop mode if #PF > occurred, this patch just makes use of the existing implementation to > accommodate heap guard and NULL pointer detection feature. > > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 43 ++++++++++++------ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.nasm | 3 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 58 +++++++++++++++++++++++- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h | 15 ++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 6 +++ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 43 ++++++++++++------ > 6 files changed, 137 insertions(+), 31 deletions(-) It seems like the changes are no-ops for platforms that set all these PCDs to zero, so from my side Acked-by: Laszlo Ersek Thanks Laszlo