From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.50]) by mx.groups.io with SMTP id smtpd.web12.2154.1633447826421968329 for ; Tue, 05 Oct 2021 08:30:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=7yqk/7OH; spf=pass (domain: arm.com, ip: 40.107.15.50, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d6RB9Tu23x2ic8z1hmMKnj7yoh+bT8LKqBtXZun6Zh8=; b=7yqk/7OHAs1D+dQzH5lHrwoWKQAr9SwRY1pWd/JzVIJ+SAEnXCA7XHjboBNkl93sbdrKgcSfYZon862p0wP3k9X5Fo3FQc0yM7WgoeFQsvkY0geElZIa3K/SOvOsTZXTNxHho5hjeYuql7nxIE2YkPHM4f0vKS85vygscIUd7fc= Received: from AS9PR06CA0047.eurprd06.prod.outlook.com (2603:10a6:20b:463::9) by AM9PR08MB5905.eurprd08.prod.outlook.com (2603:10a6:20b:282::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Tue, 5 Oct 2021 15:30:15 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:463:cafe::eb) by AS9PR06CA0047.outlook.office365.com (2603:10a6:20b:463::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Tue, 5 Oct 2021 15:30:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 15:30:15 +0000 Received: ("Tessian outbound 16951d3c485e:v103"); Tue, 05 Oct 2021 15:30:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e68ad092d419ac8c X-CR-MTA-TID: 64aa7808 Received: from 151ff274fef7.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 03FEF6B2-63EE-48FE-9305-9C1E49A2C0DD.1; Tue, 05 Oct 2021 15:30:09 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 151ff274fef7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Oct 2021 15:30:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayrWLT/R9uX3H35Oim7fCqAyay+Tlb8xdl41z1h2nPt+FOaDaOeMUAKq96V0XilDfOLYV0S4C6CTsaXm9D7aXAPYHEcZqGj5fyP/2SxIfmxd4ZsXrWMxRrOzeOHsTbKbH8od218jWWjDkqfEfwe9JGKnc7Pdm/8MXnKXKwFvAC8VKl62xLWjhzzftcxQxKaVPkknCyPD48/SEZPdeVmu7OfQOkuY2oVEPE9WXMOAH3SiEb5CSZM0CsqXEzfu0q6gHH/IfVHhyrqvZFo6TVL4yO1ld8zH8G+hxibtaO0qAtbLLgEBdkMzt7kQZBy2wPSaVj90iI5i2ZwinUu4NN7KVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d6RB9Tu23x2ic8z1hmMKnj7yoh+bT8LKqBtXZun6Zh8=; b=BZqvnE7eQug1SlF+3/eFPtxqylWFMU2kYoniGDV3fjj0YPIheYfTlTXgLCjdOu1ibeJ6+wLm1csxymAQRFZJn56H25EiBskRUGtYGAs04UEg9ormoZINyuWX7CnUNbC1gJvvrVmejyZSAz5uiCHWyES9jrIbULCLunzeG0aOqwA6ByEjks70rXCUgQjk04reISu0gLUO2iblPcDXE/FXLkEYH9zohCyevAAvdw/NOPisP1TLhcmitq+5MhxKnMyywzd6R9TIvuY25e3JDtgV7IdtNZ6pgbxXcRN7YWxyBToA8HG/GfYbImkjYaagRJ0Y9+9+8e5ENcwEFWJoGdWx6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d6RB9Tu23x2ic8z1hmMKnj7yoh+bT8LKqBtXZun6Zh8=; b=7yqk/7OHAs1D+dQzH5lHrwoWKQAr9SwRY1pWd/JzVIJ+SAEnXCA7XHjboBNkl93sbdrKgcSfYZon862p0wP3k9X5Fo3FQc0yM7WgoeFQsvkY0geElZIa3K/SOvOsTZXTNxHho5hjeYuql7nxIE2YkPHM4f0vKS85vygscIUd7fc= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4690.eurprd08.prod.outlook.com (2603:10a6:20b:cd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct 2021 15:30:02 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 15:30:02 +0000 Subject: Re: [PATCH v1] DynamicTablesPkg: Update FADT generator to ACPI 6.4 To: Chris Jones , devel@edk2.groups.io Cc: Alexei.Fedorov@arm.com, Ben.Adderson@arm.com, Akanksha.Jain2@arm.com, Matteo.Carlini@arm.com, nd@arm.com References: <20210817135058.28579-1-christopher.jones@arm.com> From: "Sami Mujawar" Message-ID: Date: Tue, 5 Oct 2021 16:30:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210817135058.28579-1-christopher.jones@arm.com> X-ClientProxiedBy: LO4P123CA0447.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::20) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO4P123CA0447.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 5 Oct 2021 15:30:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d6d0b9f-dddf-48fc-0eb7-08d9881507c8 X-MS-TrafficTypeDiagnostic: AM6PR08MB4690:|AM9PR08MB5905: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JAmACRd2OMixGsK5GfxSWOHFNdpNsteRYVHSB52yy8JTKNxWlu8L7/HAoHAX5O/u9aZbkYRELBTLZPSPCci7OP45w5CLqQero8l7wSS5BpanBbr2ahhzJSOQAv5oj20W1R/CbJEcV0FD/eQNdMqpZwHUql6Ri0ReH+8SDBNHuPPTyPNbQ/QIfYOHY4joVl9r2IAw1JmDIV43FVZk9Gr709CvWimPvvdmDMPXHBtKVq1hDon//lrsRQGVvKeKYP+IvkQlRCTRzHlbd3yzXgj2qT39Kc9p5CsBwIDXt4niPkDyPJCoMbB1GhFA7JsdpHgvQgB45dYXKAL0SO786LiTEdsMiOynqusDxNd9pxNnXW+FJ6NW/jyCCiscIYNx5DS1rnAKhHEwLl2qm/35Sbhc+n3cYTc/nj1/s60Ktghz79/y5es/K7o5zL3TjfFSdL/A2oQmjitD+n+ppTMhjv5pObQQDQFsaDYMsIKPegOge8+/ru7TqO4rOsqAXjUI6BcJcFpdimfwP9H8mMLUxCTwnjxdwxrRPcnIWeP38usmBKo9LT0F2dj1un+tzQe5Bz00ZFfPQWXxHaylBxMapTxDe3pM1QwxQFtvXMjhnHErK8DTNo9JFdh1ILGv+wrkofWQWE/Uf8vGmwGc8tuHdzsZ/b9xEo/9s8G0gU4ibD4Aa/lsSipcXAmURZNow7HbvMlLiILv8savBqy9y4EKkyW9cv9DPI8RCKi1eqw+tOWAu7lR3GxUSaUFwxSGpMd08U2sLs57sPKwK2jvDnnUK3by6/LOD0XcY6CglZi28oeu1e3i66JSCysoCJ4SfpU4knsxKfxikhzPa/SkikVfaP+COnlbtYyfcd7HuO+VTIBn+I/I20Q4SBG13kUnMeeLQ1nfYCZjcW21SDWN9NFlzwUzVA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(16576012)(5660300002)(83380400001)(2906002)(6486002)(508600001)(4326008)(44832011)(2616005)(53546011)(31696002)(956004)(26005)(15650500001)(8676002)(8936002)(16799955002)(316002)(38350700002)(38100700002)(31686004)(186003)(66556008)(66476007)(86362001)(36756003)(66946007)(966005)(52116002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4690 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 02660258-4013-4297-b726-08d98814fff2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zo/Ytu8GXS6x1EZMMZLCh0+Q5fhpjlJUm+v79NqE16B0XBiUB7v2tCSNbdblnQqF7OsZIuSIn0HjgXgHjmiaZTd5bX9RylhGP95P0uGz1YbW1GqRVXvXdfr4IXI2IWGwH4RKzTxwzgnpzW6MEauGKsGV65k/UxLmbG7KcWaMdP/cbDWWL75ARr20wMVN06RNV9XM/igiWERGeoiYT7A5KRC201GVFobEZWXtC+jDVpJINcwzgOEguEKSiamWKvWE3cERf05OLqFODyCsi7sWP1R04/h4RDygMZi+aCrixT/dxCPsZpKt6RXfW6xwuj7FqFG3m0q8SR81yvwdImR8MTS3K0S/7fThla/RMf27HGviQtcsMp7QH4X0T/KeDUlA94ikgsSZsKTFoN2Y5EHrOJIOCyhQTbBGQvUybszHmn+fCHHoUmolt47tJxsPDcc8b7M8fPybwtgghIl334K47uGBxCI7Iwb6tNOmU9uFtgisgjDCIyrN8gguiPkcw45cE4QsXHea6llYVBxesyWYAHyDYnyWMpnpNNtIQD1YX/3tRIknhf4doQlu3LSe9tIS6gOOsqG2FlLIWWFHFhFPzFFDxpVe1ubDER6gsOrimCxkhe8at9ueC6pihRXq++SkDza4gO+lvm9HHyjjS8tW/p+ETY8xLN5Kp+hGefM/X6+7qFQjyugvOV1zoxtT2252w7TXFxJjPjKj7vbpVdlHrqPkF5GMWKWm6VU+nqOupF7f0kM6kzXQFhFCYorQYiHhdMkCRPAvxABrP2Lc94aItTuqlWdyUHfI6kgH6yr2w+6A0TmABWjsYHVWTW8+x41FUBysQLFBmNhL+04NYpFUBV8MyPvn2KnIrLSsaW3w6b8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(966005)(5660300002)(186003)(508600001)(6486002)(53546011)(8936002)(86362001)(31696002)(956004)(47076005)(2616005)(83380400001)(336012)(26005)(356005)(4326008)(70586007)(70206006)(81166007)(316002)(36756003)(16576012)(44832011)(2906002)(82310400003)(36860700001)(31686004)(8676002)(15650500001)(16799955002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 15:30:15.5214 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d6d0b9f-dddf-48fc-0eb7-08d9881507c8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5905 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Merged as 862e814de403..06a326caf125 Thanks. Regards, Sami Mujawar On 17/08/2021 02:50 PM, Chris Jones wrote: > Bugzilla: 3568 (https://bugzilla.tianocore.org/show_bug.cgi?id=3568) > > Update the FADT generator to use Acpi64.h. As the FADT revision tracks > the ACPI revision this updates the minor revision value generated. > > Mantis ID for change: https://mantis.uefi.org/mantis/view.php?id=2105 > > Signed-off-by: Chris Jones > --- > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 104 ++++++++++---------- > 1 file changed, 52 insertions(+), 52 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c > index b748c982b285a8f6c012c0e08fb95c9904f47730..b4ebd463da02ca37f22b73413b038471081f64e7 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c > @@ -1,11 +1,11 @@ > /** @file > FADT Table Generator > > - Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. > + Copyright (c) 2017 - 2021, ARM Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > > @par Reference(s): > - - ACPI 6.3 Specification, January 2019 > + - ACPI 6.4 Specification, January 2021 > > **/ > > @@ -32,8 +32,8 @@ Requirements: > > /** This macro defines the FADT flag options for ARM Platforms. > */ > -#define FADT_FLAGS (EFI_ACPI_6_3_HW_REDUCED_ACPI | \ > - EFI_ACPI_6_3_LOW_POWER_S0_IDLE_CAPABLE) > +#define FADT_FLAGS (EFI_ACPI_6_4_HW_REDUCED_ACPI | \ > + EFI_ACPI_6_4_LOW_POWER_S0_IDLE_CAPABLE) > > /** This macro defines the valid mask for the FADT flag option > if HW_REDUCED_ACPI flag in the table is set. > @@ -42,47 +42,47 @@ Requirements: > 22-31 (reserved). > > Valid bits are: > - EFI_ACPI_6_3_WBINVD BIT0 > - EFI_ACPI_6_3_PWR_BUTTON BIT4 > - EFI_ACPI_6_3_SLP_BUTTON BIT5 > - EFI_ACPI_6_3_FIX_RTC BIT6 > - EFI_ACPI_6_3_DCK_CAP BIT9 > - EFI_ACPI_6_3_RESET_REG_SUP BIT10 > - EFI_ACPI_6_3_SEALED_CASE BIT11 > - EFI_ACPI_6_3_HEADLESS BIT12 > - EFI_ACPI_6_3_USE_PLATFORM_CLOCK BIT15 > - EFI_ACPI_6_3_FORCE_APIC_CLUSTER_MODEL BIT18 > - EFI_ACPI_6_3_FORCE_APIC_PHYSICAL_DESTINATION_MODE BIT19 > - EFI_ACPI_6_3_HW_REDUCED_ACPI BIT20 > - EFI_ACPI_6_3_LOW_POWER_S0_IDLE_CAPABLE BIT21 > + EFI_ACPI_6_4_WBINVD BIT0 > + EFI_ACPI_6_4_PWR_BUTTON BIT4 > + EFI_ACPI_6_4_SLP_BUTTON BIT5 > + EFI_ACPI_6_4_FIX_RTC BIT6 > + EFI_ACPI_6_4_DCK_CAP BIT9 > + EFI_ACPI_6_4_RESET_REG_SUP BIT10 > + EFI_ACPI_6_4_SEALED_CASE BIT11 > + EFI_ACPI_6_4_HEADLESS BIT12 > + EFI_ACPI_6_4_USE_PLATFORM_CLOCK BIT15 > + EFI_ACPI_6_4_FORCE_APIC_CLUSTER_MODEL BIT18 > + EFI_ACPI_6_4_FORCE_APIC_PHYSICAL_DESTINATION_MODE BIT19 > + EFI_ACPI_6_4_HW_REDUCED_ACPI BIT20 > + EFI_ACPI_6_4_LOW_POWER_S0_IDLE_CAPABLE BIT21 > */ > #define VALID_HARDWARE_REDUCED_FLAG_MASK ( \ > - EFI_ACPI_6_3_WBINVD | \ > - EFI_ACPI_6_3_PWR_BUTTON | \ > - EFI_ACPI_6_3_SLP_BUTTON | \ > - EFI_ACPI_6_3_FIX_RTC | \ > - EFI_ACPI_6_3_DCK_CAP | \ > - EFI_ACPI_6_3_RESET_REG_SUP | \ > - EFI_ACPI_6_3_SEALED_CASE | \ > - EFI_ACPI_6_3_HEADLESS | \ > - EFI_ACPI_6_3_USE_PLATFORM_CLOCK | \ > - EFI_ACPI_6_3_FORCE_APIC_CLUSTER_MODEL | \ > - EFI_ACPI_6_3_FORCE_APIC_PHYSICAL_DESTINATION_MODE | \ > - EFI_ACPI_6_3_HW_REDUCED_ACPI | \ > - EFI_ACPI_6_3_LOW_POWER_S0_IDLE_CAPABLE) > + EFI_ACPI_6_4_WBINVD | \ > + EFI_ACPI_6_4_PWR_BUTTON | \ > + EFI_ACPI_6_4_SLP_BUTTON | \ > + EFI_ACPI_6_4_FIX_RTC | \ > + EFI_ACPI_6_4_DCK_CAP | \ > + EFI_ACPI_6_4_RESET_REG_SUP | \ > + EFI_ACPI_6_4_SEALED_CASE | \ > + EFI_ACPI_6_4_HEADLESS | \ > + EFI_ACPI_6_4_USE_PLATFORM_CLOCK | \ > + EFI_ACPI_6_4_FORCE_APIC_CLUSTER_MODEL | \ > + EFI_ACPI_6_4_FORCE_APIC_PHYSICAL_DESTINATION_MODE | \ > + EFI_ACPI_6_4_HW_REDUCED_ACPI | \ > + EFI_ACPI_6_4_LOW_POWER_S0_IDLE_CAPABLE) > > #pragma pack(1) > > -/** The AcpiFadt is a template EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE > +/** The AcpiFadt is a template EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE > structure used for generating the FADT Table. > Note: fields marked with "{Template}" will be updated dynamically. > */ > STATIC > -EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE AcpiFadt = { > +EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE AcpiFadt = { > ACPI_HEADER ( > - EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, > - EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE, > - EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_REVISION > + EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, > + EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE, > + EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_REVISION > ), > // UINT32 FirmwareCtrl > 0, > @@ -91,7 +91,7 @@ EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE AcpiFadt = { > // UINT8 Reserved0 > EFI_ACPI_RESERVED_BYTE, > // UINT8 PreferredPmProfile > - EFI_ACPI_6_3_PM_PROFILE_UNSPECIFIED, // {Template}: Power Management Profile > + EFI_ACPI_6_4_PM_PROFILE_UNSPECIFIED, // {Template}: Power Management Profile > // UINT16 SciInt > 0, > // UINT32 SmiCmd > @@ -160,37 +160,37 @@ EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE AcpiFadt = { > 0, > // UINT32 Flags > FADT_FLAGS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE ResetReg > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE ResetReg > NULL_GAS, > // UINT8 ResetValue > 0, > // UINT16 ArmBootArch > - EFI_ACPI_6_3_ARM_PSCI_COMPLIANT, // {Template}: ARM Boot Architecture Flags > + EFI_ACPI_6_4_ARM_PSCI_COMPLIANT, // {Template}: ARM Boot Architecture Flags > // UINT8 MinorRevision > - EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_MINOR_REVISION, > + EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_MINOR_REVISION, > // UINT64 XFirmwareCtrl > 0, > // UINT64 XDsdt > 0, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE XPm1aEvtBlk > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE XPm1aEvtBlk > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE XPm1bEvtBlk > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE XPm1bEvtBlk > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE XPm1aCntBlk > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE XPm1aCntBlk > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE XPm1bCntBlk > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE XPm1bCntBlk > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE XPm2CntBlk > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE XPm2CntBlk > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE XPmTmrBlk > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE XPmTmrBlk > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE XGpe0Blk > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE XGpe0Blk > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE XGpe1Blk > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE XGpe1Blk > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE SleepControlReg > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE SleepControlReg > NULL_GAS, > - // EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE SleepStatusReg > + // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE SleepStatusReg > NULL_GAS, > // UINT64 HypervisorVendorIdentity > EFI_ACPI_RESERVED_QWORD // {Template}: Hypervisor Vendor ID > @@ -532,7 +532,7 @@ BuildFadtTable ( > This, > (EFI_ACPI_DESCRIPTION_HEADER*)&AcpiFadt, > AcpiTableInfo, > - sizeof (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE) > + sizeof (EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE) > ); > if (EFI_ERROR (Status)) { > DEBUG (( > @@ -614,9 +614,9 @@ ACPI_TABLE_GENERATOR FadtGenerator = { > // Generator Description > L"ACPI.STD.FADT.GENERATOR", > // ACPI Table Signature > - EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, > + EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, > // ACPI Table Revision supported by this Generator > - EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_REVISION, > + EFI_ACPI_6_4_FIXED_ACPI_DESCRIPTION_TABLE_REVISION, > // Minimum supported ACPI Table Revision > EFI_ACPI_6_2_FIXED_ACPI_DESCRIPTION_TABLE_REVISION, > // Creator ID