public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Subject: Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md
Date: Tue, 4 Jun 2019 19:55:28 +0200	[thread overview]
Message-ID: <fc65b222-321d-8710-e1de-6fe6d1061899@redhat.com> (raw)
In-Reply-To: <20190604171248.23020-1-michael.d.kinney@intel.com>

On 06/04/19 19:12, Michael D Kinney wrote:
> * Remove refrences EdkCompatibilityPkg
> * Update link to OpenSSL to https://github.com/openssl/openssl
> * Add link to https://github.com/ucb-bar/berkeley-softfloat-3
>   for ArmSoftFloatLib
> 
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Readme.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Readme.md b/Readme.md
> index 1feba16075..d5556e15c6 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -12,10 +12,10 @@ contains the following components that are covered by additional licenses:
>  * [MdeModulePkg/Library/LzmaCustomDecompressLib](MdeModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
>  * [IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/Sdk](IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
>  * [BaseTools/Source/C/VfrCompile/Pccts](BaseTools/Source/C/VfrCompile/Pccts/RIGHTS)
> -* [EdkCompatibilityPkg/Other/Maintained/Tools/Pccts](EdkCompatibilityPkg/Other/Maintained/Tools/Pccts/README)
>  * [MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma](MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/README)
>  * [OvmfPkg](OvmfPkg/License.txt)
> -* [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library/OpensslLib/openssl/LICENSE)
> +* [CryptoPkg/Library/OpensslLib/openssl](https://github.com/openssl/openssl)
> +* [ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3](https://github.com/ucb-bar/berkeley-softfloat-3)
>  
>  The EDK II Project is composed of packages.  The maintainers for each package
>  are listed in [Maintainers.txt](Maintainers.txt).
> 

Please add 1 or 2 sentences to the commit message as to why this change
is useful -- IIUC, the goal is that the links (currently pointing into
submodule trees) become functional in a web browser, when a user looks
at the landing page at <https://github.com/tianocore/edk2/>.

With such a clarification:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

(And I agree this is eligible for pushing during the hard freeze.)

Thanks!
Laszlo

  reply	other threads:[~2019-06-04 17:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 17:12 [Patch] edk2: Update additional licenses in Readme.md Michael D Kinney
2019-06-04 17:55 ` Laszlo Ersek [this message]
2019-06-04 18:00 ` [edk2-devel] " Leif Lindholm
2019-06-04 18:31   ` Michael D Kinney
2019-06-04 18:41     ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc65b222-321d-8710-e1de-6fe6d1061899@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox