From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.13572.1583154578057297617 for ; Mon, 02 Mar 2020 05:09:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=LGZkgaja; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.67, mailfrom: pete@akeo.ie) Received: by mail-wm1-f67.google.com with SMTP id f15so11108550wml.3 for ; Mon, 02 Mar 2020 05:09:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=mzd1DG4vSnkyFk8D2r8l3RugXJvcp/XB5bOqf7FLUWY=; b=LGZkgajau/H2iVAqh/7ky3Mjn6x/E5jav22DDRJTnbT9SZkDpBx/30tE/cIC3h/b+Q PCVg9tbo87TUv4Zzt/0lLZHjq0115ygE20eKXJGjorWSBbLwWaWEAhgIk8skAE/4cGUp 1Yk35eclJ7jK2T+cVaBgvCpmyaeHlT9fL36bYoGsZisza+BJQCrL1VC9qqLe0wFFbGeo ueiPD0CuaQ+8MXnLCm05YdH/swiZd1jZ+bNBsBFQDsdEMu2jAkwF/mvBdxlz9sXow40M j+G71snVLhfVnkO/Otfa3dCX6fjllOY1Lodzi0q+TrgoxScMUSG/YwOns7C1+suMEJlt zcqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mzd1DG4vSnkyFk8D2r8l3RugXJvcp/XB5bOqf7FLUWY=; b=eeys6lDZiSgTKujg+AJAnT4l7AR1C/3PFhPvShF8nQTIJEGTpxBKO7r3+EyAdc+znv MhjDuCkdrFVOCEwkysWUBHNXskS21ImI/envwxmYKvTH0WjiLHd4bZdAdN0ktK1h54FC k7X0C3cnc3XWAEr1bkAQua0QbrJy/bWowLlHbFky894p5E26SNQ8u4kxTbHgOYEKyJ57 bwWf3cAhScF6QK0KuqGpe9yixHbJGT3Z5uyNX+ZLNsI1n39LIDGa1cT4B+ysMNdrM08O Z+c1fbRBmbBCCxZ6hNRgkypm8u1iIz46I3eZsdrDVcvZTcJ/lCnW16Fnxsau35pgWhH/ l5ng== X-Gm-Message-State: APjAAAV9Bl1RGbPJtD38QqAIFZmS/Pz2GuUk7yp3CbGs13bmFSTh0Obx Dk2uMZ73vYo4MVb6q2Z9VfvDBA== X-Google-Smtp-Source: APXvYqzw96bp/GT3z7qa4JeG5jgiCfARBMk2accM2k+46VsXkDtzgKdy7kAZESgwSEqJkRLHRDw3wA== X-Received: by 2002:a05:600c:22c8:: with SMTP id 8mr19793154wmg.178.1583154576591; Mon, 02 Mar 2020 05:09:36 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.56.244]) by smtp.googlemail.com with ESMTPSA id z64sm5533971wmg.35.2020.03.02.05.09.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2020 05:09:35 -0800 (PST) Subject: Re: [edk2-devel] [PATCH] Platform/RPi4/Library/PlatformBootManagerLib: remove dead logo code To: devel@edk2.groups.io, awarkentin@vmware.com References: <20200302030809.48143-1-awarkentin@vmware.com> From: "Pete Batard" Message-ID: Date: Mon, 2 Mar 2020 13:09:34 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200302030809.48143-1-awarkentin@vmware.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.03.02 03:08, Andrei Warkentin via Groups.Io wrote: > Back in RaspberryPiPkg (before upstream Pi 3) support, I wrote > some extra code in PlatformBootManagerLib and BootGraphicsResourceTableDxe > to clear out the logo/BGRT, so that Windows would always show its own > logo instead of the platform logo. It kind of made sense back in the day, > when they only portion of Windows that "ran" on Pi 3 was the part that > could display a logo before BSODing... > > The code in PlatformBootManagerLib (that this patch is removing) only > worked with the matching BootGraphicsResourceTableDxe change*** that > never got upstreamed. Moreover, Windows (for logo/cert) requires BGRT > so these kinds of shennigans aren't worth the effort. > > So, remove the dead code. > > ***https://github.com/andreiw/RaspberryPiPkg/blob/master/edk2Patches/0003-BootGraphicsResourceTableDxe-properly-handle-SetBoot.patch > > Signed-off-by: Andrei Warkentin > --- > .../PlatformBootManagerLib/PlatformBm.c | 18 ------------------ > .../PlatformBootManagerLib.inf | 1 - > 2 files changed, 19 deletions(-) > > diff --git a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > index 12c3829d28..996ba8f399 100644 > --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > > #include "PlatformBm.h" > > @@ -691,7 +690,6 @@ PlatformBootManagerWaitCallback ( > EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION White; > UINT16 Timeout; > EFI_STATUS Status; > - EFI_BOOT_LOGO_PROTOCOL *BootLogo; > > Timeout = PcdGet16 (PcdPlatformBootTimeOut); > > @@ -711,22 +709,6 @@ PlatformBootManagerWaitCallback ( > } else { > Print (L"."); > } > - > - if (TimeoutRemain == 0) { > - BootLogo = NULL; > - > - // > - // Clear out the boot logo so that Windows displays its own logo > - // instead of ours. > - // > - Status = gBS->LocateProtocol (&gEfiBootLogoProtocolGuid, NULL, (VOID**)&BootLogo); > - if (!EFI_ERROR (Status) && (BootLogo != NULL)) { > - Status = BootLogo->SetBootLogo (BootLogo, NULL, 0, 0, 0, 0); > - ASSERT_EFI_ERROR (Status); > - }; > - > - gST->ConOut->ClearScreen (gST->ConOut); > - } > } > > /** > diff --git a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > index 79b75d667f..e40b3f096a 100644 > --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > @@ -81,4 +81,3 @@ > gEfiSimpleFileSystemProtocolGuid > gEsrtManagementProtocolGuid > gEfiUsb2HcProtocolGuid > - gEfiBootLogoProtocolGuid > Reviewed-By & Tested-By: Pete Batard