From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: liming.gao@intel.com, yonghong.zhu@intel.com
Subject: Re: [PATCH v2] BaseTools/Conf: disable DTC legacy phandle format
Date: Thu, 1 Feb 2018 16:53:35 +0100 [thread overview]
Message-ID: <fc7e3f70-c1c7-6589-74e0-a4aced18b5a9@redhat.com> (raw)
In-Reply-To: <20180201111513.13572-1-ard.biesheuvel@linaro.org>
On 02/01/18 12:15, Ard Biesheuvel wrote:
> By default, the device tree compiler emits phandle properties twice:
> one called 'phandle' and another called 'linux,phandle'. Given that
> Linux was updated in early 2010 [0] to accept the former (which is
> what is specified in the ePAPR and device tree specifications), there
> is no point in emitting both when compiling device trees for UEFI
> platforms.
>
> [0] 04b954a673dd02f585a2769c4945a43880faa989
> "of/flattree: Make the kernel accept ePAPR style phandle information"
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> BaseTools/Conf/build_rule.template | 2 +-
> BaseTools/Conf/tools_def.template | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
> index 3e6aa8ff0f34..a5e471eb3c10 100755
> --- a/BaseTools/Conf/build_rule.template
> +++ b/BaseTools/Conf/build_rule.template
> @@ -250,7 +250,7 @@
>
> <Command.GCC>
> "$(PP)" $(DTCPP_FLAGS) $(INC) ${src} > ${d_path}(+)${s_base}.i
> - "$(DTC)" -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i
> + "$(DTC)" $(DTC_FLAGS) -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i
>
> [Visual-Form-Representation-File]
> <InputFile>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 482ef263c274..99ad271471d9 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -4467,6 +4467,7 @@ NOOPT_DDK3790xASL_IPF_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /LTCG /DLL /OPT:REF
> DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG =
> NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> +*_*_*_DTC_FLAGS = -H epapr
>
> DEFINE GCC_ALL_CC_FLAGS = -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common
> DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32 -malign-double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-probe
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2018-02-01 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 11:15 [PATCH v2] BaseTools/Conf: disable DTC legacy phandle format Ard Biesheuvel
2018-02-01 15:53 ` Laszlo Ersek [this message]
2018-02-05 13:58 ` Ard Biesheuvel
2018-02-06 3:05 ` Gao, Liming
2018-02-06 9:59 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc7e3f70-c1c7-6589-74e0-a4aced18b5a9@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox