From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0EEFEAC0DAF for ; Tue, 16 Jan 2024 12:21:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PbXJmjRFyIV/vDBRA9BAcyuj+TKTGeuwe/mB+uIa4cw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705407660; v=1; b=jLu6n/OUoKmVvlEc9PKuwE4G17NVhCuY/jUrNbhV3GMWqBxteDWLTug8SRCjEboIIOp2DBDF X3CPsD+1x3Z1o/7B2CJ7ICcTJmMTMSsVQ3pHoWT0SOkLihjf9z9Fqu/4dkZF8lbmfFkAdJiHvMG lda9/+DMxraTKUQf+qhqltrM= X-Received: by 127.0.0.2 with SMTP id CtHrYY7687511xqaSqE7O35B; Tue, 16 Jan 2024 04:21:00 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.12150.1705407658173818732 for ; Tue, 16 Jan 2024 04:20:58 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8CxifCmdKZlJrIAAA--.3585S3; Tue, 16 Jan 2024 20:20:54 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxPs+hdKZlUAYEAA--.21017S3; Tue, 16 Jan 2024 20:20:49 +0800 (CST) Message-ID: Date: Tue, 16 Jan 2024 20:20:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v7 23/37] ArmVirtPkg: Move the FdtSerialPortAddressLib to OvmfPkg To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Jiewen Yao References: <20240112082153.3284189-1-lichao@loongson.cn> <20240112082522.3298990-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8CxPs+hdKZlUAYEAA--.21017S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQASCGWmPl8EVgAAsr X-Coremail-Antispam: 1Uk129KBj93XoWxuF4rXr18KrW3CrWfGr17Arc_yoWrKw4DpF 1DAr4UGrW8Za1Fy390va4rWan0gas09FZ093y5Aw1aywnxtF1S9r1jkrn5Xr45uF13Jr97 Wrs09a1qvF4Ut3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyKb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq 07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_JF0_Jw 1lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCj r7xvwVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E 87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73Uj IFyTuYvjxUwXo2UUUUU Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lRA2AXyN6IHwhF454EO8WXGAx7686176AA= Content-Type: multipart/alternative; boundary="------------xHATeYfaamfI8GRxx90Ce10d" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="jLu6n/OU"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------xHATeYfaamfI8GRxx90Ce10d Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Laszlo, Thanks, Chao On 2024/1/15 16:32, Laszlo Ersek wrote: > On 1/12/24 09:25, Chao Li wrote: >> Move the FdtSerialPortAddressLib to Ovmfpkg so that other ARCH can >> easily use it. >> >> Build-tested only (with "ArmVirtQemu.dsc"). >> >> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4584 >> >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Cc: Sami Mujawar >> Cc: Gerd Hoffmann >> Cc: Jiewen Yao >> Cc: Laszlo Ersek >> Signed-off-by: Chao Li >> --- >> ArmVirtPkg/ArmVirt.dsc.inc | 2 +- >> .../Include/Library/FdtSerialPortAddressLib.h | 0 >> .../Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c | 0 >> .../FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf | 2 +- >> OvmfPkg/OvmfPkg.dec | 4 ++++ >> 5 files changed, 6 insertions(+), 2 deletions(-) >> rename {ArmVirtPkg =3D> OvmfPkg}/Include/Library/FdtSerialPortAddressL= ib.h (100%) >> rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSe= rialPortAddressLib.c (100%) >> rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSe= rialPortAddressLib.inf (90%) >> >> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc >> index 9b23ef97ec..2bc6a29eb1 100644 >> --- a/ArmVirtPkg/ArmVirt.dsc.inc >> +++ b/ArmVirtPkg/ArmVirt.dsc.inc >> @@ -122,7 +122,7 @@ >> # ARM PL011 UART Driver >> PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf >> SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011Seria= lPortLib.inf >> - FdtSerialPortAddressLib|ArmVirtPkg/Library/FdtSerialPortAddressLib/Fd= tSerialPortAddressLib.inf >> + FdtSerialPortAddressLib|OvmfPkg/Library/FdtSerialPortAddressLib/FdtSe= rialPortAddressLib.inf >> =20 >> PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugP= eCoffExtraActionLib.inf >> #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/Ba= sePeCoffExtraActionLibNull.inf >> diff --git a/ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h b/Ovmf= Pkg/Include/Library/FdtSerialPortAddressLib.h >> similarity index 100% >> rename from ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h >> rename to OvmfPkg/Include/Library/FdtSerialPortAddressLib.h >> diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAdd= ressLib.c b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib= .c >> similarity index 100% >> rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddr= essLib.c >> rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLi= b.c >> diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAdd= ressLib.inf b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressL= ib.inf >> similarity index 90% >> rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddr= essLib.inf >> rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLi= b.inf >> index ae6d0d374b..e27742e9fa 100644 >> --- a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib= .inf >> +++ b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.in= f >> @@ -18,9 +18,9 @@ >> FdtSerialPortAddressLib.c >> =20 >> [Packages] >> - ArmVirtPkg/ArmVirtPkg.dec >> EmbeddedPkg/EmbeddedPkg.dec >> MdePkg/MdePkg.dec >> + OvmfPkg/OvmfPkg.dec >> =20 >> [LibraryClasses] >> BaseLib >> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec >> index 7bc2bf1674..13e69e6648 100644 >> --- a/OvmfPkg/OvmfPkg.dec >> +++ b/OvmfPkg/OvmfPkg.dec >> @@ -29,6 +29,10 @@ >> ## @libraryclass Verify blobs read from the VMM >> BlobVerifierLib|Include/Library/BlobVerifierLib.h >> =20 >> + ## @libraryclass FdtSerialPortAddressLib >> + # >> + FdtSerialPortAddressLib|Include/Library/FdtSerialPortAddressLib.h >> + >> ## @libraryclass Loads and boots a Linux kernel image >> # >> LoadLinuxLib|Include/Library/LoadLinuxLib.h > IIUC, the library class is not removed from "ArmVirtPkg.dec"; please do > that as well, in the same patch. Yes, the changes to ArmVirtPkg.dec is in the patch 25, it should belong=20 to this patch, I will fix it in V8. > > Otherwise, the patch looks OK to me. > > Thanks > Laszlo > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113892): https://edk2.groups.io/g/devel/message/113892 Mute This Topic: https://groups.io/mt/103679474/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------xHATeYfaamfI8GRxx90Ce10d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Laszlo,


=
Thanks,
Chao
On 2024/1/15 16:32, Laszlo Ersek wrote:<= br> 
On 1/12/24 09:25, Chao Li wrot=
e:

Move the FdtSerialPortAddres=
sLib to Ovmfpkg so that other ARCH can
easily use it.

Build-tested only (with "ArmVirtQemu.dsc").

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=
=3D4584

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Chao Li <lichao@loongson.cn>
---
 ArmVirtPkg/ArmVirt.dsc.inc                                    | 2 +-
 .../Include/Library/FdtSerialPortAddressLib.h                 | 0
 .../Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c | 0
 .../FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf       | 2 +-
 OvmfPkg/OvmfPkg.dec                                           | 4 ++++
 5 files changed, 6 insertions(+), 2 deletions(-)
 rename {ArmVirtPkg =3D> OvmfPkg}/Include/Library/FdtSerialPortAddressLi=
b.h (100%)
 rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSer=
ialPortAddressLib.c (100%)
 rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSer=
ialPortAddressLib.inf (90%)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 9b23ef97ec..2bc6a29eb1 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -122,7 +122,7 @@
   # ARM PL011 UART Driver
   PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
   SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPor=
tLib.inf
-  FdtSerialPortAddressLib|ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSe=
rialPortAddressLib.inf
+  FdtSerialPortAddressLib|OvmfPkg/Library/FdtSerialPortAddressLib/FdtSeria=
lPortAddressLib.inf
=20
   PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCof=
fExtraActionLib.inf
   #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePe=
CoffExtraActionLibNull.inf
diff --git a/ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h b/OvmfPkg=
/Include/Library/FdtSerialPortAddressLib.h
similarity index 100%
rename from ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h
rename to OvmfPkg/Include/Library/FdtSerialPortAddressLib.h
diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddres=
sLib.c b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c
similarity index 100%
rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddress=
Lib.c
rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c
diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddres=
sLib.inf b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.=
inf
similarity index 90%
rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddress=
Lib.inf
rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.i=
nf
index ae6d0d374b..e27742e9fa 100644
--- a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.in=
f
+++ b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf
@@ -18,9 +18,9 @@
   FdtSerialPortAddressLib.c
=20
 [Packages]
-  ArmVirtPkg/ArmVirtPkg.dec
   EmbeddedPkg/EmbeddedPkg.dec
   MdePkg/MdePkg.dec
+  OvmfPkg/OvmfPkg.dec
=20
 [LibraryClasses]
   BaseLib
diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index 7bc2bf1674..13e69e6648 100644
--- a/OvmfPkg/OvmfPkg.dec
+++ b/OvmfPkg/OvmfPkg.dec
@@ -29,6 +29,10 @@
   ##  @libraryclass  Verify blobs read from the VMM
   BlobVerifierLib|Include/Library/BlobVerifierLib.h
=20
+  ##  @libraryclass  FdtSerialPortAddressLib
+  #
+  FdtSerialPortAddressLib|Include/Library/FdtSerialPortAddressLib.h
+
   ##  @libraryclass  Loads and boots a Linux kernel image
   #
   LoadLinuxLib|Include/Library/LoadLinuxLib.h

IIUC, the library class is not removed from "ArmVirtPkg.dec"; please do
that as well, in the same patch.
Yes, the changes to ArmVirtPkg.dec is in the patch 25, it should belong to this patch, I will fix it in V8.

Otherwise, the patch looks OK to me.

Thanks
Laszlo
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113892) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------xHATeYfaamfI8GRxx90Ce10d--