From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8DB25AC14FD for ; Fri, 8 Mar 2024 15:29:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nj8j8jJ90r+cKYulV/nLbYkLcpSVNAcpj7L5Dw35ZPs=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1709911749; v=1; b=Cmn2W3Zr8VTMoICXz7Xu/uT6ROZap489zigeahvWJGbM40Bt6Mr+v/S3sy3HYGAs7JTIOag+ /yeFmlZxbRbjUaMULl/Z3z9dbFhgmZyZhRX11ao4dLPDspmVNcMgt2f6EhPs8haCSGQFEYaP8zS DOoVIgic4GsRUNuRB9zUpPQlLk69jmsbA+um7hH+I7Nn/btce/f6t7RNbpLdKrR9IeHJ4zB7ci5 g3ij3hUN4ZxDG42XKBFDfjMIR01d3gDxCuQmCpiwHOJRQuiRDldJblSl9s5Y7xMn6TeOGUS3+Qi gjjfAprLNbuE4rwEOQ3bjoraKNriNpVxl74GRilsZTWFg== X-Received: by 127.0.0.2 with SMTP id 1O0BYY7687511x9ZdN9G7ZLu; Fri, 08 Mar 2024 07:29:09 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.87]) by mx.groups.io with SMTP id smtpd.web11.24780.1709911748547225631 for ; Fri, 08 Mar 2024 07:29:08 -0800 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by CY5PR12MB6480.namprd12.prod.outlook.com (2603:10b6:930:33::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.29; Fri, 8 Mar 2024 15:29:02 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::b913:7732:22e1:b71e]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::b913:7732:22e1:b71e%7]) with mapi id 15.20.7362.029; Fri, 8 Mar 2024 15:29:02 +0000 Message-ID: Date: Fri, 08 Mar 2024 07:29:08 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms PATCH v3 2/7] Silicon/Marvell: Odyssey SmcLib To: devel@edk2.groups.io, ndhillon@marvell.com Cc: quic_llindhol@quicinc.com, mw@semihalf.com, sbalcerak@marvell.com References: <20240118011817.4348-1-ndhillon@marvell.com> <20240118011817.4348-3-ndhillon@marvell.com> From: "Abdul Lateef Attar via groups.io" In-Reply-To: <20240118011817.4348-3-ndhillon@marvell.com> X-ClientProxiedBy: PN3PR01CA0031.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:97::20) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|CY5PR12MB6480:EE_ X-MS-Office365-Filtering-Correlation-Id: 1653827b-2288-4714-2eba-08dc3f847bc4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: KI1A0ekIuRjQ3MC0I0H56zUvoLax89JpAY73DREgj5uBEgqYCzjHidF8/dR+HmhK/etz/QU2P6Z4GLJNn6QA+CiN8/01RpkxQkWvV7q7HBqpuz/o0QjuehbmMDu3PCYBPKhT22nnj1jJxCcvP/h0l2hmRuiNcdm1PJ6A5brTzW45YuzugtExBhz9ZVBD2ZHLVUTpyDOE7DsdqD3YecRgENtsVHoTjvk7Zpb6tlpGoDLduJL9rnuwzLfXM45Udw9A8UAj3i1tJI7ke0MykUURqGsOTf9fAtshY6CRFN5pucq5HymTL8XensLGvAiIfK1hfZDo7TJgukQtqp0gdc2VdN+T6KOvtn//2FjsWNjqdLvPlhpNyWqFLYP3K/4aqOkRxzzpve6wqtxGzfvPIOLuG/lyt5SoZ2fQwOBM4TEDaEfVjCoThFdyRWJZEYVJBOJBRfhgJk/i56V8UkJHo7w5SHyTul6UmeIebwdxa8HOb8MiYx5vZvlXyGMCT22QaJPJwP5dRcxbBQrAx/tcMhSxRsOZ3J7n12bk+SdbJVXiMtw50+YhRz+Ki085EyzEMPi6/f6zOGkaVW0VUO4b/J/CjJd+CexEIgLLW8NamYBMqJk= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXJQNnZEUWVLY200ZnVDQTNNNVMxU2loVDJkTTJyMW9TcndTWnVJSytudlZV?= =?utf-8?B?akdrU2NHNnpkaTZCTUJxS0RDSUxTTWpvTEtoRWFqa0poM3lhRmJoTEJuOVN1?= =?utf-8?B?WTBnT25sYkJWdU4zTGZvbXozOVpKcUdldzcwNHRyemo5dVFOc2pXZGFtR3ZF?= =?utf-8?B?Yy9TL3I5WFYzakV3RkRnalVYcFdBRW1KNzQ4V1lOYXdoTTZqMWRUNWErVGNh?= =?utf-8?B?c1ZCbEZ4MFFaQmJwTEQyc01GWERhcElTVHJDY3pKMnkyWld0bmtSam0wRGF6?= =?utf-8?B?QmRLSmVLTkFBck1JWEw0WmpPMEVyK243eUhpWjdpbUxZanU4UFhReGF3eGRV?= =?utf-8?B?QnYySFlhVmtUZk4wRzZLSXpaTm8vdE15YnpjUmxEd2dXZ0hVbFg1VTh4dkI5?= =?utf-8?B?cXl4ejF3bFNOMklESWNPT1ZaYkpQNEFJWnpOR1F0UW1TSy9xQ3ZLNDdDSTRG?= =?utf-8?B?Z3FacmZQcVlqNDRLdHFpRTlkZE1TU1RWZThDZUVnLzRLb2prSG1JUFRtbTNX?= =?utf-8?B?VkpNbzNlM2FoZDVCZ0FDZFloNmNCVkdXQXNpRG9NRUVjaEd2ZnJ1aGVyWUJ3?= =?utf-8?B?VzdZNVpyM3pSR2xTZ3Z2VlJrTnhzS055T25pNVdOMGdWdGVhc3FDTkFvbU04?= =?utf-8?B?ZE0xSlhXYU5oazJlMHhHWExGbFNiQUpwcXlLKzVvSm9pVGV1K21vNklBRWJi?= =?utf-8?B?NWhBWWx1bWovY3hzYWJlMWRFN2tDYm85djVhV01vV3AzNjlVQ0NLR2JpSWN3?= =?utf-8?B?NTZUMmVuOVlrOGpsRDZSTDBzbGQ0TytuNHFjZGhHSWpjTnVSVkpvY3VPVUFh?= =?utf-8?B?WUhlQjQ4QmxsQW80OWdWVTZYM0hjb3VtSFNVUFQvblM1ZlVsLzhXdnQzMnB2?= =?utf-8?B?VU9Ba0wxL1ZzanRVay84aHpUeHMvMXBuK0M4WFNTSEJvTDhzeDhEVWxCNSs1?= =?utf-8?B?VlpVOHFyRjV4ak1GdE5qcUVJaDNLaFB4QVlBVGhxK1pEVzVsa1N3NFhsUndK?= =?utf-8?B?dGlaVVVETkgraDlETzNLMHdVTlBEUDFPcWxPZnB1bVZqMTdtVytMZFRGS2dk?= =?utf-8?B?cU8rMFVTdDBwK0JtZUYxNFNFWitoZVVrbWZTVkdJQjlnNm14SHRXM0NXbG1R?= =?utf-8?B?TnhXOUhFOHIxOTAxWUJpaVdxRk1lYmF4T1pOckZ5dmk1b3ZiNGlHQXhFRisy?= =?utf-8?B?M1Z2dUEyRmJxSFlqOU9ONWFkVUFQYzBPc2c4K3dtYU5SNWl4MG03UHUvNitR?= =?utf-8?B?Ujd1UXFzOTZOMW15ajNBTEQ3SDNaRlduU2ZURDFhQnBrY29WNEJuVVZ2UVVn?= =?utf-8?B?Y1FaZmNyeXJKV3pkUnVoYVBTSzJSeFJlNE4vYy9lWmh5eHdPcU9KeE9XcWh5?= =?utf-8?B?S3V2dWEyMXVuQmlYQ3FtQStRODVuOHpIclczS3VYaUQ0T0Q3SFFCNEtkS0ta?= =?utf-8?B?RnY3aUZGM2NON2RhbFBmYlBFdjJ0WURDODc3M2tuaUpqSFcrRzRHSk5aRXN2?= =?utf-8?B?M3RudXhpU3I0RFl2SkVRL1JjT1UyOEM0dStWcDdvTkJ3ZFRQZ1Ric1B4VnBp?= =?utf-8?B?ajVKYVo3Um5vRFJQOE00R2hiZklXSzFiT3ZMN1FtcE1HVG10enBsZ1JJQldu?= =?utf-8?B?bWZ4YWdWY2VPZVNNZzhYRUl5T21FeDZVeml4Y2VMZTFKbmRUTUpJZGdjZ0RO?= =?utf-8?B?YUM4Q2xQWit1TzlUZ05tQTRsNnBzYTRVc2lIRGRubFlQZWl2cFdxc2ZiTWFz?= =?utf-8?B?cm12N0ZqdHcxRUUwYStOSTRFOFpadFIzVE9tM0xZMEk2bU5HNHhzbUhNUEpK?= =?utf-8?B?endFRXM3QmI4bkxDd0pNczBNSU5zU2Rram5WT1M5L29pcXJhTzVvVjJnVnBH?= =?utf-8?B?WUVoSUc4RW5iM21mZFEydllzNGZzMEtsOGJQTGNJbzlIU0lDYjV6dkNGSmVS?= =?utf-8?B?VjVEQXZJRTZ6K2w2ZFdLc2J0N1BpaDJ0c0FaaXAxRHM3MmUvVGlJbkNVNHBB?= =?utf-8?B?VHZIdmgydGFWWm02eEFVSG5JamVyM2Z5RDFESXV4NHUyK05LUXQ4cDBYL0JP?= =?utf-8?B?Z1lMYU9qUkM3SEtWRnJaY1U2TjZJT2R6Nkw1Rk50b1hERmlxNWZkRi9JeE1G?= =?utf-8?Q?x25XB4p5NbB6ZgV/MgGQPkThT?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1653827b-2288-4714-2eba-08dc3f847bc4 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 15:29:02.7371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mNrJNaee4gEjvZuIczyG5CPdnth36hR+McGgAfX2I6xGoRdAj/8PIErFw58JcEGVVrAyOzRM1HrkqtYU8wLwnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6480 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gDgCW6p8PgR1ObYtzpHUt3GDx7686176AA= Content-Type: multipart/alternative; boundary="------------vF2MPdPBHDb0uoGoOAWSf2T6" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Cmn2W3Zr; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------vF2MPdPBHDb0uoGoOAWSf2T6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Narinder,     Patch looks good with minor comments inline. Thanks AbduL On 18-01-2024 06:48, Narinder Dhillon via groups.io wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > From: Narinder Dhillon > > This patch provides SMC call needed by Odyssey to determine size > of available memory. > > Signed-off-by: Narinder Dhillon > --- > Silicon/Marvell/Library/SmcLib/SmcLib.c | 24 +++++++++++++++ > Silicon/Marvell/Library/SmcLib/SmcLib.inf | 29 +++++++++++++++++++ > .../Include/IndustryStandard/SmcLib.h | 28 ++++++++++++++++++ > 3 files changed, 81 insertions(+) > create mode 100644 Silicon/Marvell/Library/SmcLib/SmcLib.c > create mode 100644 Silicon/Marvell/Library/SmcLib/SmcLib.inf > create mode 100644 Silicon/Marvell/MarvellSiliconPkg/Include/IndustryStandard/SmcLib.h > > diff --git a/Silicon/Marvell/Library/SmcLib/SmcLib.c b/Silicon/Marvell/Library/SmcLib/SmcLib.c > new file mode 100644 > index 0000000000..0280983dd0 > --- /dev/null > +++ b/Silicon/Marvell/Library/SmcLib/SmcLib.c > @@ -0,0 +1,24 @@ > +/** @file > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +*https://spdx.org/licenses > +* > +* Copyright (C) 2023 Marvell > +* > +* Source file for Marvell SMC Interface > +* > +**/ > + > +#include > +#include // ArmCallSmc > + > +UINTN SmcGetRamSize ( IN UINTN Node ) > +{ > + ARM_SMC_ARGS ArmSmcArgs; > + > + ArmSmcArgs.Arg0 = MV_SMC_ID_DRAM_SIZE; > + ArmSmcArgs.Arg1 = Node; > + ArmCallSmc (&ArmSmcArgs); > + > + return ArmSmcArgs.Arg0; > +} > diff --git a/Silicon/Marvell/Library/SmcLib/SmcLib.inf b/Silicon/Marvell/Library/SmcLib/SmcLib.inf > new file mode 100644 > index 0000000000..7fc1085b85 > --- /dev/null > +++ b/Silicon/Marvell/Library/SmcLib/SmcLib.inf > @@ -0,0 +1,29 @@ > +#/** @file > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +#https://spdx.org/licenses > +# > +# Copyright (C) 2023 Marvell > +# > +# Marvell SMC Interface library > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010005 > + BASE_NAME = SmcLib > + FILE_GUID = fee427a7-816a-4636-bb81-a640c8288f28 > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = SmcLib [Abdul] New library class is defined here, but didnt the corresponding entry in MarvellSiliconPkg.dec file, there should be an entry in .dec file SmcLib|Include/IndustryStandard/SmcLib.h Also its good to have this patch first, patch 1/7 consumes this library class. > + > +[Sources] > + SmcLib.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + MdePkg/MdePkg.dec > + Silicon/Marvell/MarvellSiliconPkg/MarvellSiliconPkg.dec > + > +[LibraryClasses] > + ArmSmcLib > diff --git a/Silicon/Marvell/MarvellSiliconPkg/Include/IndustryStandard/SmcLib.h b/Silicon/Marvell/MarvellSiliconPkg/Include/IndustryStandard/SmcLib.h > new file mode 100644 > index 0000000000..f2d0bed356 > --- /dev/null > +++ b/Silicon/Marvell/MarvellSiliconPkg/Include/IndustryStandard/SmcLib.h > @@ -0,0 +1,28 @@ > +/** @file > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +*https://spdx.org/licenses > +* > +* Copyright (C) 2023 Marvell > +* > +* Header file for for Marvell SMC Interface > +* > +**/ > + > +#ifndef __SMCLIB_H__ > +#define __SMCLIB_H__ [Abdul] Coding standard prefers the macro should start with alphabet, like SMCLIB_H_ > + > +/* SMC function IDs for Marvell Service queries */ > + > +#define MV_SMC_ID_CALL_COUNT 0xc200ff00 > +#define MV_SMC_ID_UID 0xc200ff01 > + > +#define MV_SMC_ID_VERSION 0xc200ff03 > + > +/* x1 - node number */ > +#define MV_SMC_ID_DRAM_SIZE 0xc2000301 > + > + > +UINTN SmcGetRamSize (IN UINTN Node); > + > +#endif > -- > 2.34.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116524): https://edk2.groups.io/g/devel/message/116524 Mute This Topic: https://groups.io/mt/103800151/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------vF2MPdPBHDb0uoGoOAWSf2T6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Narinder,

    Patch looks good with minor comments inline.

Thanks

AbduL

On 18-01-2024 06:48, Narinder Dhillon via groups.io wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


From: Narinder Dhillon <ndhillon@marvell.com>

This patch provides SMC call needed by Odyssey to determine size
of available memory.

Signed-off-by: Narinder Dhillon <ndhillon@marvell.com>
---
 Silicon/Marvell/Library/SmcLib/SmcLib.c       | 24 +++++++++++++++
 Silicon/Marvell/Library/SmcLib/SmcLib.inf     | 29 +++++++++++++++++++
 .../Include/IndustryStandard/SmcLib.h         | 28 ++++++++++++++++++
 3 files changed, 81 insertions(+)
 create mode 100644 Silicon/Marvell/Library/SmcLib/SmcLib.c
 create mode 100644 Silicon/Marvell/Library/SmcLib/SmcLib.inf
 create mode 100644 Silicon/Marvell/MarvellSiliconPkg/Include/IndustryStandard/SmcLib.h

diff --git a/Silicon/Marvell/Library/SmcLib/SmcLib.c b/Silicon/Marvell/Library/SmcLib/SmcLib.c
new file mode 100644
index 0000000000..0280983dd0
--- /dev/null
+++ b/Silicon/Marvell/Library/SmcLib/SmcLib.c
@@ -0,0 +1,24 @@
+/** @file
+*
+* SPDX-License-Identifier: BSD-2-Clause-Patent
+* https://spdx.org/licenses
+*
+* Copyright (C) 2023 Marvell
+*
+* Source file for Marvell SMC Interface
+*
+**/
+
+#include <IndustryStandard/SmcLib.h>
+#include <Library/ArmSmcLib.h>  // ArmCallSmc
+
+UINTN SmcGetRamSize ( IN UINTN Node )
+{
+  ARM_SMC_ARGS ArmSmcArgs;
+
+  ArmSmcArgs.Arg0 = MV_SMC_ID_DRAM_SIZE;
+  ArmSmcArgs.Arg1 = Node;
+  ArmCallSmc (&ArmSmcArgs);
+
+  return ArmSmcArgs.Arg0;
+}
diff --git a/Silicon/Marvell/Library/SmcLib/SmcLib.inf b/Silicon/Marvell/Library/SmcLib/SmcLib.inf
new file mode 100644
index 0000000000..7fc1085b85
--- /dev/null
+++ b/Silicon/Marvell/Library/SmcLib/SmcLib.inf
@@ -0,0 +1,29 @@
+#/** @file
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+# https://spdx.org/licenses
+#
+# Copyright (C) 2023 Marvell
+#
+# Marvell SMC Interface library
+#
+#**/
+
+[Defines]
+  INF_VERSION                    = 0x00010005
+  BASE_NAME                      = SmcLib
+  FILE_GUID                      = fee427a7-816a-4636-bb81-a640c8288f28
+  MODULE_TYPE                    = DXE_DRIVER
+  VERSION_STRING                 = 1.0
+  LIBRARY_CLASS                  = SmcLib

[Abdul] New library class is defined here, but didnt the corresponding entry in MarvellSiliconPkg.dec file, there should be an entry in .dec file

SmcLib|Include/IndustryStandard/SmcLib.h

Also its good to have this patch first, patch 1/7 consumes this library class. 

+
+[Sources]
+  SmcLib.c
+
+[Packages]
+  ArmPkg/ArmPkg.dec
+  MdePkg/MdePkg.dec
+  Silicon/Marvell/MarvellSiliconPkg/MarvellSiliconPkg.dec
+
+[LibraryClasses]
+  ArmSmcLib
diff --git a/Silicon/Marvell/MarvellSiliconPkg/Include/IndustryStandard/SmcLib.h b/Silicon/Marvell/MarvellSiliconPkg/Include/IndustryStandard/SmcLib.h
new file mode 100644
index 0000000000..f2d0bed356
--- /dev/null
+++ b/Silicon/Marvell/MarvellSiliconPkg/Include/IndustryStandard/SmcLib.h
@@ -0,0 +1,28 @@
+/** @file
+*
+* SPDX-License-Identifier: BSD-2-Clause-Patent
+* https://spdx.org/licenses
+*
+* Copyright (C) 2023 Marvell
+*
+* Header file for for Marvell SMC Interface
+*
+**/
+
+#ifndef __SMCLIB_H__
+#define __SMCLIB_H__
[Abdul] Coding standard prefers the macro should start with alphabet, like SMCLIB_H_
+
+/* SMC function IDs for Marvell Service queries */
+
+#define MV_SMC_ID_CALL_COUNT              0xc200ff00
+#define MV_SMC_ID_UID                     0xc200ff01
+
+#define MV_SMC_ID_VERSION                 0xc200ff03
+
+/* x1 - node number */
+#define MV_SMC_ID_DRAM_SIZE               0xc2000301
+
+
+UINTN SmcGetRamSize (IN UINTN Node);
+
+#endif
--
2.34.1
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#116524) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------vF2MPdPBHDb0uoGoOAWSf2T6--