Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header

["Laszlo Ersek" <lersek@redhat.com>]

On 06/09/21 14:18, Dov Murik wrote:
> Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the
> ground to add a warning about the incompatibility with boot verification
> process.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
> ---
>  OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c
> index 1177582ab051..dc9018f4333b 100644
> --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c
> +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c
> @@ -2,6 +2,9 @@
>    X86 specific implementation of QemuLoadImageLib library class interface
>    with support for loading mixed mode images and non-EFI stub images
>  
> +  Note that this implementation reads the cmdline (and possibly kernel, setup
> +  data, and initrd in the legacy boot mode) from fw_cfg directly.
> +
>    Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
>    Copyright (c) 2020, ARM Ltd. All rights reserved.<BR>
>  
> 

(drive-by comment, no capacity for more atm):

please update the INF file's comment at the top similarly

Thanks
Laszlo