From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.8750.1623249593211249252 for ; Wed, 09 Jun 2021 07:39:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Y5PWq5Ix; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623249592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RaeUyQcciTNzpcvIs2i3ROKFbXTRgGkeitjAZ4+uvrw=; b=Y5PWq5Ixwv0Os1wXcD8zt+Heh6aUez96Ikvem+pkW7vX8gJajfB0o/UDYpT5ShE9dYD7ms HV8fG7pwtqxwyNJrA5DhHbv/SdxgO0uAiC0tWVheFsAQlsMc0Eupos0RMOQ9YWGFAdBDD2 LY2CVyJKRERLF553ieGKaXSl0A1o654= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-z904NWI_MEWMu-AKJ9G-Jg-1; Wed, 09 Jun 2021 10:39:48 -0400 X-MC-Unique: z904NWI_MEWMu-AKJ9G-Jg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C03428015C6; Wed, 9 Jun 2021 14:39:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47C3B5C1D1; Wed, 9 Jun 2021 14:39:44 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header To: devel@edk2.groups.io, dovmurik@linux.ibm.com Cc: Ard Biesheuvel , Jordan Justen , James Bottomley , Tobin Feldman-Fitzthum References: <20210609121828.1884825-1-dovmurik@linux.ibm.com> <20210609121828.1884825-4-dovmurik@linux.ibm.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 9 Jun 2021 16:39:42 +0200 MIME-Version: 1.0 In-Reply-To: <20210609121828.1884825-4-dovmurik@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/09/21 14:18, Dov Murik wrote: > Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the > ground to add a warning about the incompatibility with boot verification > process. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: James Bottomley > Cc: Tobin Feldman-Fitzthum > Signed-off-by: Dov Murik > --- > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > index 1177582ab051..dc9018f4333b 100644 > --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > @@ -2,6 +2,9 @@ > X86 specific implementation of QemuLoadImageLib library class interface > with support for loading mixed mode images and non-EFI stub images > > + Note that this implementation reads the cmdline (and possibly kernel, setup > + data, and initrd in the legacy boot mode) from fw_cfg directly. > + > Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> Copyright (c) 2020, ARM Ltd. All rights reserved.
> > (drive-by comment, no capacity for more atm): please update the INF file's comment at the top similarly Thanks Laszlo