From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.74]) by mx.groups.io with SMTP id smtpd.web11.6639.1639750510026784907 for ; Fri, 17 Dec 2021 06:15:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=8icfjJ6+; spf=pass (domain: arm.com, ip: 40.107.8.74, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eP76rLVfVn57T8/W6AroTVE9rUHUckAId6hCep+2EMA=; b=8icfjJ6+tpZcFB4tXxavfKiM00WI6FhXDXoCiHqUcesQt+267Nhono2PnZDvbFW3OGdJa3p22QgfoLeRcjwljH9LycJCD0qcsZtg7o2bdFQJVgZjaYC4VK8ej68UBUTGN4l/Z9xDrRlBkDcI2mJSTw9jxBw9HRNWMbv2lQcQcY4= Received: from AM5PR0602CA0013.eurprd06.prod.outlook.com (2603:10a6:203:a3::23) by DBBPR08MB6107.eurprd08.prod.outlook.com (2603:10a6:10:200::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec 2021 14:15:05 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::50) by AM5PR0602CA0013.outlook.office365.com (2603:10a6:203:a3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend Transport; Fri, 17 Dec 2021 14:15:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:15:05 +0000 Received: ("Tessian outbound 157533e214a9:v110"); Fri, 17 Dec 2021 14:15:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9bdae17512593738 X-CR-MTA-TID: 64aa7808 Received: from cd1a4d784554.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0E0610A3-4FEF-4F01-B657-2AC77BCB86E2.1; Fri, 17 Dec 2021 14:14:58 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd1a4d784554.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Dec 2021 14:14:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TnQUv0jiy4kgDkaw2r1kv+zEYeCVhI71X4iyVJobYe0Jpq0GYbhBzrioWwTxw0ZgGcehDRFq1f4io9jsxF4LzbuxBIsML4O2zKRXztDOi+J7DRWNd0WnortQNXmgK8Riwv4wkEDW0UBuVK28n8n+GSbAiWsaoDmHGJVZScdtUAFaO94UKTtPS+J76+K0jmCqK+nBx+XeoZm7fYtoUKLuYMBZFW7cci6HJEO+294booHSk+A+z+/G2W+QJDkvVP2cCqbAaZ0Bi0fYydN5FpoqWMX/UEfMX4lc6E90yIqCkZUrGSXurdC61cpWe3RK02GFChprp0hHBEUbInS0ZfStSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eP76rLVfVn57T8/W6AroTVE9rUHUckAId6hCep+2EMA=; b=Vz9VOGfZ4F2BPA94EfEYl5r/Sm17KMiCVCm2F2R81fw+GGGSvFGfaimvaWTZ6iv/a8NDjqlNjPWWqFiXAiCJhETqCccWPCUbogcoWHPDzmbVa5ZTRHwzx2N1CX6sLgX7EanRkr08iCsKOmRBh7SD5eAls9NAg4A2kZeRDhLxOt6JwJKG4waiNIzAZmm24xycH9KnOGI/po9UzjQcC+0FHIEVatyeZurF5iHc0bQfCXzSh/4593w5UL7PPYe8wQHLz+682rO5IqlRRtOWEJsmpFKim5iBTpKS4JhqO4FVdqw51KdKNTGvOtf98TD8X1JNcZ9RHru4DsvZqnp5JQoKPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eP76rLVfVn57T8/W6AroTVE9rUHUckAId6hCep+2EMA=; b=8icfjJ6+tpZcFB4tXxavfKiM00WI6FhXDXoCiHqUcesQt+267Nhono2PnZDvbFW3OGdJa3p22QgfoLeRcjwljH9LycJCD0qcsZtg7o2bdFQJVgZjaYC4VK8ej68UBUTGN4l/Z9xDrRlBkDcI2mJSTw9jxBw9HRNWMbv2lQcQcY4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6693.eurprd08.prod.outlook.com (2603:10a6:20b:39c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 17 Dec 2021 14:14:55 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Fri, 17 Dec 2021 14:14:55 +0000 Subject: Re: [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001 To: Pierre.Gondois@arm.com, devel@edk2.groups.io, nd References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-6-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: Date: Fri, 17 Dec 2021 14:15:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211124162330.236813-6-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0317.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO4P123CA0317.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::16) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Fri, 17 Dec 2021 14:14:55 +0000 X-MS-Office365-Filtering-Correlation-Id: 8c1f71cf-03d5-4524-f3c5-08d9c1679fb0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6693:|AM5EUR03FT015:EE_|DBBPR08MB6107:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /yzTpp/MEJmcRxNGqr+qgu5MVYfDVbEU8s/L3oNdPx/ronZeJEQRZ8tF2vYqF4e7G9+C/zVJgHNY2xbVxKcw8qaPIMnbg+ff6p++gquKph0gvhqUZOGPUMRGcMePB6rcVe2MPR6svgovNFUcbWrvkNmb3tHq4CmdihjpA7VXFm0pS5wUPnJcRCx94um47AuGAugfuY6Jj+4DkqMB+u3owVvELtHB67Esb5Zo2AVkouGW3ACexA06GoSYMN1nHCaJpG/cTaxcRwx+CL24mEuAGtV2eSDK/xMb2BveNFsiPqXjWUupNzsmttl/jBaMiPTlPA8dYNh1Kv/TYQzPHoJ5rWMWf3DFz84/8a1vzYfnEALz7Ww5gLIzV3wpfXfalOyADZEerGLD0iGqwjhGu8G4cUlXdfP7tCuWw9ImK9bHFuJ8HapyicDyHZxIeTxOHjZm2d5hLZvBqsS8KWApxWJVlO7C5OCTxHMknExk9QzdCQ3yw1yre3MNDungZgCEWm/mpEofaYTV2ageT9yAqMmAZQsxJOZWNFTEkRxFCZVx/HvKKB1c1azS8xR3reDs9wfojEV4aVS5ljO23wffbTHM1OqroTXO6O7Zdr6lxHujwMCwUmI4VhLjb1jqy+TeuHxtMUkvAnxr8dXCAoCbpCdi/805GPyGWP6APgZ7+acyP4I199Y6LwJYbZ8HjAj4eJYAEX4OwB9tCBY+XUaGIz1ombQae+Hzd4+nYE6Zheh433cEZxeFRN+BYr9QoNcQgAe6BZ7P99oAuVLVjOAWPtq/hw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2616005)(186003)(16576012)(36756003)(508600001)(2906002)(53546011)(6666004)(6486002)(5660300002)(66556008)(6636002)(83380400001)(8936002)(19627235002)(66476007)(316002)(31686004)(52116002)(6862004)(37006003)(26005)(38350700002)(31696002)(66946007)(8676002)(86362001)(44832011)(956004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6693 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a8a68024-10c0-4875-0c06-08d9c16799dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 20wwHLrsaRUty+jxgFSJYbcCdPWoTzPODYL+A4iMYFif9bZW37XZ04jeormNz6xRzU3/V0/o945+EaqbIRJ8CLOVFNRORTiyXr+0WarWqSMiJDuMWRKCrZ34YczYk4UXRxUicDruWi9yEmz/IIlwp664oA0UrUXgDVLZFuJeI2ZLA0xtzFBrn5MPwnVnkOaV1UCIj0Uhf6ROIFs+0ekXcTwuNqcrrCajwoK2v6sjb4d1R9mPsoyYjC7bqmOxDWkGxYYLZb1evtuwhghXHenu2aS+IOyOEOYpS6yuB6qYU0FyEDnKEdSN6HN92hO7lfS3NNZYuPexp23bvaBsKGFtMKvMvCV2YN6g+jJjZzR+MGgoFMQ7bILQ0ij17YqJWT3iqBypeUn3BspnPJ2MEL2W4TJgBoQrOk5uqV2o7YdUGlxLOMqdIBtlQI6i5ua+cyksxlTOUsKPgKAyBz065qkAPEAca1p2qbUiv003o8U6deGBKcMgfsf3mkuYxqUqpXL/ZmJ52oANdoM9jTM3I6+m6SzrnXsI7xXXQTByjcb9hIPoJIYfxhoHAbpLAd86KcJTJhUxNhWSjisgxVz14uu7ERZUr2AYIG88ffPplcXX5AoKb3whhd0xCgadzY13LUX0X/oI43bB4y9jZnVcVA2oeJnShBQ/Y2c5I74t8TSZF4lw9U5Wytvm5ndD/GRny6Mpf1Es/VU2cUP/7fxT5HPJrzVdRF3C8v+6Kq+Q9E5xuGA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(19627235002)(31686004)(6862004)(8936002)(53546011)(6486002)(31696002)(6636002)(47076005)(70586007)(70206006)(508600001)(186003)(8676002)(83380400001)(36860700001)(2906002)(82310400004)(26005)(956004)(36756003)(44832011)(37006003)(16576012)(316002)(356005)(86362001)(5660300002)(336012)(6666004)(81166007)(2616005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 14:15:05.3977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c1f71cf-03d5-4524-f3c5-08d9c1679fb0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6107 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > This patch fixes the following Ecc reported error: > 'TAB' character is not allowed in source code, > please replace each 'TAB' with two spaces. > > The patch also format and document the InstallStructures > function to comply to edk2 coding style. > > Signed-off-by: Pierre Gondois > --- > .../SmbiosPlatformDxe/SmbiosPlatformDxe.c | 38 ++++++++++--------- > .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h | 4 +- > 2 files changed, 23 insertions(+), 19 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b= /Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index ac18b16ca676..a5a675b2a613 100644 > --- a/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -743,36 +743,40 @@ InstallMemoryStructure ( > } > > /** > - Install a whole table worth of structructures > + Install a whole table worth of structures. > > - @parm > + @param [in] Smbios Smbios protocol. > + @param [in] DefaultTables Default Smbios tables. > + > + @retval EFI_SUCCESS Record was added. > + @retval EFI_OUT_OF_RESOURCES Record was not added. > + @retval EFI_ALREADY_STARTED The SmbiosHandle passed in was already i= n use. > **/ > EFI_STATUS > InstallStructures ( > - IN EFI_SMBIOS_PROTOCOL *Smbios, > - IN CONST VOID *DefaultTables[] > + IN EFI_SMBIOS_PROTOCOL *Smbios, > + IN CONST VOID *DefaultTables[] > ) > { > EFI_STATUS Status =3D EFI_SUCCESS; > EFI_SMBIOS_HANDLE SmbiosHandle; > + UINTN TableEntry; > > - int TableEntry; > - for ( TableEntry=3D0; DefaultTables[TableEntry] !=3D NULL; TableEntr= y++) > - { > - SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEntr= y])->Handle; > - Status =3D Smbios->Add ( > - Smbios, > - NULL, > - &SmbiosHandle, > - (EFI_SMBIOS_TABLE_HEADER*) DefaultTables[TableEntry] > - ); > - if (EFI_ERROR(Status)) > - break; > + for (TableEntry =3D 0; DefaultTables[TableEntry] !=3D NULL; TableEnt= ry++) { > + SmbiosHandle =3D ((EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEnt= ry])->Handle; > + Status =3D Smbios->Add ( > + Smbios, > + NULL, > + &SmbiosHandle, > + (EFI_SMBIOS_TABLE_HEADER*)DefaultTables[TableEn= try] > + ); > + if (EFI_ERROR(Status)) { > + break; > + } > } > return Status; > } > > - > /** > Install all structures from the DefaultTables structure > > diff --git a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h= b/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h > index 601714c94387..e50c458f8c3a 100644 > --- a/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h > +++ b/Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h > @@ -45,7 +45,7 @@ Lan9118RawMmioRead32( > UINTN Delay > ); > #define Lan9118MmioRead32(a) \ > - Lan9118RawMmioRead32(a, a ## _RD_DELAY) > + Lan9118RawMmioRead32(a, a ## _RD_DELAY) > > UINT32 > Lan9118RawMmioWrite32( > @@ -54,7 +54,7 @@ Lan9118RawMmioWrite32( > UINTN Delay > ); > #define Lan9118MmioWrite32(a, v) \ > - Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY) > + Lan9118RawMmioWrite32(a, v, a ## _WR_DELAY) > > /* ------------------ MAC CSR Access ------------------- */ > > -- > 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.