From: Laszlo Ersek <lersek@redhat.com>
To: Qin Long <qin.long@intel.com>, edk2-devel@lists.01.org
Cc: ting.ye@intel.com, jiaxin.wu@intel.com,
ard.biesheuvel@linaro.org, glin@suse.com, ronald.cron@arm.com,
Moso.Lee@citrix.com, thomas.palmer@hpe.com
Subject: Re: [PATCH v2 07/11] CryptoPkg: Clean-up CRT Library Wrapper.
Date: Thu, 23 Mar 2017 19:34:43 +0100 [thread overview]
Message-ID: <fcd4a0e4-8868-a0a0-a7fe-f2f6e0a250c1@redhat.com> (raw)
In-Reply-To: <20170323131932.6168-8-qin.long@intel.com>
On 03/23/17 14:19, Qin Long wrote:
> Cleaning-up CRT Library Wrapper for the third-party cryptography
> library building. The changes includes
> 1. Rename OpenSslSupport.h to CrtLibSupport.h for future alternative
> crypto provider support.
> 2. Remove all un-referenced CRT APIs and headers.
>
> (NOTE: More cleans-up could be possible after OpenSSL integrate the
> extra PR request: https://github.com/openssl/openssl/pull/2961)
>
> Cc: Ting Ye <ting.ye@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Gary Lin <glin@suse.com>
> Cc: Ronald Cron <ronald.cron@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Qin Long <qin.long@intel.com>
> ---
> CryptoPkg/Include/CrtLibSupport.h | 193 ++++++++++++++
> CryptoPkg/Include/OpenSslSupport.h | 292 ---------------------
> CryptoPkg/Include/arpa/inet.h | 16 --
> CryptoPkg/Include/assert.h | 7 +-
> CryptoPkg/Include/ctype.h | 7 +-
> CryptoPkg/Include/dirent.h | 16 --
> CryptoPkg/Include/errno.h | 7 +-
> CryptoPkg/Include/limits.h | 7 +-
> CryptoPkg/Include/malloc.h | 16 --
> CryptoPkg/Include/math.h | 16 --
> CryptoPkg/Include/memory.h | 7 +-
> CryptoPkg/Include/netdb.h | 16 --
> CryptoPkg/Include/netinet/in.h | 16 --
> CryptoPkg/Include/sgtty.h | 16 --
> CryptoPkg/Include/signal.h | 16 --
> CryptoPkg/Include/stdarg.h | 7 +-
> CryptoPkg/Include/stddef.h | 6 +-
> CryptoPkg/Include/stdio.h | 7 +-
> CryptoPkg/Include/stdlib.h | 7 +-
> CryptoPkg/Include/string.h | 7 +-
> CryptoPkg/Include/strings.h | 6 +-
> CryptoPkg/Include/sys/ioctl.h | 16 --
> CryptoPkg/Include/sys/param.h | 16 --
> CryptoPkg/Include/sys/socket.h | 16 --
> CryptoPkg/Include/sys/stat.h | 16 --
> CryptoPkg/Include/sys/time.h | 7 +-
> CryptoPkg/Include/sys/times.h | 16 --
> CryptoPkg/Include/sys/types.h | 7 +-
> CryptoPkg/Include/sys/un.h | 16 --
> CryptoPkg/Include/syslog.h | 6 +-
> CryptoPkg/Include/time.h | 6 +-
> CryptoPkg/Include/unistd.h | 6 +-
> CryptoPkg/Library/BaseCryptLib/InternalCryptLib.h | 4 +-
> .../BaseCryptLib/SysCall/BaseMemAllocation.c | 5 +-
> .../BaseCryptLib/SysCall/ConstantTimeClock.c | 6 +-
> .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 185 ++++++-------
> .../Library/BaseCryptLib/SysCall/HelperWrapper.c | 54 ----
> .../BaseCryptLib/SysCall/RuntimeMemAllocation.c | 3 +-
> .../Library/BaseCryptLib/SysCall/TimerWrapper.c | 4 +-
> 39 files changed, 346 insertions(+), 731 deletions(-)
> create mode 100644 CryptoPkg/Include/CrtLibSupport.h
> delete mode 100644 CryptoPkg/Include/OpenSslSupport.h
> delete mode 100644 CryptoPkg/Include/arpa/inet.h
> delete mode 100644 CryptoPkg/Include/dirent.h
> delete mode 100644 CryptoPkg/Include/malloc.h
> delete mode 100644 CryptoPkg/Include/math.h
> delete mode 100644 CryptoPkg/Include/netdb.h
> delete mode 100644 CryptoPkg/Include/netinet/in.h
> delete mode 100644 CryptoPkg/Include/sgtty.h
> delete mode 100644 CryptoPkg/Include/signal.h
> delete mode 100644 CryptoPkg/Include/sys/ioctl.h
> delete mode 100644 CryptoPkg/Include/sys/param.h
> delete mode 100644 CryptoPkg/Include/sys/socket.h
> delete mode 100644 CryptoPkg/Include/sys/stat.h
> delete mode 100644 CryptoPkg/Include/sys/times.h
> delete mode 100644 CryptoPkg/Include/sys/un.h
> delete mode 100644 CryptoPkg/Library/BaseCryptLib/SysCall/HelperWrapper.c
Tested-by: Laszlo Ersek <lersek@redhat.com>
(Tested as described in
<http://mid.mail-archive.com/4410fa53-b0e4-d64a-7b95-8a430a4c7b06@redhat.com>.)
Thanks!
Laszlo
next prev parent reply other threads:[~2017-03-23 18:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 13:19 [PATCH v2 00/11] Upgrade CryptoPkg to use the OpenSSL 1.1.0xx/stable release Qin Long
2017-03-23 13:19 ` [PATCH v2 01/11] CryptoPkg/OpensslLib: Update INF files to support OpenSSL-1.1.0x build Qin Long
2017-03-23 18:27 ` Laszlo Ersek
2017-03-27 9:40 ` Gary Lin
2017-03-23 13:19 ` [PATCH v2 02/11] CryptoPkg: Update .gitignore for OpenSSL source masking Qin Long
2017-03-23 18:28 ` Laszlo Ersek
2017-03-23 13:19 ` [PATCH v2 03/11] CryptoPkg/OpensslLib: Remove patch file and installation scripts Qin Long
2017-03-23 18:28 ` Laszlo Ersek
2017-03-23 13:19 ` [PATCH v2 04/11] CryptoPkg/OpensslLib: Add new Perl script for file list generation Qin Long
2017-03-23 18:29 ` Laszlo Ersek
2017-03-23 13:19 ` [PATCH v2 05/11] CryptoPkg/OpensslLib: Add new OpenSSL-HOWTO document Qin Long
2017-03-23 18:31 ` Laszlo Ersek
2017-03-27 9:58 ` Gary Lin
2017-03-23 13:19 ` [PATCH v2 06/11] CryptoPkg: Fix handling of &strcmp function pointers Qin Long
2017-03-23 18:33 ` Laszlo Ersek
2017-03-27 9:41 ` Gary Lin
2017-03-23 13:19 ` [PATCH v2 07/11] CryptoPkg: Clean-up CRT Library Wrapper Qin Long
2017-03-23 18:34 ` Laszlo Ersek [this message]
2017-03-27 9:42 ` Gary Lin
2017-03-30 17:33 ` Laszlo Ersek
2017-03-31 2:06 ` Long, Qin
2017-03-23 13:19 ` [PATCH v2 08/11] CryptoPkg: Add extra build option to disable VS build warning Qin Long
2017-03-23 13:19 ` [PATCH v2 09/11] CryptoPkg: Update HMAC Wrapper with opaque HMAC_CTX object Qin Long
2017-03-23 18:37 ` Laszlo Ersek
2017-03-27 9:56 ` Gary Lin
2017-03-23 13:19 ` [PATCH v2 10/11] CryptoPkg: Update PK Cipher Wrappers work with opaque objects Qin Long
2017-03-23 18:38 ` Laszlo Ersek
2017-03-27 9:44 ` Gary Lin
2017-03-23 13:19 ` [PATCH v2 11/11] CryptoPkg/TlsLib: Update TLS Wrapper to align with OpenSSL changes Qin Long
2017-03-23 16:23 ` Palmer, Thomas
2017-03-24 5:40 ` Wu, Jiaxin
2017-03-23 17:28 ` [PATCH v2 00/11] Upgrade CryptoPkg to use the OpenSSL 1.1.0xx/stable release Laszlo Ersek
2017-03-28 8:19 ` Ye, Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcd4a0e4-8868-a0a0-a7fe-f2f6e0a250c1@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox