From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B029080402 for ; Thu, 23 Mar 2017 11:34:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F3426371B; Thu, 23 Mar 2017 18:34:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0F3426371B Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0F3426371B Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-84.phx2.redhat.com [10.3.116.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id C02D77F3AF; Thu, 23 Mar 2017 18:34:45 +0000 (UTC) To: Qin Long , edk2-devel@lists.01.org References: <20170323131932.6168-1-qin.long@intel.com> <20170323131932.6168-8-qin.long@intel.com> Cc: ting.ye@intel.com, jiaxin.wu@intel.com, ard.biesheuvel@linaro.org, glin@suse.com, ronald.cron@arm.com, Moso.Lee@citrix.com, thomas.palmer@hpe.com From: Laszlo Ersek Message-ID: Date: Thu, 23 Mar 2017 19:34:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170323131932.6168-8-qin.long@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 23 Mar 2017 18:34:48 +0000 (UTC) Subject: Re: [PATCH v2 07/11] CryptoPkg: Clean-up CRT Library Wrapper. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 18:34:47 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/23/17 14:19, Qin Long wrote: > Cleaning-up CRT Library Wrapper for the third-party cryptography > library building. The changes includes > 1. Rename OpenSslSupport.h to CrtLibSupport.h for future alternative > crypto provider support. > 2. Remove all un-referenced CRT APIs and headers. > > (NOTE: More cleans-up could be possible after OpenSSL integrate the > extra PR request: https://github.com/openssl/openssl/pull/2961) > > Cc: Ting Ye > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Gary Lin > Cc: Ronald Cron > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qin Long > --- > CryptoPkg/Include/CrtLibSupport.h | 193 ++++++++++++++ > CryptoPkg/Include/OpenSslSupport.h | 292 --------------------- > CryptoPkg/Include/arpa/inet.h | 16 -- > CryptoPkg/Include/assert.h | 7 +- > CryptoPkg/Include/ctype.h | 7 +- > CryptoPkg/Include/dirent.h | 16 -- > CryptoPkg/Include/errno.h | 7 +- > CryptoPkg/Include/limits.h | 7 +- > CryptoPkg/Include/malloc.h | 16 -- > CryptoPkg/Include/math.h | 16 -- > CryptoPkg/Include/memory.h | 7 +- > CryptoPkg/Include/netdb.h | 16 -- > CryptoPkg/Include/netinet/in.h | 16 -- > CryptoPkg/Include/sgtty.h | 16 -- > CryptoPkg/Include/signal.h | 16 -- > CryptoPkg/Include/stdarg.h | 7 +- > CryptoPkg/Include/stddef.h | 6 +- > CryptoPkg/Include/stdio.h | 7 +- > CryptoPkg/Include/stdlib.h | 7 +- > CryptoPkg/Include/string.h | 7 +- > CryptoPkg/Include/strings.h | 6 +- > CryptoPkg/Include/sys/ioctl.h | 16 -- > CryptoPkg/Include/sys/param.h | 16 -- > CryptoPkg/Include/sys/socket.h | 16 -- > CryptoPkg/Include/sys/stat.h | 16 -- > CryptoPkg/Include/sys/time.h | 7 +- > CryptoPkg/Include/sys/times.h | 16 -- > CryptoPkg/Include/sys/types.h | 7 +- > CryptoPkg/Include/sys/un.h | 16 -- > CryptoPkg/Include/syslog.h | 6 +- > CryptoPkg/Include/time.h | 6 +- > CryptoPkg/Include/unistd.h | 6 +- > CryptoPkg/Library/BaseCryptLib/InternalCryptLib.h | 4 +- > .../BaseCryptLib/SysCall/BaseMemAllocation.c | 5 +- > .../BaseCryptLib/SysCall/ConstantTimeClock.c | 6 +- > .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 185 ++++++------- > .../Library/BaseCryptLib/SysCall/HelperWrapper.c | 54 ---- > .../BaseCryptLib/SysCall/RuntimeMemAllocation.c | 3 +- > .../Library/BaseCryptLib/SysCall/TimerWrapper.c | 4 +- > 39 files changed, 346 insertions(+), 731 deletions(-) > create mode 100644 CryptoPkg/Include/CrtLibSupport.h > delete mode 100644 CryptoPkg/Include/OpenSslSupport.h > delete mode 100644 CryptoPkg/Include/arpa/inet.h > delete mode 100644 CryptoPkg/Include/dirent.h > delete mode 100644 CryptoPkg/Include/malloc.h > delete mode 100644 CryptoPkg/Include/math.h > delete mode 100644 CryptoPkg/Include/netdb.h > delete mode 100644 CryptoPkg/Include/netinet/in.h > delete mode 100644 CryptoPkg/Include/sgtty.h > delete mode 100644 CryptoPkg/Include/signal.h > delete mode 100644 CryptoPkg/Include/sys/ioctl.h > delete mode 100644 CryptoPkg/Include/sys/param.h > delete mode 100644 CryptoPkg/Include/sys/socket.h > delete mode 100644 CryptoPkg/Include/sys/stat.h > delete mode 100644 CryptoPkg/Include/sys/times.h > delete mode 100644 CryptoPkg/Include/sys/un.h > delete mode 100644 CryptoPkg/Library/BaseCryptLib/SysCall/HelperWrapper.c Tested-by: Laszlo Ersek (Tested as described in .) Thanks! Laszlo