From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.67; helo=mail-wm1-f67.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5037221199528 for ; Mon, 17 Dec 2018 02:45:48 -0800 (PST) Received: by mail-wm1-f67.google.com with SMTP id m22so12097593wml.3 for ; Mon, 17 Dec 2018 02:45:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dC5TsUJGYk3NcFKROTnkSQgJ3usH9NhaIxxbBbv3i7A=; b=YR2LutTIeNOWCInzzGmAav+t2ZJ5EPqLmwNsQ/PcsBFhKQllLBNLveAgDInhDaMPyx c1fFJjUkwQujJJNMEFPwLcHVGdd76mJdOK0ICU1s+jt9fxAUn5Hgd51cIrNtxWN9qEQW imsKMGp76YYQL0hZqDCBMnn0z3Bpagc+vimkVTdVnFFp70hUJbUZiIAh3fsB15mSTVGn 0lcIeWiYQH8U++Z71Kelut5LiuaXHBJojl+KxtYd5ODiT3YMilbwUXfUqKfA/gBzMu+k uwW9MawGo65Uugt16APKqJFae/O+O9qoGr3D/BdrnkrY/VjGfdWJkCOauGGQCLEkM1TK xa/w== X-Gm-Message-State: AA+aEWa0lWGEhgoYTvtEB5VceYk2/hsQIK6X7fZVrCm8ZuiUIGj1ZOEi +8/KUvBcaYQ/QQbEE0afEZ13Cg== X-Google-Smtp-Source: AFSGD/WHZdNRS5uIDIFmCSoQ4iAsMjuVoi879r1LkQEAAriycfjvL20q+nKlB21hK5A3OtvCFv/+xw== X-Received: by 2002:a1c:bc82:: with SMTP id m124mr10805238wmf.77.1545043547335; Mon, 17 Dec 2018 02:45:47 -0800 (PST) Received: from [192.168.1.34] (172.red-88-21-202.staticip.rima-tde.net. [88.21.202.172]) by smtp.gmail.com with ESMTPSA id c8sm9802707wrx.42.2018.12.17.02.45.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Dec 2018 02:45:46 -0800 (PST) To: Laszlo Ersek Cc: Shenglei Zhang , edk2-devel@lists.01.org, Michael D Kinney , Jiewen Yao , Liming Gao , Chao Zhang References: <20181211013132.25028-1-shenglei.zhang@intel.com> <14bbe8e4-3361-1150-ba3e-ee2ecd2ff53b@redhat.com> <2687dc25-fa04-6cf6-0393-07520b4e53ed@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Mon, 17 Dec 2018 11:45:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <2687dc25-fa04-6cf6-0393-07520b4e53ed@redhat.com> Subject: Re: [PATCH 0/2] Fix typos in MdePkg and SecurityPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 10:45:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12/17/18 11:27 AM, Laszlo Ersek wrote: > On 12/17/18 11:08, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 12/11/18 2:31 AM, Shenglei Zhang wrote: >>> Change EFI_RETURNING_FROM_EFI_APPLICATOIN to >>> EFI_RETURNING_FROM_EFI_APPLICATION. >>> >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Chao Zhang >>> Cc: Jiewen Yao >>> Shenglei Zhang (2): >>> MdePkg/IndustryStandard: Fix a typo in UefiTcgPlatform.h >>> SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c >>> >>> MdePkg/Include/IndustryStandard/UefiTcgPlatform.h | 2 +- >>> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++-- >>> SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 4 ++-- >>> 3 files changed, 5 insertions(+), 5 deletions(-) >>> >> >> NACK, this change has to be in the same patch to be bisectable. >> >> However, if you resend the same change squashed in a single patch, you >> can directly add my: >> Reviewed-by: Philippe Mathieu-Daudé > > Good catch! Bisectability is important! > > An alternative approach to yours could be: first, introduce the > correctly spelled macro (with the same value); second, update the > references; third, remove the misspelled macro. This would be *slightly* > more idiomatic for edk2, where we tend to avoid cross-package patches, > if we can. TIL "avoid cross-package patches" (for edk2). While Laszlo's alternative looks overkill, it is also perfect =)