From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.760.1649121048947013636 for ; Mon, 04 Apr 2022 18:10:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=Kc6tuSF2; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.46.36]) by linux.microsoft.com (Postfix) with ESMTPSA id A7BD020DFD64; Mon, 4 Apr 2022 18:10:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A7BD020DFD64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1649121048; bh=/niwOmTY3xOoBtYFKP3JQ3eRTOx0PlEQ7lUduS4fjcg=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=Kc6tuSF2dMQMUupm+ZxzKZP7w1QOM1RVEMhjdcOK5EseXK4IByqu/1FdZlh9E6rw4 R8dhccZw/h5vB8odsGJHTiaqNTlv0tE7L5XK56aztlgaVvYgAPt5az92h2dPfKW/RW j3r1mJubMYXk2cM3s80RHbMww48+ZhZPKxXmEQk8= Message-ID: Date: Mon, 4 Apr 2022 21:10:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC From: "Michael Kubacki" To: devel@edk2.groups.io, chasel.chiu@intel.com Cc: "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" References: <20220323012736.9609-1-mikuback@linux.microsoft.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Just another reminder to please merge this patch if there is no further=20 feedback. Thanks, Michael On 4/1/2022 10:12 AM, Michael Kubacki wrote: > Thanks for the review. >=20 > Can you please merge this soon if there are no concerns? >=20 > On 3/23/2022 2:15 AM, Chiu, Chasel wrote: >> >> Reviewed-by: Chasel Chiu >> >>> -----Original Message----- >>> From: mikuback@linux.microsoft.com >>> Sent: Wednesday, March 23, 2022 9:28 AM >>> To: devel@edk2.groups.io >>> Cc: Chiu, Chasel ; Desimone, Nathaniel L >>> ; Gao, Liming >>> ; Dong, Eric >>> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing >>> libraries to [Components] in DSC >>> >>> From: Michael Kubacki >>> >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3619 >>> >>> Adds libraries implemented in MinPlatformPkg to the [Components] >>> section in MinPlatformPkg.dsc so they are included in the package build= . >>> >>> Cc: Chasel Chiu >>> Cc: Nate DeSimone >>> Cc: Liming Gao >>> Cc: Eric Dong >>> Signed-off-by: Michael Kubacki >>> --- >>> =C2=A0 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++++++ >>> =C2=A0 1 file changed, 7 insertions(+) >>> >>> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >>> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >>> index 0f47182c2647..a8373a4ecb37 100644 >>> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >>> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc >>> @@ -211,6 +211,13 @@ [Components] >>> >>> MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull. >>> inf >>> >>> MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead >>> Lib.inf >>> >>> MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri >>> teLib.inf >>> +=C2=A0 MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.in= f >>> + >>> + >>> MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR >>> ea >>> + dLib.inf >>> + >>> MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable >>> Wr >>> + iteLib.inf >>> + >>> MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead >>> Lib >>> + .inf >>> + >>> MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit >>> eL >>> + ib.inf >>> + >>> MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i >>> + nf >>> + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib= . >>> + inf >>> >>> =C2=A0 [BuildOptions] >>> =C2=A0=C2=A0=C2=A0 *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFA= CES >>> --=20 >>> 2.28.0.windows.1 >> >> >> >>=20 >>