* Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
2022-03-23 1:27 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC Michael Kubacki
@ 2022-03-23 6:15 ` Chiu, Chasel
2022-04-01 14:12 ` [edk2-devel] " Michael Kubacki
2022-04-07 0:48 ` Nate DeSimone
2022-04-07 0:54 ` Nate DeSimone
2 siblings, 1 reply; 6+ messages in thread
From: Chiu, Chasel @ 2022-03-23 6:15 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Gao, Liming, Dong, Eric
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Wednesday, March 23, 2022 9:28 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing
> libraries to [Components] in DSC
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619
>
> Adds libraries implemented in MinPlatformPkg to the [Components]
> section in MinPlatformPkg.dsc so they are included in the package build.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index 0f47182c2647..a8373a4ecb37 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -211,6 +211,13 @@ [Components]
>
> MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.
> inf
>
> MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead
> Lib.inf
>
> MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri
> teLib.inf
> + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf
> +
> +
> MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR
> ea
> + dLib.inf
> +
> MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable
> Wr
> + iteLib.inf
> +
> MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead
> Lib
> + .inf
> +
> MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit
> eL
> + ib.inf
> +
> MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i
> + nf
> + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib.
> + inf
>
> [BuildOptions]
> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
2022-03-23 6:15 ` Chiu, Chasel
@ 2022-04-01 14:12 ` Michael Kubacki
2022-04-05 1:10 ` Michael Kubacki
0 siblings, 1 reply; 6+ messages in thread
From: Michael Kubacki @ 2022-04-01 14:12 UTC (permalink / raw)
To: devel, chasel.chiu; +Cc: Desimone, Nathaniel L, Gao, Liming, Dong, Eric
Thanks for the review.
Can you please merge this soon if there are no concerns?
On 3/23/2022 2:15 AM, Chiu, Chasel wrote:
>
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
>
>> -----Original Message-----
>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> Sent: Wednesday, March 23, 2022 9:28 AM
>> To: devel@edk2.groups.io
>> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
>> <nathaniel.l.desimone@intel.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
>> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing
>> libraries to [Components] in DSC
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619
>>
>> Adds libraries implemented in MinPlatformPkg to the [Components]
>> section in MinPlatformPkg.dsc so they are included in the package build.
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>> index 0f47182c2647..a8373a4ecb37 100644
>> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>> @@ -211,6 +211,13 @@ [Components]
>>
>> MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.
>> inf
>>
>> MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead
>> Lib.inf
>>
>> MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri
>> teLib.inf
>> + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf
>> +
>> +
>> MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR
>> ea
>> + dLib.inf
>> +
>> MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable
>> Wr
>> + iteLib.inf
>> +
>> MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead
>> Lib
>> + .inf
>> +
>> MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit
>> eL
>> + ib.inf
>> +
>> MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i
>> + nf
>> + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib.
>> + inf
>>
>> [BuildOptions]
>> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
>> --
>> 2.28.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
2022-04-01 14:12 ` [edk2-devel] " Michael Kubacki
@ 2022-04-05 1:10 ` Michael Kubacki
0 siblings, 0 replies; 6+ messages in thread
From: Michael Kubacki @ 2022-04-05 1:10 UTC (permalink / raw)
To: devel, chasel.chiu; +Cc: Desimone, Nathaniel L, Gao, Liming, Dong, Eric
Just another reminder to please merge this patch if there is no further
feedback.
Thanks,
Michael
On 4/1/2022 10:12 AM, Michael Kubacki wrote:
> Thanks for the review.
>
> Can you please merge this soon if there are no concerns?
>
> On 3/23/2022 2:15 AM, Chiu, Chasel wrote:
>>
>> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
>>
>>> -----Original Message-----
>>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>>> Sent: Wednesday, March 23, 2022 9:28 AM
>>> To: devel@edk2.groups.io
>>> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
>>> <nathaniel.l.desimone@intel.com>; Gao, Liming
>>> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
>>> Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing
>>> libraries to [Components] in DSC
>>>
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619
>>>
>>> Adds libraries implemented in MinPlatformPkg to the [Components]
>>> section in MinPlatformPkg.dsc so they are included in the package build.
>>>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>> ---
>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>>> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>>> index 0f47182c2647..a8373a4ecb37 100644
>>> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>>> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
>>> @@ -211,6 +211,13 @@ [Components]
>>>
>>> MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.
>>> inf
>>>
>>> MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableRead
>>> Lib.inf
>>>
>>> MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWri
>>> teLib.inf
>>> + MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf
>>> +
>>> +
>>> MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableR
>>> ea
>>> + dLib.inf
>>> +
>>> MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariable
>>> Wr
>>> + iteLib.inf
>>> +
>>> MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableRead
>>> Lib
>>> + .inf
>>> +
>>> MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWrit
>>> eL
>>> + ib.inf
>>> +
>>> MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i
>>> + nf
>>> + MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib.
>>> + inf
>>>
>>> [BuildOptions]
>>> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
>>> --
>>> 2.28.0.windows.1
>>
>>
>>
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
2022-03-23 1:27 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC Michael Kubacki
2022-03-23 6:15 ` Chiu, Chasel
@ 2022-04-07 0:48 ` Nate DeSimone
2022-04-07 0:54 ` Nate DeSimone
2 siblings, 0 replies; 6+ messages in thread
From: Nate DeSimone @ 2022-04-07 0:48 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Chiu, Chasel, Gao, Liming, Dong, Eric
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
Sent: Tuesday, March 22, 2022 6:28 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619
Adds libraries implemented in MinPlatformPkg to the [Components] section in MinPlatformPkg.dsc so they are included in the package build.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index 0f47182c2647..a8373a4ecb37 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -211,6 +211,13 @@ [Components]
MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.inf
MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableReadLib.inf
MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLib.inf
+ MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf
+
+ MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableRea
+ dLib.inf
+ MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariableWr
+ iteLib.inf
+ MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableReadLib
+ .inf
+ MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteL
+ ib.inf
+ MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i
+ nf
+ MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib.
+ inf
[BuildOptions]
*_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
2022-03-23 1:27 [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC Michael Kubacki
2022-03-23 6:15 ` Chiu, Chasel
2022-04-07 0:48 ` Nate DeSimone
@ 2022-04-07 0:54 ` Nate DeSimone
2 siblings, 0 replies; 6+ messages in thread
From: Nate DeSimone @ 2022-04-07 0:54 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Chiu, Chasel, Gao, Liming, Dong, Eric
Pushed: https://github.com/tianocore/edk2-platforms/commit/edf5edf
-----Original Message-----
From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
Sent: Tuesday, March 22, 2022 6:28 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing libraries to [Components] in DSC
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619
Adds libraries implemented in MinPlatformPkg to the [Components] section in MinPlatformPkg.dsc so they are included in the package build.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index 0f47182c2647..a8373a4ecb37 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -211,6 +211,13 @@ [Components]
MinPlatformPkg/Library/BaseVariableReadLibNull/BaseVariableReadLibNull.inf
MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmVariableReadLib.inf
MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMmVariableWriteLib.inf
+ MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.inf
+
+ MinPlatformPkg/Library/DxeRuntimeVariableReadLib/DxeRuntimeVariableRea
+ dLib.inf
+ MinPlatformPkg/Library/DxeRuntimeVariableWriteLib/DxeRuntimeVariableWr
+ iteLib.inf
+ MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableReadLib
+ .inf
+ MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteL
+ ib.inf
+ MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableReadLib.i
+ nf
+ MinPlatformPkg/Library/BaseLargeVariableLib/BaseLargeVariableWriteLib.
+ inf
[BuildOptions]
*_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread