From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.4822.1622110512107042744 for ; Thu, 27 May 2021 03:15:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PugKCCdt; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622110511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qYzTovkgrTtU65my9ANagwCU5Y2LdJiJjpTGj0AGQWw=; b=PugKCCdtLiFTCLxbhAzR1jh5hyCUL88mmWEPxdlfNzmewdnl+eHwYxFEAvq7cVji8kQGlO DpOz7yxvyfDiew22KHCIygADfe3wQ5uyI7ktp76zPY/jWm0QQxgLtrICJgq5Nd68/D0kCD HdsVQoy/l4mHqGlDY/ljuMTuiF9tH8g= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-qA-GUUqHOQWn2Mm6RQMhVg-1; Thu, 27 May 2021 06:15:07 -0400 X-MC-Unique: qA-GUUqHOQWn2Mm6RQMhVg-1 Received: by mail-wr1-f70.google.com with SMTP id c13-20020a5d6ccd0000b029010ec741b84bso1530794wrc.23 for ; Thu, 27 May 2021 03:15:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qYzTovkgrTtU65my9ANagwCU5Y2LdJiJjpTGj0AGQWw=; b=PjWRiGq/SRTrlc3ZSJzPpdymEKRr2RUzIVrGdBhh8TfHok+nrhKpsvzXtM/3UmFDIr 5qRPNp6ha/Rm3WfgMJu1Hf43STXJhrH+Cf+pnRLU/ce1wzSyZmNY+bSYCeigwLsFAop/ tWuljbn/Sar3SIFcyVjss3qCRT/997g+idvivl8CEDrm/clm7M37DVeC7cEf3HYivlAk KgvEy53q1EWBhd2DWtJFzqXWqC8vvEK/E6zS0EMdgJCA1K4KHMd/gKEHVf5LPIPvkfKl aT0tU5Ygsf747vt03QAx5VcUhWq0/wk4wsTnnfVFq4BE/ZlKAXlVpDaWR49v2iW/tyfA SNUw== X-Gm-Message-State: AOAM531nKlM+wBc34Btks7Qodb/lsQ4BG1l0ivekvE1AD6F25TgWvqXx QMUYjqbXg5KkQ32X/Zp9ausWqk3kt3/QimzEUBPiO+DbnsQ2SA65A4fZvBWc5/e5BNnZNdWdPw0 5BZ4LpHHcvp7TTA== X-Received: by 2002:a05:600c:2dc8:: with SMTP id e8mr7595119wmh.72.1622110506563; Thu, 27 May 2021 03:15:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTp1KhPjHK9XMkeYCpApjQN+nxLFoWT0Npt+j/rMoiGi2GWyIieLTtvln6JgNjFEfAIcSZdg== X-Received: by 2002:a05:600c:2dc8:: with SMTP id e8mr7595099wmh.72.1622110506378; Thu, 27 May 2021 03:15:06 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id t5sm10301600wmi.32.2021.05.27.03.15.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 03:15:06 -0700 (PDT) Subject: Re: [PATCH 03/43] OvmfPkg: switch IA32, IA32X64, X64 to the fw_cfg-only ACPI platform driver To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-4-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 12:15:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-4-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > Switch the historical OvmfPkg* platforms from the AcpiPlatformDxe driver > to the QemuFwCfgAcpiPlatformDxe driver. (The latter is used by the > ArmVirtQemu* platforms as well.) > > The change effectively replaces the following call tree: > > InstallAcpiTables [AcpiPlatform.c] > > XenDetected [XenPlatformLib] * > InstallXenTables [Xen.c] * > GetXenAcpiRsdp [Xen.c] * > > InstallQemuFwCfgTables [QemuFwCfgAcpi.c] > ... > > InstallOvmfFvTables [AcpiPlatform.c] * > QemuDetected [Qemu.c] * > LocateFvInstanceWithTables [AcpiPlatform.c] * > QemuInstallAcpiTable [Qemu.c] * > QemuInstallAcpiMadtTable [Qemu.c] * > CountBits16 [Qemu.c] * > QemuInstallAcpiSsdtTable [Qemu.c] * > GetSuspendStates [Qemu.c] * > PopulateFwData [Qemu.c] * > > with the one below: > > InstallAcpiTables [QemuFwCfgAcpiPlatform.c] > InstallQemuFwCfgTables [QemuFwCfgAcpi.c] > ... > > eliminating the sub-trees highlighted with "*". > > There are two consequences: > > (1) Xen compatibility is removed from the ACPI platform driver of the > historical OvmfPkg* platforms. > > (2) The ACPI tables that are statically built into OVMF (via > "OvmfPkg/AcpiTables/AcpiTables.inf") are never installed. In > particular, OVMF's own runtime preparation of the MADT and SSDT is > eliminated. > > Because of (2), remove the "OvmfPkg/AcpiTables/AcpiTables.inf" module as > well -- and then the ACPITABLE build rule too. > > Note that (2) only removes effectively dead code; the QEMU ACPI > linker-loader has taken priority since QEMU 1.7.1 (2014). References: > > - https://wiki.qemu.org/Planning/1.7 > - https://wiki.qemu.org/Features/ACPITableGeneration > - edk2 commit 96bbdbc85693 ("OvmfPkg: AcpiPlatformDxe: download ACPI > tables from QEMU", 2014-03-31) > - edk2 commit 387536e472aa ("OvmfPkg: AcpiPlatformDxe: implement QEMU's > full ACPI table loader interface", 2014-09-22) > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/OvmfPkgIa32.dsc | 3 +-- > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +-- > OvmfPkg/OvmfPkgX64.dsc | 3 +-- > OvmfPkg/OvmfPkgIa32.fdf | 9 +-------- > OvmfPkg/OvmfPkgIa32X64.fdf | 9 +-------- > OvmfPkg/OvmfPkgX64.fdf | 9 +-------- > 6 files changed, 6 insertions(+), 30 deletions(-) Reviewed-by: Philippe Mathieu-Daude