From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.3686.1586411437416480721
 for <devel@edk2.groups.io>;
 Wed, 08 Apr 2020 22:50:37 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB8F030E;
	Wed,  8 Apr 2020 22:50:36 -0700 (PDT)
Received: from [10.37.8.121] (unknown [10.37.8.121])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E2EE73F68F;
	Wed,  8 Apr 2020 22:54:48 -0700 (PDT)
Subject: Re: [PATCH edk2-platforms 1/1] Platform/DeveloperBox: omit TPM from DT when building without TPM support
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io
References: <20200408170031.898-1-ard.biesheuvel@arm.com>
 <20200408205829.GY14075@vanye>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <fd17716c-079c-c001-cbce-23202d65505d@arm.com>
Date: Thu, 9 Apr 2020 07:50:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200408205829.GY14075@vanye>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/8/20 10:58 PM, Leif Lindholm wrote:
> On Wed, Apr 08, 2020 at 19:00:31 +0200, Ard Biesheuvel wrote:
>> The recently added support for TPM2 measured boot added a description of
>> the TPM to the device tree, but failed to take the build configuration
>> into account, and so it adds it unconditionally.
>>
>> Fix this, by #define'ing a TPM2_ENABLE CPP macro that can be referenced
>> in the device tree source file.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 

Pushed, thanks.