Re: [PATCH 1/1] Platform/ARM/JunoPkg: Don't setup PCIe root bridge for Juno-r0

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Pierre,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 13/04/2023 02:14 pm, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> Booting a Juno-r0 with a DEBUG build triggers an ASSERT when
> processing the library constructors of:
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
>
> JunoPciHostBridgeLib.inf::HWPciRbInit() returns an error code
> as Juno-r0 doesn't support PCIe.
>
> Check Juno's revision in HWPciRbInit() before setting up the
> PCIe root complex.
>
> Reported-by: Fabien Ficheau <fabien.ficheau@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>   .../ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
> index 0755dc155616..583efd0efb16 100644
> --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
> +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
> @@ -69,6 +69,13 @@ HWPciRbInit (
>     UINTN                   TranslationTable;
>     EFI_CPU_IO2_PROTOCOL    *CpuIo;
>     EFI_STATUS              Status;
> +  UINT32                  JunoRevision;
> +
> +  GetJunoRevision (JunoRevision);
> +  DEBUG ((DEBUG_ERROR, "Juno rev=%d\n", JunoRevision));
> +  if (JunoRevision == JUNO_REVISION_R0) {
> +    return EFI_SUCCESS;
> +  }
>   
>     PCI_TRACE ("VExpressPciRbInit()");
>