From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.49]) by mx.groups.io with SMTP id smtpd.web10.17767.1681401890723275851 for ; Thu, 13 Apr 2023 09:04:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=c0EHwRqf; spf=pass (domain: arm.com, ip: 40.107.6.49, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KdgrikYJKFUu7aggC2jqktLRVQsy7/Uh1zt4Oj9NqcU=; b=c0EHwRqfv3SM9CLn3GDHkYkVfOinL5bD5YA/c0UsqBNI6ZBjeGHJi8LHv7x+Mu+uwRufe1K/4U2aI/s5qYb+LbhDL6Hqk8XIqvYTfwaLPtRXE9zdJxBTvIhXECDStAWR54uuodJyRYhZfgcDgm9J1kq3G/7icH644Mr+lx9tQ4I= Received: from AS9PR05CA0216.eurprd05.prod.outlook.com (2603:10a6:20b:494::6) by AS4PR08MB7580.eurprd08.prod.outlook.com (2603:10a6:20b:4ff::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 16:04:47 +0000 Received: from AM7EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:494:cafe::e6) by AS9PR05CA0216.outlook.office365.com (2603:10a6:20b:494::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.31 via Frontend Transport; Thu, 13 Apr 2023 16:04:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT061.mail.protection.outlook.com (100.127.140.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30 via Frontend Transport; Thu, 13 Apr 2023 16:04:46 +0000 Received: ("Tessian outbound 3570909035da:v136"); Thu, 13 Apr 2023 16:04:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 52b91640dd9c71ff X-CR-MTA-TID: 64aa7808 Received: from d9203c4e77e6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D0E02568-E089-43F3-9277-833E4EC7CC24.1; Thu, 13 Apr 2023 16:04:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d9203c4e77e6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 13 Apr 2023 16:04:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bnOnX9z0LIJtonnV5+osQdDN6u3j3aN212ag12oBcmQ8FyAI/6tCjsYJNwWulzaA9KEnnYxsLkAf5kNmQWe/hsPfH+Y8ylPe7C3Y2ZoNXaBUv8gH7ooUYKCXEz/nXZGN8ifHehiWYpFxbjSor5ynl7cUq1a72sgz25dLxfgWBbuOPmtGYrsVlAepaBAHgjeoE8qc5XWEvhAMnxc+iA5eyBtFwC1L+CjFS9lWAoab43nipn//ZFbMq3PS44ZPnCrar0gU3NU4ZF4VFhmutACPnGCismryRNu0sa9kcTMqkXkiWTFqgytOw5/6e5nfGZuVq5PfB8tjfHnEY2Mkm6FyEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KdgrikYJKFUu7aggC2jqktLRVQsy7/Uh1zt4Oj9NqcU=; b=Zvh0Qh/gc0rnQJ3vmjP19+WB3vDaxjqiLCRSAvCsLPPhJjSOa5JBn+37tqCSZLF3owV2LLg6G6lgwGJEwoXwwKKiyt53QvlcTQmly+NFfAvxTDKE+fcsqNBAf7TVQL6mQZn4ca7jyf3yE61sWBqIBQIeVQUUG20/2y7edvOaLMZThVzTq8k5kYFQaHwD0BHOe5O7DVO5iLq0epXsk1gjjz1aiHFCuOoQaEn4/89V1Bjx3Gsn+OY9qsUN6KfVzjXL+BBqLBut8DyAGFUk93W9UZvAUae1OiX1o1onHfZZQgt1YBFZ7UTLEYIK8MhDH/76R+ZUvagg/V/MysPoswJmxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KdgrikYJKFUu7aggC2jqktLRVQsy7/Uh1zt4Oj9NqcU=; b=c0EHwRqfv3SM9CLn3GDHkYkVfOinL5bD5YA/c0UsqBNI6ZBjeGHJi8LHv7x+Mu+uwRufe1K/4U2aI/s5qYb+LbhDL6Hqk8XIqvYTfwaLPtRXE9zdJxBTvIhXECDStAWR54uuodJyRYhZfgcDgm9J1kq3G/7icH644Mr+lx9tQ4I= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6615.eurprd08.prod.outlook.com (2603:10a6:20b:335::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Thu, 13 Apr 2023 16:04:31 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c%8]) with mapi id 15.20.6277.038; Thu, 13 Apr 2023 16:04:31 +0000 Message-ID: Date: Thu, 13 Apr 2023 17:04:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/1] Platform/ARM/JunoPkg: Don't setup PCIe root bridge for Juno-r0 To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Thomas Abraham , Ard Biesheuvel , Fabien Ficheau , "nd@arm.com" References: <20230413131448.70329-1-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20230413131448.70329-1-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0588.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS8PR08MB6615:EE_|AM7EUR03FT061:EE_|AS4PR08MB7580:EE_ X-MS-Office365-Filtering-Correlation-Id: e568caa7-96a3-433d-7544-08db3c38cda6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9qZ4UQ8vqDfI36wfSCEY/ykRsOsaO6P+/SIO5jKpreL9ug/la30hebBHkBoU1UA5M8ibTNgA14AE9NN1iQiUXvpYAJ94Cl0mww6RQAFE8CL6/k9ef0/eZvzm/QP1hi6GgdRizGSoa6DGlk33oO29HEkY3rNqOg5s0Ayu50Gztt2ht3CBjD+2SqVsZ2Jr2ZXSQFebYcvpZaO/G0S6NHNz+utAmWpwOLNTwjui/8VBkjDbfHK5qD5izGJEYUcdIjiYq8nmEqSRsPul0E3kFM4f6gWf+WT3dsNc8+WcWfl4cXKO7Fxab1mrmxUD2YCh6cSWKyjD7vGVFHb0cmToj2HQfy7DUFXxbVvBkuEq3bHPMcUE+4VcO+qtabVtQpd5FqgzOGSHhpVZUE8mQu5JMmOAcBcarjHQAUhkNRouOcLZvwBOh8dBz9xmAU2C8g1E4Ozqxx+zglDvHTLxLweQrp8WYoSV89/TQsmpfdxf8e7m3JZG0zaHAEJyIoq25K8GfoPshbUb9XKwWquT+BR/05TibflOFvPK4VijVsP4at6cBSvakZSSxPwK34fFf2YVF6Zl2L6r8s1gZfhGgV11f4/ZcBdQ77OyPlDkDvJqL4R3GavRVeDkzyFaNcjVCxTaUYm2A9wi4VJcbY0KSpKmQMs5zg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(366004)(376002)(136003)(39860400002)(451199021)(2906002)(31686004)(8676002)(8936002)(5660300002)(44832011)(478600001)(41300700001)(316002)(66946007)(66476007)(36756003)(66556008)(54906003)(4326008)(186003)(86362001)(38100700002)(6486002)(6506007)(6666004)(26005)(53546011)(6512007)(2616005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6615 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 985f0447-3da1-47b6-9565-08db3c38c36d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O7NWniW+CmuZrqKJ9RLAALuC6Pvy8Gq/G+u7yj8dKJIsTTcXqWVUAAsLLn+YTGmGmudxWx9BEjS2uawAcrfMX3IxJuU+1Gq818qq7qBfOTpqmX0QnDoygqfTZ/B8sjLAv0+TnRGjtxBC1lmcic3LCYCQARyOWB3fgACoEdewt/NjXvdqT++nMcKPSYXBbkV8JGItjHuNyrGbU+hmNzCBc44nPSD8h4H72F7E13UYuQ9LHMZ0jpKI+xaptMWqOYhXeIO84dGp2FAI12mED0uSSN6zhhM8qTeN9PNBtTWDWuOfrQNnK1NzxRJD4Rt8HW6qeIfeTjHgi3siJoqa78PdGLbaT5TqFYatCdW7yzbCi4vOsqi0tPTAI/ZLrtzpoHPbzHJf44/Pv2kETHmQjuuKwfeiMig5S1KdOmr6EOQWdDs6U7vmsPKvmMJ1V6YGH3Z57uXqKn/chepFvsXch3sJgO0xqyznIeXAJ3OXzVJ0NdhCSnA/sloGFnIecEuHiUM00gtX8k8SIibA0c3AduJbCU8eYLvH9y07Yznzk42BY6kdMG1s1jxJ6bPCp/cY5y7OcA0NDNjPKTOaJOujA/7iMF6aFvbDM0ZSIIZVCFYYpU8BHS4NoIHIIn/6gkHfz5x4ATHosr8ElNdZtc6t9Jxi/Il+vpCIMY14WXUY4VYonuTZtMbN2sYsjVQuC7yXSWdHGS6KRK4aitPfDS0KdP7naBmWN7RH7WQNU+TSTcbYfXg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199021)(46966006)(36840700001)(40470700004)(8676002)(8936002)(41300700001)(5660300002)(44832011)(31686004)(4326008)(81166007)(316002)(356005)(2906002)(70206006)(70586007)(31696002)(478600001)(54906003)(86362001)(6486002)(82740400003)(6666004)(53546011)(186003)(6512007)(6506007)(40460700003)(82310400005)(336012)(26005)(40480700001)(36860700001)(2616005)(36756003)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 16:04:46.8505 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e568caa7-96a3-433d-7544-08db3c38cda6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7580 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 13/04/2023 02:14 pm, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Booting a Juno-r0 with a DEBUG build triggers an ASSERT when > processing the library constructors of: > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > > JunoPciHostBridgeLib.inf::HWPciRbInit() returns an error code > as Juno-r0 doesn't support PCIe. > > Check Juno's revision in HWPciRbInit() before setting up the > PCIe root complex. > > Reported-by: Fabien Ficheau > Signed-off-by: Pierre Gondois > --- > .../ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c > index 0755dc155616..583efd0efb16 100644 > --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c > +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c > @@ -69,6 +69,13 @@ HWPciRbInit ( > UINTN TranslationTable; > EFI_CPU_IO2_PROTOCOL *CpuIo; > EFI_STATUS Status; > + UINT32 JunoRevision; > + > + GetJunoRevision (JunoRevision); > + DEBUG ((DEBUG_ERROR, "Juno rev=%d\n", JunoRevision)); > + if (JunoRevision == JUNO_REVISION_R0) { > + return EFI_SUCCESS; > + } > > PCI_TRACE ("VExpressPciRbInit()"); >