From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.1699.1587482879802493335 for ; Tue, 21 Apr 2020 08:28:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=htn7zJPj; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587482879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kz4hMEUeIf8/7EElR5YLefdurwl9PMlHBuvNZwDJMGA=; b=htn7zJPjhJqLz341wfbrMQSfsAOs29cUuHgMjbj7Kgr4yUtPyPBJnF/9LmteZQu8tCYNXF 8Y8Is6wHyFZJ14AO3RsEGyRmOWVOfSP1z2u6w7kEQWQGeIhbpmH6aw6UYmFRxKMIlsp1Fu 4wp4KAmkVkWf9gJpjBmr+bXAbcNMpRY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-UsqL-hGmMmexDn4rdLTDIA-1; Tue, 21 Apr 2020 11:27:47 -0400 X-MC-Unique: UsqL-hGmMmexDn4rdLTDIA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0519614E1; Tue, 21 Apr 2020 15:27:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-52.ams2.redhat.com [10.36.115.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id E97E65DA7C; Tue, 21 Apr 2020 15:27:42 +0000 (UTC) Subject: Re: [PATCH v3 0/6] Add BhyvePkg, to support the bhyve hypervisor To: Rebecca Cran , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel , Leif Lindholm , Michael Kinney , Andrew Fish , Peter Grehan References: <20200421030955.114850-1-rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 21 Apr 2020 17:27:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200421030955.114850-1-rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Hi Rebecca, On 04/21/20 05:09, Rebecca Cran wrote: > I noticed a few things wrong with the v2 series: > > o BhyveFwCtlLibNull is no longer used, and could be deleted. > o Some changes from the v1 AcpiPlatformDxe patch were left in OvmfPkg. > o BhyvePkg/License.txt still referred to OvmfPkg. I've updated it so > everything under BhyvePkg should be BSD-2-Clause. > > This patch series can also be found at > https://git.bsdio.com/bcran/edk2-bhyve/commits/branch/master > > Signed-off-by: Rebecca Cran > > Rebecca Cran (6): > OvmfPkg: Add bhyve support into AcpiTimerLib > OvmfPkg: Add QemuFwCfgLibNull > OvmfPkg: Add VBE2 mode info structure to LegacyVgaBios.h > Add BhyvePkg, to support the bhyve hypervisor > BhyvePkg: Add PlatformPei > BhyvePkg: Add AcpiPlatformDxe Sorry, I'm confused by the structure of this series / updates in this series. (1) For example, I can't find the patch that adds "BhyvePkg/BhyvePkgX64.dsc", in spite of the file being listed in the cumulative diffstat below. (2) I also don't really understand why v2 / v3 have been posted, given that the bhyve-specific ResetSystemLib instance that I suggested under v1, based on your proposed code, still depends on the ResetSystemLib cleanup series that I posted. The idea is that you would base the new bhyve ResetSystemLib instance on my ResetSystemLib refactoring. Because my series has not been merged yet, for such a bhyve rebase you'd have to pick up my patches from the list temporarily. That's a 100% usable approach, but then, this v3 series of yours does not seem to introduce *any* ResetSystemLib instance. Have you decided to postpone that work for later? (Unfortunately, I can't check the ResetSystemLib resolution that you use in "BhyvePkgX64.dsc", because, again, the v3 series doesn't actually *contain* "BhyvePkgX64.dsc".) (3) Regarding the v2 set -- there you mention: On 04/21/20 04:04, Rebecca Cran wrote: > changing FILE_GUIDs to be unique > (except AcpiTables, which needs to be the same between OvmfPkg and > BhyvePkg), and I don't understand that... Oh wait, I do: the GUID 7E374E25-8E01-4FEE-87F2-390C23C606CD is a well-known GUID (inside ek2, that is). It's not specific to OvmfPkg. BaseTools calls the GUID "ACPI table storage", and it is declared in "MdeModulePkg/MdeModulePkg.dec", as "PcdAcpiTableStorageFile" ("FFS filename to find the ACPI tables"). In the end, please wait until I get around merging the ResetSystemLib refactoring . Then, please post a new, comprehensive bhyve set. Patch sets pending review on a mailing list are not incremental; new versions entirely supersede earlier versions. Patches are considered incremental only when (a) earlier patches have been merged, or (b) there's an agreement that in the particular situation a new patch (or a few patches) can be appended to a pending series. Thanks Laszlo